[fixed] CMSMailer help generates error

[drmikecrowe]

From module-manager, clicking on "Help" for CMSMailer generates the following:

Code: Select all

PHP Fatal error:  Uncaught exception 'CmsException' with message 'Call to invalid method FriendlyName on cms_mailer object' in /var/www/modules/CMSMailer/CMSMailer.module.php:125
Stack trace:
#0 /var/www/modules/ModuleManager/action.local_help.php(39): CMSMailer->__call('FriendlyName', Array)
#1 /var/www/modules/ModuleManager/action.local_help.php(39): CMSMailer->FriendlyName()
#2 /var/www/lib/classes/class.CMSModule.php(1367): include('/var/www/...')
#3 /var/www/modules/ModuleManager/ModuleManager.module.php(91): CMSModule->DoAction('local_help', 'm1_', Array, '')
#4 /var/www/lib/classes/class.CMSModule.php(1431): ModuleManager->DoAction('local_help', 'm1_', Array, '')
#5 /var/www/admin/moduleinterface.php(102): CMSModule->DoActionBase('local_help', 'm1_', Array)

I've checked all other modules (installed, including several I installed), no others have this issue.

I think this is because CMSMailer has this code:

Code: Select all

  public function __call($method,$args)
  {
    if( method_exists($this->the_mailer,$method) ) {
      return call_user_func_array(array($this->the_mailer,$method),$args);
    }
    throw new CmsException('Call to invalid method '.$method.' on '.get_class($this->the_mailer).' object');
    // todo, throw exception here.
  }

which is triggered by this in ModuleManager/action.local_help.php:

Code: Select all

$smarty->assign('friendly_name',$modinstance->FriendlyName());

[Rolf]

Confirmed in SVN rev. 9630

[Rolf]

Fixed in SVN rev. 9631