To avoid "Warning: Parameter x is not known by module y" - CMSMS up to v.1.6.0

[vilkis]

See in comments of  http://dev.cmsmadesimple.org/bug/view/3138 how to reproduce the bug.  See the topic http://forum.cmsmadesimple.org/index.ph ... 50024.html for more examples. I treat it as the bug of CMSMS core.

My approach:

place lines in file plugins/function.content.php

Code: Select all

//Vilkis BEGIN
	
			 $smarty->calculate=1;
			$oldvalue = $smarty->caching;
			$smarty->caching = false;
			$result = $smarty->fetch(str_replace(' ', '_', 'content:' . (isset($params['block'])?$params['block']:'content_en')), '', $pageinfo->content_id);
			$smarty->caching = $oldvalue;
			$smarty->calculate=0; 
	//Vilkis END 

after lines

Code: Select all

						$returnid = '';
							if (isset($params['returnid']))
							{
								$returnid = $params['returnid'];
							}
else
{
	$returnid = $pageinfo->content_id;
}
$result = $cmsmodules[$modulename]['object']->DoActionBase($action, $id, $params, $returnid);
if ($result !== FALSE)
{
  echo $result;
}

$modresult = @ob_get_contents();
@ob_end_clean();

AND modify the file lib/module.functions.php :

place a line

Code: Select all

if ($smarty->calculate==1) return;

after lines

Code: Select all

function cms_module_plugin($params,&$smarty)
{
	global $gCms;
	$cmsmodules = &$gCms->modules;

	$id = 'm' . ++$gCms->variables["modulenum"];

I hope it will help somebody.

Vilkis



EDIT: As Mark reminded me.

WARNING Before you make any modification read this topic and make a backup of files.

[Dr.CSS]

You have to understand that if you or anyone else does any hacks to core functions we can't support them, just fyi...

[vilkis]

So? Do you recommend to not post such information in this forum?


Vilkis

[vilkis]

Hi,
It seems that this bug was fixed (http://dev.cmsmadesimple.org/bug/view/3138), but I do not know where to get the fix, so I can not to test it.

Vilkis

[tyman00]

It is part of 1.6, you should be able to test it once it is released to the public.

[vilkis]

Thank you.

Vilkis

PS I can not understand such an "open" policy of the open source community.

[tyman00]

I am not sure I understand.

If you are referring to the closed beta, it is explained why they are trying it this way this time. I think it makes sense because public beta cycles have not proven to be very efficient in the past. This way there is better communication and a sense of responsibility so the testing is actually completed properly.

[vilkis]

Maybe. The future will show rightness of this way.
Thanks again for explanation.

Vilkis

[vilkis]

It's pity to say, but this problem is not solved in 1.6.0 version of CMSMS.
vilkis

[vilkis]

I attach patches for two files of CMSMS v1.6.0.
vilkis

[tyman00]

Can you please indicate how it is not working. It was tested ok when patched.

[vilkis]

Ok, but later. Actually message "Warning: Parameter x is not..." does not appear, now, but modules in content is not counted in right way.
vilkis

[calguy1000]

It's pity to say, but this problem is not solved in 1.6.0 version of CMSMS.
vilkis

Three more man hours of testing have proved that this issue is solved in 1.6... by myself, and two other dev team members on seperate installs.

[tyman00]

Can you please provide a link and/or screenshots and/or screencast videos? We are trying to replicate this issue but are not able to replicate it. We are not getting those error messages or behaviors with your past FEU or News/Printing examples. Thanks

[vilkis]

Later. I'm sorry, I am very busy now. Thanks for your efforts. It could be that I am doing something wrong, but I see in code that modules is not counted in content...
vilkis