[solved] NFS class & id not whowing correct

[makismakana]

i just found some... not errors, but something was missing from the code for class and id to function.

The problem was that if you enter class="something" or id="something" in the smarty tag, in the html code there was the last " missing, eg



was displayed instead of



.
For correcting this you have to go to /modules/NFS/action.default.php and in lines 297 to 315 you should change the code to

Code: Select all

$css_class = '';
if(isset($params['class']) && $overwrite_params == false && $params['class'] != '')
	$css_class = ' class="'.$params['class'].'"';
else
{
	$scroll_class = $this->GetPreference('css_class', '');
	if($scroll_class != '')
		$css_class = ' class="'.$scroll_class.'"';
}

$css_id = '';
if(isset($params['id']) && $overwrite_params == false && $params['id'] != '')
	$css_id = ' id="'.$params['id'].'"';
else
{
	$scroll_id = $this->GetPreference('css_id', '');
	if($this->GetPreference('css_id', '') != '')
		$css_id = ' id="'.$scroll_id.'"';
}

i hope it will be helpful.

[makismakana]

another error i found is that if you use pretty urls in your config.php

Code: Select all

$config['internal_pretty_urls'] = true;

then the links that NFS creates dont work for me. Should be like this http://server/cmsms/index.php/el/news/2/62/test-press" but it really is like http://server/cmsms/index.php/el/news/2/62/"

so i found a temporary sollution, which is...

you go to /modules/NFS/action.default.php again and in line 257, 258 and 259 you delete ", true, $prettyurl" from the end of every line, so it wont display pretty urls for NFS module. So the code will look like this:

Code: Select all

	$onerow->link = $news->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, '', $sendtodetail,'', true, false, '');
	$onerow->titlelink = $news->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $row['news_title'], $sendtodetail, '', false, false, '');
	$onerow->morelink = $news->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $moretext, $sendtodetail, '', false, false, '');

instead of

Code: Select all

	$onerow->link = $news->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, '', $sendtodetail,'', true, false, '', true, $prettyurl);
	$onerow->titlelink = $news->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $row['news_title'], $sendtodetail, '', false, false, '', true, $prettyurl);
	$onerow->morelink = $news->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $moretext, $sendtodetail, '', false, false, '', true, $prettyurl);

Oh i forgot to mention that i use cms multilanguage 1.3.1