Page 1 of 1

Bug in the siteprefs.php file

Posted: Tue Nov 27, 2007 9:59 pm
by phicha
Hello there,

I just upgraded to the 1.2.1 version. The file siteprefs.php in admin directory has a bug. If you put a specific maintenance part message, CMSMS add some HTML code. And you cannot remove it definitively.
This code is put between comments tags which are mispaced.
So I removed those lines and everything seems to be ok.

Best regards.
Philippe

Re: Bug in the siteprefs.php file

Posted: Wed Nov 28, 2007 5:53 pm
by tsw
cannot see it on my installation

[identified] Re: Bug in the siteprefs.php file

Posted: Thu Nov 29, 2007 9:14 am
by phicha
If you put a comment in your maintenance page like
or this behavior should be.

If your comment is like:

it doesn't appear.

Best regards.
Philippe

Re: Bug in the siteprefs.php file

Posted: Thu Nov 29, 2007 9:27 am
by tsw
Still cannot replicate this.

Re: Bug in the siteprefs.php file

Posted: Thu Nov 29, 2007 9:39 am
by phicha
I can not understand. This is a test URL:
http://test.migratech.fr
if you want to connect as admin: test/test

Philippe

Re: Bug in the siteprefs.php file

Posted: Thu Nov 29, 2007 9:53 am
by tsw
Now I see something,

Can you test if this diff helps


Index: siteprefs.php
===================================================================
--- siteprefs.php      (revision 4268)
+++ siteprefs.php      (working copy)
@@ -378,7 +378,7 @@
               
               
                        :
-                     
+                     
               
               

Re: Bug in the siteprefs.php file

Posted: Thu Nov 29, 2007 10:00 am
by phicha
Ok.
As far as I could test, it's ok now.

Best regards.

Re: Bug in the siteprefs.php file

Posted: Thu Nov 29, 2007 10:32 am
by tsw
Ok, thanks