Bug in the siteprefs.php file

Talk about writing modules and plugins for CMS Made Simple, or about specific core functionality. This board is for PHP programmers that are contributing to CMSMS not for site developers
Post Reply
User avatar
phicha
Forum Members
Forum Members
Posts: 22
Joined: Wed Jul 18, 2007 8:20 am
Location: Caen

Bug in the siteprefs.php file

Post by phicha »

Hello there,

I just upgraded to the 1.2.1 version. The file siteprefs.php in admin directory has a bug. If you put a specific maintenance part message, CMSMS add some HTML code. And you cannot remove it definitively.
This code is put between comments tags which are mispaced.
So I removed those lines and everything seems to be ok.

Best regards.
Philippe
Philippe
tsw
Power Poster
Power Poster
Posts: 1408
Joined: Tue Dec 13, 2005 10:50 pm
Location: Finland

Re: Bug in the siteprefs.php file

Post by tsw »

cannot see it on my installation
User avatar
phicha
Forum Members
Forum Members
Posts: 22
Joined: Wed Jul 18, 2007 8:20 am
Location: Caen

[identified] Re: Bug in the siteprefs.php file

Post by phicha »

If you put a comment in your maintenance page like
or this behavior should be.

If your comment is like:

it doesn't appear.

Best regards.
Philippe
Philippe
tsw
Power Poster
Power Poster
Posts: 1408
Joined: Tue Dec 13, 2005 10:50 pm
Location: Finland

Re: Bug in the siteprefs.php file

Post by tsw »

Still cannot replicate this.
User avatar
phicha
Forum Members
Forum Members
Posts: 22
Joined: Wed Jul 18, 2007 8:20 am
Location: Caen

Re: Bug in the siteprefs.php file

Post by phicha »

I can not understand. This is a test URL:
http://test.migratech.fr
if you want to connect as admin: test/test

Philippe
Philippe
tsw
Power Poster
Power Poster
Posts: 1408
Joined: Tue Dec 13, 2005 10:50 pm
Location: Finland

Re: Bug in the siteprefs.php file

Post by tsw »

Now I see something,

Can you test if this diff helps


Index: siteprefs.php
===================================================================
--- siteprefs.php      (revision 4268)
+++ siteprefs.php      (working copy)
@@ -378,7 +378,7 @@
               
               
                        :
-                     
+                     
               
               
User avatar
phicha
Forum Members
Forum Members
Posts: 22
Joined: Wed Jul 18, 2007 8:20 am
Location: Caen

Re: Bug in the siteprefs.php file

Post by phicha »

Ok.
As far as I could test, it's ok now.

Best regards.
Philippe
tsw
Power Poster
Power Poster
Posts: 1408
Joined: Tue Dec 13, 2005 10:50 pm
Location: Finland

Re: Bug in the siteprefs.php file

Post by tsw »

Ok, thanks
Post Reply

Return to “Developers Discussion”