Banners module update?

Talk about writing modules and plugins for CMS Made Simple, or about specific core functionality. This board is for PHP programmers that are contributing to CMSMS not for site developers
Post Reply
Zappa
Forum Members
Forum Members
Posts: 53
Joined: Thu Jan 04, 2007 9:44 pm

Banners module update?

Post by Zappa »

I've noticed that the Banners module is no longer being updated in the development area so it can't be used anymore with CMS 1.2.3. Is there any other modules that people have created to take over this one yet? I'm looking for a banner module with pretty urls if possible....

Thanks  :)
MasterLee
Forum Members
Forum Members
Posts: 13
Joined: Wed Mar 12, 2008 7:21 pm

Re: Banners module update?

Post by MasterLee »

Hi,

I also run into that problem so now im trying to display the banners myself i will let you know when im done, maybe not in the niced way but it will work..
niedermayer
Forum Members
Forum Members
Posts: 11
Joined: Thu Feb 15, 2007 10:20 am

Re: Banners module update?

Post by niedermayer »

I'm using the banners module on a site running v.1.2.3. Haven't had any trouble with it so far.
MasterLee
Forum Members
Forum Members
Posts: 13
Joined: Wed Mar 12, 2008 7:21 pm

Re: Banners module update?

Post by MasterLee »

yes i had an error when i tryed to display the banner on my website..

Now im trying to rewrite the action.default.php file so banners will be shown on the website

The only things that i have to build are:

1. update the db when the banner is clicked
2. Max number of clicks check
3. when you create a banner the end date is not saved (nice to have)

i will see if i can send you the code when im done

Marco
calguy1000
Support Guru
Support Guru
Posts: 8169
Joined: Tue Oct 19, 2004 6:44 pm
Location: Fernie British Columbia, Canada

Re: Banners module update?

Post by calguy1000 »

You could try getting the latest svn version of the banners module, I did fix some date stuff with it the other day.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
MasterLee
Forum Members
Forum Members
Posts: 13
Joined: Wed Mar 12, 2008 7:21 pm

Re: Banners module update?

Post by MasterLee »

oke i will try that than

Edit:

Oke i have downloaded the files from this location: http://dev.cmsmadesimple.org/scm/?group_id=16

then clicked -> [Download The Nightly SVN Tree Snapshot]

In the admin the tabs work better, it remebers where you are and the given end date is saved in the db  ;D

The only problem still is showing the banner on the website  ::)

i still get an error ERROR: Could not find category (no rows) error in database!

I have edited the action.default.php and printed the value of $params['category'] in my case this was the output 'home'

i think is we strip out of the string we are there..

Marco
Last edited by MasterLee on Wed Mar 19, 2008 6:54 pm, edited 1 time in total.
MasterLee
Forum Members
Forum Members
Posts: 13
Joined: Wed Mar 12, 2008 7:21 pm

Re: Banners module update?

Post by MasterLee »

Found another small bug

If you try to save a banner that never ends you get a database error, so now you always have to set an end date

Marco
calguy1000
Support Guru
Support Guru
Posts: 8169
Joined: Tue Oct 19, 2004 6:44 pm
Location: Fernie British Columbia, Canada

Re: Banners module update?

Post by calguy1000 »

Okay, I just updated banners, did some testing, changed the licensing, bumped the version, etc, etc, etc.  and all seems fine to me. 

Once the translators catch up I'll throw out another release.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
MasterLee
Forum Members
Forum Members
Posts: 13
Joined: Wed Mar 12, 2008 7:21 pm

Re: Banners module update?

Post by MasterLee »

oke tanks

Let us know when the new release is there  ;D

Marco
resistem
Forum Members
Forum Members
Posts: 28
Joined: Thu Oct 25, 2007 6:41 pm

Re: Banners module update?

Post by resistem »

I would be really really grateful if the new Banners module would be downloadable as a tar.gz file next to the xml file. Thanks in advance.
Post Reply

Return to “Developers Discussion”