Couldn't login, fixed, is this the solution?

[mdc]

I had upgraded all of my sites to 1.2.3  It seemed to work, but at some point I couldn't login to any of them as admin.  I don't think I changed anything.  Basically login.php would redirect me back to login.php

Based on this: http://forum.cmsmadesimple.org/index.php?PHPSESSID=b4afb0a2444ebe3266abdeaa3a9c428f&topic=5451.0

I put this code in include.php:

Code: Select all

$dirname = dirname(__FILE__);
session_set_cookie_params(0 , '/', $_SERVER['HTTP_HOST']);
session_save_path($dirname.'/tmp/cache');

and that fixed the login for all three sites.  I am wondering if this is the right way to fix it, and if anyone know what I might have fixed? (I checked and my php.ini hasn't been changed in a log time either).