Banners Module

[calguy1000]

The first version of the banners module for 0.1x is available in the wili

take a look people, and get back to me if you find anything wonky, or have a question.

Thanks.

[Bangkok Bob]

Hi Calguy,

A great module (especially considering the reported consumption of nine pints of beer), one that is easy to install and setup and with good options for banner display.

One question though, is how to get the link to open in a new window, as in target=_blank?

Bangkok Bob

[calguy1000]

I'll add that to 2.0.2, I have fixed a few bugs and will be adding it to the wiki here later today.

[calguy1000]

I've uploaded the new version to the wiki.... I just stuck those changes in my 2.0.1 changes.

Have fun with it,let me know how it goes.

[badhoy]

Very nice module.  I need new window item like Bangkok Bob so installed the 2.0.1 release.  I did encounter the following error with the 2.0.1 upload when trying to add a banner. 

Fatal error: Call to undefined function: isseet() in /home/kmnews/public_html/modules/Banners/Banners.module.php on line 265

[calguy1000]

it's an obvious syntax error, just go in and change it to isset(...) and I'll fix it in the next version.

[badhoy]

I did fix, just wanted to let you know for the next version.

[badhoy]

I'd like to suggest a couple of additional changes to the banner module.

It would be nice to be able to be able to:

• center/left/right the add on a page
• remove the border around the ad

[calguy1000]

I center/left/right align a banner by wrapping the {cms_module module=Banners} in the appropriate tags. also with 2.0.1 you can specify your own text to go into the href or the image tag so you should be able to do this all you want.

I am working on having (optional) tighter integration with the uploads module now.

[calguy1000]

I've uploaded 2.0.2 which has integration with the uploads module (v1.0.6) for easier selection of files, if anybody has any questions, just give me a shout.

[Bangkok Bob]

Hi calguy,

Yes, I like the new version 2.0.2  'cos it now has alt text feature. I added border=0 myself to clear the border around the banner (line 1644). As a feature request, I would like the option to open links in a new window (target=_blank), and possibly also to have an option for third party hosted banners, so img src is not local via upload but href to affiliate program banner url.

Nice script, especiially the facilty to have multiple groups (for different banner sizes on the same page, etc).

Bangkok Bob

[Woudloper]

[...] I added border=0 myself to clear the border around the banner (line 1644). [...]

Why would you like to add this in the HTML? This can easily be done in the  stylesheet file with the following line:

Code: Select all

img {
	border			: 0;
	display			: block;
}

I thought, but then I need to look into the specification that the border="0" attribute of the IMG elemement is depreciated for XHTML...

[Bangkok Bob]

Hi Woudloper,

You are absolutely right, the border should be styled in CSS as you point out.

Also, my request for target=_blank is not valid XHTML, I understand it should be 'a rel="external" href' with JS to open the new window.

Bangkok Bob

[calguy1000]

The TARGET=_something can be placed in the "Link Text" field in the banners module.  this text gets added to the > tag

[calguy1000]

I thought of this too, but couldn't figure out a way where I could track hits with a third party banner. 

Hi calguy,

Yes, I like the new version 2.0.2 'cos it now has alt text feature. I added border=0 myself to clear the border around the banner (line 1644). As a feature request, I would like the option to open links in a new window (target=_blank), and possibly also to have an option for third party hosted banners, so img src is not local via upload but href to affiliate program banner url.

Nice script, especiially the facilty to have multiple groups (for different banner sizes on the same page, etc).

Bangkok Bob