Minor patches

Talk about writing modules and plugins for CMS Made Simple, or about specific core functionality. This board is for PHP programmers that are contributing to CMSMS not for site developers
Post Reply
Christophe Lambrechts

Minor patches

Post by Christophe Lambrechts »

Hi,

I have just upgraded my site to 1.2.1. Great work again! Just two patches that I did to make my site XHTML 1.1 valid.

In the search module I needed to modify the template to:

Code: Select all

{$startform}

<div>{$label}{$inputbox}<input name="submit" value="{$submittext}" type="submit" /></div>
{if isset($hidden)}{$hidden}{/if}

{$endform}
And in the index.php file a changed I added the following to set the right Mime-type in the header:

Code: Select all

// Set default content type to xhtml if accepted
if(strpos($_SERVER['HTTP_ACCEPT'], 'application/xhtml+xml') > 0 ||
   $_SERVER['HTTP_ACCEPT'] == '')
   $gCms->variables['content-type'] = 'application/xhtml+xml';
Finaly I have a strange problem in the Tags page of the admin panel. Everything is displayed twice.
kendo451

Re: Minor patches

Post by kendo451 »

I have same issue with the Extensions > Tags page (each entry doubled).

Also, it would be advisable to make sure that all parts of the Search template are outputted within a tag that can by styled with CSS.

Presently the colon is outside of the tag so any styling applied to the word Search in the label doesn't apply to the :.  So the colon should be inside the label, or another tag should be wrapped around the colon so that it can by styled too.

Thanks,
Ken Griffith
RonnyK
Support Guru
Support Guru
Posts: 4962
Joined: Wed Oct 25, 2006 8:29 pm
Location: Raalte, the Netherlands

Re: Minor patches

Post by RonnyK »

kendo451,

the issue concerning the tags was mentioned in the topic in "General Help", with the name "Known issues/fixes for 1.2.1".  The solution was also posted there. As of this weekend is that topic no longer sticky there, as 1.2.2 was released, with the fix included.

Ronny
Post Reply

Return to “Developers Discussion”