Pages become inactive on save.

[Dave]

Hi Dave,
I want to inform you that (on my site) after applying patch suggested by calguy everything works fine.

Here my user permission settings: Add Pages, Remove Pages, Use Album
Regards
blast2007

Blast, I just created a new group with permissions:  Add Pages, Remove Pages, Use Album and I am still having the same problem.

I verified that the patched file was in the path lib/classes/contenttypes/Content.inc.php the file was last modified yesterday at 11:36. Is there anything more I need to do to apply the patch?

[alby]

I verified that the patched file was in the path lib/classes/contenttypes/Content.inc.php the file was last modified yesterday at 11:36. Is there anything more I need to do to apply the patch?

Try to download whole file, backup old file and overwrite

Alby

[RonnyK]

Or use the zip of the changeset, to download the full file.

http://trac.cmsmadesimple.org/cgi-bin/t ... p&new=4237

Ronny

[Dave]

Ronny, I used the zip the first time and now have applied as alby suggested. No Joy! Propblem still persists as explained above. The patch does not make a difference for me.

[blast2007]

OK, I can check what happened to my CMSMS after applying patch.

When you create (with a low permission user) a new page all works fine (the page is active and visible in menu)

When you open a page for editing, after clicking 'apply' or 'submit', the same page become inactive and could not be enabled again for 'edit' users.

Maybe needs another patch for edit section?

Regards
blast2007

CMS Made Simple 1.2  - PHP 5.1.6-1 - MySQL 5.0.24a - Apache 2.0.55-4 - GNU/linux (kernel 2.6.17-12)

[OliLite]

Ronny, I used the zip the first time and now have applied as alby suggested. No Joy! Propblem still persists as explained above. The patch does not make a difference for me.

Hey! I did update the content.inc.php and still have the same problem as Dave and blast2007...

When you create (with a low permission user) a new page all works fine (the page is active and visible in menu)

When you open a page for editing, after clicking 'apply' or 'submit', the same page become inactive and could not be enabled again for 'edit' users.

That's the problem.....

Thanks for help 

[blast2007]

We have to ask help again to calguy!

Hope he will solve this problem (I think so )

Thanks all developers for hard work already done.

Regards
blast2007

CMS Made Simple 1.2  - PHP 5.1.6-1 - MySQL 5.0.24a - Apache 2.0.55-4 - GNU/linux (kernel 2.6.17-12)

[blast2007]

We have to ask help again to calguy!

Thanks calguy, problem is solved for me.

Dave try this file. Copy file in  /lib/classes/contenttypes/Content.inc.php overwriting existing file.


Regards
blast2007

CMS Made Simple 1.2  - PHP 5.1.6-1 - MySQL 5.0.24a - Apache 2.0.55-4 - GNU/linux (kernel 2.6.17-12)

[Dave]

That did fix the saving issue. Thanks for your work CalGuy.

However, now these users have no option to make their pages inactive. We are a school and many teachers post content throughout the year and hide it until it needs to be shown. This is a feature that we have really liked about CMSMS.

Is this the correct default behavior, that a low level user dose not have the option to make their page inactive? If so, what level of permission must they have to be able to make pages inactive? In previous versions they were able to do tihs with the current permissions.

[Dave]

CalGuy , Blast and others,

I took the file posted by blast and changed line 241 as follows:


Current

Code: Select all

if( check_permission(get_userid(),'Modify Page Structure') || $adding ) {

My modification to allow the owner to make the page inactive or hide it from the menu:

Code: Select all

if( check_permission(get_userid(),'Modify Page Structure') || $adding || $this->Owner() == get_userid() ) {

Please consider adding this to the core.

[blast2007]

Thanks all for these useful hints!

Regards
blast2007

CMS Made Simple 1.2  - PHP 5.1.6-1 - MySQL 5.0.24a - Apache 2.0.55-4 - GNU/linux (kernel 2.6.17-12)