Album inserts style code on generated page

[girlnerd]

Hi Folks,

I really hope you can help me with this.

I'm running the following:
CMSMS 1.0.2
Linux
Apache 1.3.37
PHP 5.2.0
MySQL 4.1.21-standard
Album 0.8.2
umask 002

I've used Album to upload two images. Then added comments for both. The second line of the first comment is a link back to the source of the picture.

I've changed the stylesheet so that width is 72 px and height is given free reign - to prevent distortion/stretch.

The problem comes when viewing the generated page. The image, and only one shows even though there are two images, appears with the comment and part of the style sheet showing.



Revealing the source shows:

Code: Select all

<ul class="albumlist">
		<li class="thumb">
 	<a href="http://www.gonewz.com/index.php?mact=Album,cntnt01,default,0&cntnt01albumid=1&cntnt01returnid=97">
<img src="http://www.gonewz.com/uploads/images/thumb_BandKominasbig.gif" alt="album1" title="album1 - Punjabi Band Kominas<br />
Source: <a href="http://www.indianewengland.com/">India New England</a>" height="59" /></a>

<p class="albumname">album1<br />
<span class="albumpicturecount">(2 images)</span><br />
<span class="albumcomment">Punjabi Band Kominas<br />
Source: <a href="http://www.indianewengland.com/">India New England</a></span></p>
</li>
	</ul>

What am I doing wrong and how can I fix it?

Thanks in advance

[gelöscht durch Administrator]

[Rob_H]

I'm not providing a solution, just supporting what you've found because I too have experienced thiis, so, if anyone's got a solution do let us know...

Thanks

Rob

[heatherfeuer]

I'm no expert by any means  , but when something like that happens to me, it's usually because I forgot a " or a .  I couldn't tell easily because of the length of the generated code, but you might go back to the template and triple check that you've closed every " and .

Just a suggestion...

[Rob_H]

Yes, done this (BTW sorry to hijack this post but we're on common ground!) and checked and checked again!! Ah well...

[girlnerd]

I too have checked closing tags in my comments. Never touched the templates. Just modified the stylesheet as referenced at top of thread.

Keep tossing those ideas out there and I'll keep trying.

Thanks so much.

[Elijah Lofgren]

Ah, so you are including a link in the Album comment. I think I should fix Album to make that work.
(Shouldn't be hard, but I'm really tired right now and don't have time at the moment.)


I'll file a bug and hopefully get to it someday: http://dev.cmsmadesimple.org/tracker/in ... 7&atid=725

Please comment on the bug to remind me if I forget.

Workaround: Remove link from Album comment.


Thanks for letting me know about this problem,

Elijah

[Rob_H]

That's what I love about CMS MS; the active development, improvement and endless enthusiasm. Thank's Elijah for taking time to look into this, we really appriciate it! We look forward to recieving your comments.

Regards

Rob

[heatherfeuer]

Oh gee, Elijah... Let's see... you're going to University and how many parts of CMSMS are you actively working on?  Tell me, dear boy, when was the last time you were on a date???? 

[Elijah Lofgren]

That's what I love about CMS MS; the active development, improvement and endless enthusiasm. Thank's Elijah for taking time to look into this, we really appriciate it! We look forward to recieving your comments.

Regards

Rob

Fixed: http://viewsvn.cmsmadesimple.org/viewsv ... m&view=rev
Simple change: http://viewsvn.cmsmadesimple.org/viewsv ... efault.tpl

Sorry it took me so long to reply.

To fix your template, just edit the "default" template on the "Database Templates" tab and replace this line:

Code: Select all

 <img src="{$album->thumbnail}" alt="{$album->name}" title="{$album->name} - {$album->comment}"{$album->autothumbnailsize} /></a>

with this:

Code: Select all

 <img src="{$album->thumbnail}" alt="{$album->name}" title="{$album->name}"{$album->autothumbnailsize} /></a>

Oh gee, Elijah... Let's see... you're going to University and how many parts of CMSMS are you actively working on?

While I've been at LeTu, I've mainly just done a little work on Album since I'm quite busy. During Christmas break I worked on a lot of different things which was very fun.

Tell me, dear boy, when was the last time you were on a date???? 

Umm... Never. 

Hope this helps (let me know if you still have problems with Album).

Have a good day all,

Elijah