• twitter image
  • facebook image
  • youtube image
  • linkedin image
Language: CMS Made Simple Czech CMS Made Simple France CMS Made Simple Spain CMS Made Simple Hungary CMS Made Simple Russia CMS Made Simple Netherlands

All times are UTC


Forum rules


Only administrators can post or move items here.



Post new topic Reply to topic  [ 16 posts ]  Go to page 1, 2  Next
Author Message
 Post subject: [closed]Installer:single quote will break JavaScript in Fr
PostPosted: Thu Jul 03, 2014 7:49 am 
Offline
Power Poster
Power Poster

Joined: Mon May 29, 2006 1:20 pm
Posts: 1947
Location: Rouen
Hi,

if a lang string have single quote
(ex : ... au panneau d\'administration ...
the message is not displayed
if the lang string is : au panneau administration
the message is displayed

so the lang string are used into the files :
in app/wizard/class.wizard_step9.php
- all the string $lang['finished_

in app\wizard/class.wizard_step7.php
- $lang['install_extractfiles'] --> OK in SVN 116

in app/templates/index.tpl
- $lang['confirm_freshen']
- $lang['confirm_upgrade']

_________________
Jean-Claude Etiemble


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sun Jul 20, 2014 10:23 am 
Offline
Power Poster
Power Poster

Joined: Mon May 29, 2006 1:20 pm
Posts: 1947
Location: Rouen
In last SVN 114
same problem with "send_admin_email" OK in SVN 116
line 96 \app\wizard\class.wizard_step9.php

If the lang file is
$lang['send_admin_email'] = 'Envoyer les informations d\'identification par email pour la connexion d\'administration';
the message is not displayed on step9

If the string is
$lang['send_admin_email'] = 'Envoyer les identifiants par email pour la connexion Admin';
the message is displayed on step9

_________________
Jean-Claude Etiemble


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sun Jul 20, 2014 6:56 pm 
Offline
Dev Team Member
Dev Team Member
User avatar

Joined: Tue Oct 19, 2004 6:44 pm
Posts: 8170
Location: Fernie British Columbia, Canada
should be fixed now.

_________________
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sun Jul 20, 2014 7:29 pm 
Offline
Power Poster
Power Poster

Joined: Mon May 29, 2006 1:20 pm
Posts: 1947
Location: Rouen
\$1:
should be fixed now.


Rev 116 Not OK for
in app/templates/index.tpl
- $lang['confirm_freshen']
- $lang['confirm_upgrade']

EDIT
Not OK for
in app/wizard/class.wizard_step9.php
- all the string $lang['finished_

OK for
in app\wizard/class.wizard_step7.php
- $lang['install_extractfiles']

_________________
Jean-Claude Etiemble


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sun Jul 20, 2014 8:01 pm 
Offline
Power Poster
Power Poster

Joined: Mon May 29, 2006 1:20 pm
Posts: 1947
Location: Rouen
Rev 116 OK for this string
line 96 \app\wizard\class.wizard_step9.php
$lang['send_admin_email'] = 'Envoyer les informations d\'identification par email pour la connexion d\'administration';

_________________
Jean-Claude Etiemble


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Thu Jul 24, 2014 7:45 pm 
Offline
Power Poster
Power Poster

Joined: Mon May 29, 2006 1:20 pm
Posts: 1947
Location: Rouen
to temporarily correct the problem

- $lang['confirm_freshen']
- $lang['confirm_upgrade']
and all the string $lang['finished_

are translated into French by replacing the ' (apostrophe) with the ' (right single quote)

_________________
Jean-Claude Etiemble


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sat Jul 26, 2014 2:54 pm 
Offline
Dev Team Member
Dev Team Member
User avatar

Joined: Tue Oct 19, 2004 6:44 pm
Posts: 8170
Location: Fernie British Columbia, Canada
With the latest snapshot built phar-installer I could not reproduce this problem.

I used the .phar file in 'freshen' mode, in French, on an existing 2.0-beta2 install, and watching the javascript console for errors. The confirmation messages appeared just fine and no javascript errors were encountered.

_________________
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sat Jul 26, 2014 4:22 pm 
Offline
Power Poster
Power Poster

Joined: Mon May 29, 2006 1:20 pm
Posts: 1947
Location: Rouen
\$1:
With the latest snapshot built phar-installer I could not reproduce this problem.


as you see on the post above

\$1:
to temporarily correct the problem
- $lang['confirm_freshen']
- $lang['confirm_upgrade']
and all the string $lang['finished_
are translated into French by replacing the ' (apostrophe) with the ' (right single quote)


so to test You need to replace the ' (right single quote) by ' (apostrophe)
and you won't have any messages
- $lang['confirm_freshen']
- $lang['finished_

_________________
Jean-Claude Etiemble


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sat Jul 26, 2014 5:11 pm 
Offline
Dev Team Member
Dev Team Member
User avatar

Joined: Tue Oct 19, 2004 6:44 pm
Posts: 8170
Location: Fernie British Columbia, Canada
fixed in svn, thanks.

_________________
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sat Jul 26, 2014 5:44 pm 
Offline
Power Poster
Power Poster

Joined: Mon May 29, 2006 1:20 pm
Posts: 1947
Location: Rouen
sorry not, the French language is not easy ;)

test with Rev 122
with $lang['confirm_freshen']='Êtes-vous sûr(e) de vouloir rafraîchir l\'installation existante de CMSMS ?'; // ' (apostrophe)
freshen : '{'confirm_freshen'|tr|escape}' shows
Êtes-vous sûr(e) de vouloir rafraîchir l'installation existante de CMSMS ?
so not correct it would be
Êtes-vous sûr(e) de vouloir rafraîchir l'installation

and the $lang['finished_ are not displayed besause the problem is on the set_block_html('bottom_nav'

_________________
Jean-Claude Etiemble


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sat Jul 26, 2014 6:48 pm 
Offline
Dev Team Member
Dev Team Member
User avatar

Joined: Tue Oct 19, 2004 6:44 pm
Posts: 8170
Location: Fernie British Columbia, Canada
should now be fixed... I call addslashes instead of escape.

_________________
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sat Jul 26, 2014 7:17 pm 
Offline
Power Poster
Power Poster

Joined: Mon May 29, 2006 1:20 pm
Posts: 1947
Location: Rouen
1/2 solved in rev 125

Ok the the $lang['confirm_freshen']
tha'ts fine

But not for the set_block_html
the $lang['finished_ are not displayed
so the the JavaScript break the output.

The ' (right single quote) into our translation works and
I suggests to leave out this problem at the moment.
Try later afert the beta2.

_________________
Jean-Claude Etiemble


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sat Sep 06, 2014 6:01 pm 
Offline
Dev Team Member
Dev Team Member
User avatar

Joined: Wed Apr 23, 2008 7:53 am
Posts: 7707
Location: The Netherlands
is this fixed in 2.0, JC?

_________________
$1

Did my post help you solving a problem at your (customers) website and it saved you many hours of work? Great!! Consider buying me a cup of coffee in return!



Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Sun Sep 07, 2014 1:05 pm 
Offline
Power Poster
Power Poster

Joined: Mon May 29, 2006 1:20 pm
Posts: 1947
Location: Rouen
\$1:
is this fixed in 2.0, JC?

not at this moment, the $lang['finished_.. are not displayed is we use ' (apostrophe)
ON TC now the strings are translated with with the ' (right single quote)
if no translator has problem with these strings, it is possible to consider the problem solved for now temporarily

_________________
Jean-Claude Etiemble


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open]Installer:single quote will break JavaScript in Fr
PostPosted: Tue Jan 13, 2015 12:31 pm 
Offline
Dev Team Member
Dev Team Member
User avatar

Joined: Wed Apr 23, 2008 7:53 am
Posts: 7707
Location: The Netherlands
Could you please re-test this issue in the Beta 3 release?

Thanks, Rolf

_________________
$1

Did my post help you solving a problem at your (customers) website and it saved you many hours of work? Great!! Consider buying me a cup of coffee in return!



Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 16 posts ]  Go to page 1, 2  Next

All times are UTC


Who is online

Users browsing this forum: No registered users


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
A2 Hosting