AjaxMadeSimple Module is not properly cleaning input params

Have a question or a suggestion about a 3rd party addon module or plugin?
Let us know here.
Post Reply
stetman
Forum Members
Forum Members
Posts: 20
Joined: Fri Feb 12, 2010 9:39 am

AjaxMadeSimple Module is not properly cleaning input params

Post by stetman »

I am using cmsms 1.10 and just installed the polls module, everything seems to work fine.
Only thing is that my admin log has 100's of pages full with:
AjaxMadeSimple Module is not properly cleaning input params

Does anybody know what's happening ?

Marc
staartmees
Power Poster
Power Poster
Posts: 1049
Joined: Wed Mar 19, 2008 4:54 pm

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by staartmees »

This project is marked as stale. This means that it may work fine, but it has no file releases or repository commits in over a year. Use your own discretion when using this project.
It's obvious this module is no longer supported and it isn't compatible with cmsms 1.10.x
oliver341
Forum Members
Forum Members
Posts: 89
Joined: Sat Feb 23, 2008 3:51 pm

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by oliver341 »

I have the same problem, with "Module is not properly cleaning input params" appearing in the admin log every time a page is loaded on the site, AjaxMadeSimple is being blamed (I use it for the Polls module).

Module was updated on 2012-02-13 so it seems it isn't stale.

CMSMS version: 1.10.3
AjaxMadeSimple version: 0.3.3
User avatar
Jo Morg
Dev Team Member
Dev Team Member
Posts: 1976
Joined: Mon Jan 29, 2007 4:47 pm

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by Jo Morg »

AFAIK it is more of a warning than an error, although, IIRC, that may change in CMSMS 1.11 and became an error. I think it doesn't hurt to file a bug report, if there isn't one already, on the forge.
"There are 10 types of people in this world, those who understand binary... and those who don't."
* by the way: English is NOT my native language (sorry for any mistakes...).
Code of Condut | CMSMS Docs | Help Support CMSMS
My developer Page on the Forge
GeekMoot 2015 in Ghent, Belgium: I was there!
GeekMoot 2016 in Leicester, UK: I was there!
DevMoot 2023 in Cynwyd, Wales: I was there!
oliver341
Forum Members
Forum Members
Posts: 89
Joined: Sat Feb 23, 2008 3:51 pm

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by oliver341 »

There already seems to be an open bug about this on the forge.

http://dev.cmsmadesimple.org/bug/view/6699

It has been open for about 9 months.
User avatar
Jo Morg
Dev Team Member
Dev Team Member
Posts: 1976
Joined: Mon Jan 29, 2007 4:47 pm

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by Jo Morg »

Yeah! It's not a problem as it does not interfere in the module normal functions, at least as far as CMSMS 1.10.X (at least as far as I recall). It may become a problem with CMSMS 1.11 if the module is not updated until then.
Unless someone more knowledgeable than me corrects me... ;D
"There are 10 types of people in this world, those who understand binary... and those who don't."
* by the way: English is NOT my native language (sorry for any mistakes...).
Code of Condut | CMSMS Docs | Help Support CMSMS
My developer Page on the Forge
GeekMoot 2015 in Ghent, Belgium: I was there!
GeekMoot 2016 in Leicester, UK: I was there!
DevMoot 2023 in Cynwyd, Wales: I was there!
oliver341
Forum Members
Forum Members
Posts: 89
Joined: Sat Feb 23, 2008 3:51 pm

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by oliver341 »

Jo Morg wrote:It's not a problem as it does not interfere in the module normal functions
It is a problem in that the Admin Log is flooded with messages to the point of becoming useless.
vilkis

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by vilkis »

Really, it floods Admin log. It should be onetime message but not repetitive. It is issue of CMSMS and not the module. For the moment I hacked CMSMS core file to disable these messages.

vilkis
oliver341
Forum Members
Forum Members
Posts: 89
Joined: Sat Feb 23, 2008 3:51 pm

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by oliver341 »

Yeah, a one-time message might be good, or something like "the last message was repeated 355 times" like syslog does, maybe.

But ultimately something inside the module needs fixing.
Attachments
admin.png
vilkis

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by vilkis »

This problem is the same as in http://dev.cmsmadesimple.org/bug/view/7016
The solution could be to make this message not repetitive in CMSMS core.
vilkis
oliver341
Forum Members
Forum Members
Posts: 89
Joined: Sat Feb 23, 2008 3:51 pm

Re: AjaxMadeSimple Module is not properly cleaning input pa

Post by oliver341 »

If it's simple I'll just insert one or two lines of code into the code of AjaxMadeSimple. Does anyone know how you "clean input params"?
Post Reply

Return to “Modules/Add-Ons”