Inline stylesheet tags are no longer working

A place to discuss the testing process in beta cycles or against SVN for the CMS Made Simple CORE package.
Locked
skywalker404

Inline stylesheet tags are no longer working

Post by skywalker404 »

I upgraded a site I'm developing from 0.10 to 0.12.1, and suddenly every inline stylesheet request I make is no longer returning any data. For example, I have {stylesheet name="contactForm"}, and it correctly translates that into the stylesheet HTML code. However, the page that code requests, /stylesheet.php?name=contactForm for example, does not return any data!

From what I can tell, this is because the query /stylesheet.php uses is being generated wrong. It looks like the "?" on line 44, is not being replaced. I say this, because the ADODB object is providing the following error text:

SELECT css_text FROM css WHERE css_name = ? - Error (1064): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?' at line 1

Seemed to me like a bug worth reporting, and any help to fix my local copy would be appreciated.
hansom

Re: Inline stylesheet tags are no longer working

Post by hansom »

I'm completely new to CMSMS but this was one of the first things I noticed. There is indeed a bug, line 45 in stylesheet.php should be
$cssresult = &$db->Execute($cssquery, array($name));
instead of
$cssresult = &$db->Execute($cssquery, $name);
Like I mentioned I'm new here, should this bug be reported somewhere?
skywalker404

Re: Inline stylesheet tags are no longer working

Post by skywalker404 »

And on a further note, RSS doesn't seem to be working on this site (cmsmadesimple.org). It asks me to save the file, with what looks like the wrong MIME type.

My Firefox install can't read it as a feed for the Live Bookmarks.
calguy1000
Support Guru
Support Guru
Posts: 8169
Joined: Tue Oct 19, 2004 6:44 pm

Re: Inline stylesheet tags are no longer working

Post by calguy1000 »

Yes, you can go to the forge, register another user account, and put it on the tracker for the cmsms core.

Here's the link to the tracker:
http://dev.cmsmadesimple.org/tracker/?group_id=6
hansom wrote: I'm completely new to CMSMS but this was one of the first things I noticed. There is indeed a bug, line 45 in stylesheet.php should be
$cssresult = &$db->Execute($cssquery, array($name));
instead of
$cssresult = &$db->Execute($cssquery, $name);
Like I mentioned I'm new here, should this bug be reported somewhere?
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
hansom

Re: Inline stylesheet tags are no longer working

Post by hansom »

calguy1000 wrote: Yes, you can go to the forge, register another user account, and put it on the tracker for the cmsms core.
Done: https://dev.cmsmadesimple.org/tracker/i ... 6&atid=101
Locked

Return to “[locked] Quality Assurance”