Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Talk about writing modules and plugins for CMS Made Simple, or about specific core functionality. This board is for PHP programmers that are contributing to CMSMS not for site developers
Post Reply
atz6975
Forum Members
Forum Members
Posts: 34
Joined: Thu Jan 14, 2010 4:43 pm

Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Post by atz6975 »

Hi,
I'm not sure how this should be done and sorry if I offend anybody.

This is an updated listhtmlblobs.php to fix http://dev.cmsmadesimple.org/bug/view/5058
Basicaly admin doesn't filter the total amount of content with the user rights.

here is the annoted code (I'm PHP noob so sorry for possible uglyness), look for //FIX 5058 and //FIX END



Please follow forum rules... there is a policy against posting code changes in this forum.  Also there have been guidelines posted as to how to properly submit your suggested changes, and bloating the forum with them is not it.
Last edited by calguy1000 on Wed Sep 15, 2010 1:18 pm, edited 1 time in total.
atz6975
Forum Members
Forum Members
Posts: 34
Joined: Thu Jan 14, 2010 4:43 pm

Re: Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Post by atz6975 »

I new I should have read more....rules!

Sorry again...
... and I included a little bug so I guess : point made !  ::)
I was about to fix the fix

Is it me or there is no 1) 2) 3) about contributing code/fixes?
I managed to get the svn but I'm no dev so I'm not sure how to commit...?

As for the fix of the fix : how do I send it ?

Thanks.
calguy1000
Support Guru
Support Guru
Posts: 8169
Joined: Tue Oct 19, 2004 6:44 pm
Location: Fernie British Columbia, Canada

Re: Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Post by calguy1000 »

if you do a search for 'submit patches'.  it finds the guide (a little outdated, but not much) very quickly.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
atz6975
Forum Members
Forum Members
Posts: 34
Joined: Thu Jan 14, 2010 4:43 pm

Re: Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Post by atz6975 »

Hi,
I found it indeed. Thank you.
EDIT : How do I forward a diff to you guys? Bug Tracker if I read well.
Please advise if otherwise.
Last edited by atz6975 on Wed Sep 15, 2010 4:01 pm, edited 1 time in total.
atz6975
Forum Members
Forum Members
Posts: 34
Joined: Thu Jan 14, 2010 4:43 pm

Re: Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Post by atz6975 »

I hope I didn't make something stupid....
So I cut and pasted the patch, inside the Bug Tracker comment.
Please forgive any noobness here as I'm not too familiar with this.
I followed (luckily) tags 6537 > version 1.8.2 as check-out point

I looked at your 2.0 code, same problem and fix could apply.
I wonder if not more elegant to have a filtered "htmlbloblist" before displaying it to avoid multiple checks...

Man, I hope I did it right this time...
Post Reply

Return to “Developers Discussion”