error with database backup module(svn)

[jelle]

Hi,

Ted pointed me to the new database backup module, the previous one was broken on .12. Unfortunately it makes some asumptions that are wrong on my system:

Code: Select all

Warning: Cannot modify header information - headers already sent by (output started at /home/test.plop/public_html/modules/Backup/Backup.module.php:367) in /home/test.plop/public_html/lib/classes/class.admintheme.inc.php on line 161
 
 Warning: Cannot modify header information - headers already sent by (output started at /home/test.plop/public_html/modules/Backup/Backup.module.php:367) in /home/test.plop/public_html/lib/classes/class.admintheme.inc.php on line 164
 
 Warning: Cannot modify header information - headers already sent by (output started at /home/test.plop/public_html/modules/Backup/Backup.module.php:367) in /home/test.plop/public_html/lib/classes/class.admintheme.inc.php on line 167
 
 Warning: Cannot modify header information - headers already sent by (output started at /home/test.plop/public_html/modules/Backup/Backup.module.php:367) in /home/test.plop/public_html/lib/classes/class.admintheme.inc.php on line 168
 
 Warning: Cannot modify header information - headers already sent by (output started at /home/test.plop/public_html/modules/Backup/Backup.module.php:367) in /home/test.plop/public_html/lib/classes/class.admintheme.inc.php on line 171
 
 Warning: Cannot modify header information - headers already sent by (output started at /home/test.plop/public_html/modules/Backup/Backup.module.php:367) in /home/test.plop/public_html/lib/classes/class.admintheme.inc.php on line 176
        
CMS Made Simple Admin Panel
Main
 
Content
 
Layout
 
Users & Groups
 
Extensions
 
Site Admin
 
My Prefs
 
View Site
 
Logout
 
 
 


 
 
Database Backup

 Warning: mkdir(backups): Permission denied in /home/test.plop/public_html/modules/Backup/Backup.module.php on line 237
 
 Warning: fopen(backups/backup-2006-03-16_14-56-41.txt): failed to open stream: No such file or directory in /home/test.plop/public_html/modules/Backup/Backup.module.php on line 248
 backing up database ... 
 
cms_additional_htmlblob_users

 Warning: fwrite(): supplied argument is not a valid stream resource in /home/test.plop/public_html/modules/Backup/Backup.module.php on line 258
 
 Warning: fwrite(): supplied argument is not a valid stream resource in /home/test.plop/public_html/modules/Backup/Backup.module.php on line 266
 
 Warning: fwrite(): supplied argument is not a valid stream resource in /home/test.plop/public_html/modules/Backup/Backup.module.php on line 283
 
 Warning: fwrite(): supplied argument is not a valid stream resource in

Since it like to serve multiple (sub)domains from one tree, this does not work well with storing the backupfile in /admin. I'd prefer mine in $_request['HTTP_HOST'] or in TMP_LOCATION. (uploads and tmp live in $_request['HTTP_HOST'] too). Even if it were a normal (single-domain) install putting the data together with the code is not the best idea IMHO.

I'll see if I can change that tonight.