menu > separator doesn's show up

[MaKK0]

When I add a menu separator via "pages" it doesn't show up in the menu. I think it is since I updated my CMS installation. Older separators are still working. Someone can help me out here?

Code menu manager

{if $count > 0}

{foreach from=$nodelist item=node}

{if $node->type == 'separator'}
alias}"> 

{else}
alias}">url}">{$node->menutext} 

{/if}
{/foreach}
{/if}

----------------------------------------------

Cms Version: 1.6.3

Installed Modules:

    * CMSMailer: 1.73.14
    * MenuManager: 1.6.1
    * ModuleManager: 1.3.1
    * News: 2.10.2
    * nuSOAP: 1.0.1
    * Search: 1.6.1
    * ThemeManager: 1.1.1
    * TinyMCE: 2.5.1
    * RSS: 1.1
    * FileManager: 1.0
    * Printing: 1.0.1
    * TruetypeText: 2.0.2
    * FormBuilder: 0.5.11
    * Captcha: 0.4
    * CGExtensions: 1.16.2
    * CGFeedMaker: 1.0.6


Config Information:

    * php_memory_limit:
    * process_whole_template: true
    * max_upload_size: 2000000
    * default_upload_permission: 664
    * assume_mod_rewrite: true
    * page_extension: /
    * internal_pretty_urls: false
    * use_hierarchy: true


Php Information:

    * phpversion: 5.2.4-2ubuntu5.6
    * md5_function: On (True)
    * gd_version: 2
    * tempnam_function: On (True)
    * magic_quotes_runtime: Off (False)
    * memory_limit: 32M
    * max_execution_time: 30
    * safe_mode: Off (False)
    * session_save_path: /var/lib/php5 (1733)


Server Information:

    * Server Api: apache2handler
    * Server Db Type: MySQL (mysql)
    * Server Db Version: 5.0.38


----------------------------------------------

[Dr.CSS]

Sounds like a CSS problem, w/o a link no help...

[MaKK0]

Ah! Thanks for being so on point

The URL is http://vruchtvlees.com/nl/

Actually, I don't think it is a CSS problem because if I place a separator between "shop faq" and "lookbook" it won't show up in the code:

Code: Select all

<li class="menu_faq"><a href="http://www.vruchtvlees.com/nl/faq/">SHOP FAQ</a> </li>
***here should be an empty <li>***
<li class="menu_lookbook"><a href="http://www.vruchtvlees.com/nl/lookbook/">LOOKBOOK</a> </li>

[MaKK0]

*bumb*

Still cant figure it out why it's not working... a beer for who give me the solution

[Dr.CSS]

I looked at the source and see them...

SHOP FAQ 


LOOKBOOK 


 


FAMILY/FRIENDS 

You may want to look at validation issues...

http://validator.w3.org/check?verbose=1 ... om%2Fnl%2F
Result: 88 Errors, 65 warning(s)


This is from html validator addon in Firefox...

Result: 0 errors / 144 warnings
line 309 column 1 - Warning: missing
line 353 column 14 - Warning: missing before
line 353 column 104 - Warning: inserting implicit
line 353 column 104 - Warning: missing before
line 353 column 211 - Warning: discarding unexpected
line 372 column 14 - Warning: missing before
line 372 column 108 - Warning: inserting implicit
line 372 column 108 - Warning: missing before
line 372 column 223 - Warning: discarding unexpected
line 376 column 4 - Warning: inserting implicit
line 392 column 14 - Warning: missing before
line 392 column 117 - Warning: inserting implicit
line 392 column 117 - Warning: missing before
line 392 column 250 - Warning: discarding unexpected
line 396 column 4 - Warning: inserting implicit
line 412 column 14 - Warning: missing before
line 412 column 121 - Warning: inserting implicit
line 412 column 121 - Warning: missing before
line 412 column 264 - Warning: discarding unexpected
line 418 column 4 - Warning: inserting implicit
line 434 column 14 - Warning: missing before
line 434 column 101 - Warning: inserting implicit
line 434 column 101 - Warning: missing before
line 434 column 202 - Warning: discarding unexpected
line 438 column 4 - Warning: inserting implicit
line 454 column 14 - Warning: missing before
line 454 column 138 - Warning: inserting implicit
line 454 column 138 - Warning: missing before
line 454 column 313 - Warning: discarding unexpected
line 458 column 4 - Warning: inserting implicit
line 474 column 14 - Warning: missing before
line 474 column 100 - Warning: inserting implicit
line 474 column 100 - Warning: missing before
line 474 column 199 - Warning: discarding unexpected
line 479 column 4 - Warning: inserting implicit
line 495 column 14 - Warning: missing before
line 495 column 106 - Warning: inserting implicit
line 495 column 106 - Warning: missing before
line 495 column 217 - Warning: discarding unexpected
line 499 column 4 - Warning: inserting implicit
line 515 column 14 - Warning: missing before
line 515 column 101 - Warning: inserting implicit
line 515 column 101 - Warning: missing before
line 515 column 202 - Warning: discarding unexpected
line 534 column 14 - Warning: missing before
line 534 column 114 - Warning: inserting implicit
line 534 column 114 - Warning: missing before
line 534 column 241 - Warning: discarding unexpected
line 539 column 4 - Warning: inserting implicit
line 555 column 14 - Warning: missing before
line 555 column 108 - Warning: inserting implicit
line 555 column 108 - Warning: missing before
line 555 column 223 - Warning: discarding unexpected
line 559 column 4 - Warning: inserting implicit
line 575 column 14 - Warning: missing before
line 575 column 99 - Warning: inserting implicit
line 575 column 99 - Warning: missing before
line 575 column 200 - Warning: discarding unexpected
line 580 column 4 - Warning: inserting implicit
line 596 column 14 - Warning: missing before
line 596 column 105 - Warning: inserting implicit
line 596 column 105 - Warning: missing before
line 596 column 214 - Warning: discarding unexpected
line 615 column 14 - Warning: missing before
line 615 column 104 - Warning: inserting implicit
line 615 column 104 - Warning: missing before
line 615 column 211 - Warning: discarding unexpected
line 620 column 4 - Warning: inserting implicit
line 636 column 14 - Warning: missing before
line 636 column 110 - Warning: inserting implicit
line 636 column 110 - Warning: missing before
line 636 column 231 - Warning: discarding unexpected
line 655 column 14 - Warning: missing before
line 655 column 105 - Warning: inserting implicit
line 655 column 105 - Warning: missing before
line 655 column 214 - Warning: discarding unexpected
line 660 column 4 - Warning: inserting implicit
line 676 column 14 - Warning: missing before
line 676 column 110 - Warning: inserting implicit
line 676 column 110 - Warning: missing before
line 676 column 229 - Warning: discarding unexpected
line 695 column 14 - Warning: missing before
line 695 column 113 - Warning: inserting implicit
line 695 column 113 - Warning: missing before
line 695 column 238 - Warning: discarding unexpected
line 714 column 14 - Warning: missing before
line 714 column 111 - Warning: inserting implicit
line 714 column 111 - Warning: missing before
line 714 column 234 - Warning: discarding unexpected
line 733 column 14 - Warning: missing before
line 733 column 112 - Warning: inserting implicit
line 733 column 112 - Warning: missing before
line 733 column 235 - Warning: discarding unexpected
line 289 column 57 - Warning: lacks "alt" attribute
line 310 column 57 - Warning: lacks "alt" attribute
line 312 column 55 - Warning: lacks "alt" attribute
line 315 column 1 - Warning: lacks "alt" attribute
line 335 column 4 - Warning: lacks "summary" attribute
line 350 column 4 - Warning: lacks "alt" attribute
line 369 column 4 - Warning: lacks "alt" attribute
line 389 column 4 - Warning: lacks "alt" attribute
line 409 column 4 - Warning: lacks "alt" attribute
line 431 column 4 - Warning: lacks "alt" attribute
line 437 column 100 - Warning: escaping malformed URI reference
line 451 column 4 - Warning: lacks "alt" attribute
line 471 column 4 - Warning: lacks "alt" attribute
line 492 column 4 - Warning: lacks "alt" attribute
line 512 column 4 - Warning: lacks "alt" attribute
line 531 column 4 - Warning: lacks "alt" attribute
line 552 column 4 - Warning: lacks "alt" attribute
line 572 column 4 - Warning: lacks "alt" attribute
line 593 column 4 - Warning: lacks "alt" attribute
line 612 column 4 - Warning: lacks "alt" attribute
line 633 column 4 - Warning: lacks "alt" attribute
line 652 column 4 - Warning: lacks "alt" attribute
line 673 column 4 - Warning: lacks "alt" attribute
line 692 column 4 - Warning: lacks "alt" attribute
line 711 column 4 - Warning: lacks "alt" attribute
line 730 column 4 - Warning: lacks "alt" attribute
line 373 column 4 - Warning: trimming empty
line 376 column 4 - Warning: trimming empty
line 393 column 4 - Warning: trimming empty
line 396 column 4 - Warning: trimming empty
line 413 column 4 - Warning: trimming empty
line 418 column 4 - Warning: trimming empty
line 435 column 4 - Warning: trimming empty
line 437 column 255 - Warning: trimming empty
line 438 column 4 - Warning: trimming empty
line 455 column 4 - Warning: trimming empty
line 458 column 4 - Warning: trimming empty
line 475 column 4 - Warning: trimming empty
line 479 column 4 - Warning: trimming empty
line 496 column 4 - Warning: trimming empty
line 499 column 4 - Warning: trimming empty
line 535 column 4 - Warning: trimming empty
line 539 column 4 - Warning: trimming empty
line 556 column 4 - Warning: trimming empty
line 559 column 4 - Warning: trimming empty
line 576 column 4 - Warning: trimming empty
line 580 column 4 - Warning: trimming empty
line 616 column 4 - Warning: trimming empty
line 620 column 4 - Warning: trimming empty
line 656 column 4 - Warning: trimming empty
line 660 column 4 - Warning: trimming empty
Info: Doctype given is "-//W3C//DTD HTML 4.01 Transitional//EN"
Info: Document content looks like HTML 4.01 Transitional
Info: No system identifier in emitted doctype

[Lew]

Hi ... I've run into the same problem.

I believe it was the change to the way that 'content' types were handled (v1.6.x?) that broke the separators.

The key place the filtering of page objects takes place is MenuManager.module.php  GetChildNodes function.  It checks, among other things if the page object is "active" and does processing of "IncludePrefix" and "ExcludePrefix" parameters.

However, when the content types were changed (guessing?) the processing of a "Separator" object has two issues:

- all separator objects are not marked 'active'
- separator objects have no 'alias' field, therefore cannot be included by the "IncludePrefix" processing

My temporary fix (seems to work so far...) is the following:

In /classes/contenttypes/Separator.inc.php -- which defines the "Separator" content class, it has the following function right at the top:

Code: Select all

    function SetProperties()
    {
      parent::SetProperties();
      $this->RemoveProperty('template','-1');
      $this->RemoveProperty('alias','');
      $this->RemoveProperty('title','');
      $this->RemoveProperty('menutext','');
      $this->RemoveProperty('target','');
      $this->RemoveProperty('accesskey','');
      $this->RemoveProperty('titleattribute','');
      $this->RemoveProperty('showinmenu',true);
      $this->RemoveProperty('cachable',true);
    }

as you can see, this removes both the 'alias' and 'showinmenu' fields from the admin page editor for "Separator" content pages.  So all I did was comment out those two lines, like so...

Code: Select all

    function SetProperties()
    {
      parent::SetProperties();
      $this->RemoveProperty('template','-1');
//      $this->RemoveProperty('alias','');
      $this->RemoveProperty('title','');
      $this->RemoveProperty('menutext','');
      $this->RemoveProperty('target','');
      $this->RemoveProperty('accesskey','');
      $this->RemoveProperty('titleattribute','');
//      $this->RemoveProperty('showinmenu',true);
      $this->RemoveProperty('cachable',true);
    }

and this made the "active" and "page-alias" fields reappear in the "Control" tab for the Separator page entry.  I checked the "active" field and entered an alias that would have it included by my "IncludePrefix" parameter, and voila -- the Separator menu items reappeared.

[Side note: the tag for the Separator menu wouldn't show up until I finally found that the default hr CSS was set by the default "Accessibility" tags, and set position:absolute etc...  when I finally set the menu CSS to explicitly set position:relative, then the finally appeared in the right place...   be warned!]

I'm under the gun on a deadline, so I don't have time to figure out if there's a better way to solve this problem -- feel free to explore it further.

Lew

[Dr.CSS]

@Lew

Please be advised if you hack core files we have a hard time giving any support...