[solved] function.cms_selflink.php implementation question

Talk about writing modules and plugins for CMS Made Simple, or about specific core functionality. This board is for PHP programmers that are contributing to CMSMS not for site developers
Post Reply
fredp
Forum Members
Forum Members
Posts: 218
Joined: Sun Jul 27, 2008 1:36 am
Location: USA

[solved] function.cms_selflink.php implementation question

Post by fredp »

Hi,

Being new to CMSMS, I've been looking through the 1.4 code to get familiar with it. In plugins/function.cms_selflink.php I noticed that line 49 looked "suspicious". Shouldn't it be getting the value of $params['ext_info'] instead of $ext_info or am I missing something? 

Code: Select all

   $external_text = '(external link)';
   if ( isset($params['ext_info']) ) {
      $external_text ='( '.$ext_info.' )';
   }
Thanks,
Fred
Last edited by fredp on Wed Aug 13, 2008 4:38 am, edited 1 time in total.
Nearly all men can stand adversity, but if you want to test a man's character, give him power.
- Abraham Lincoln
Pierre M.

Re: function.cms_selflink.php implementation question

Post by Pierre M. »

Hello,

if it is not fixed by 1.4.1, please post there : http://forum.cmsmadesimple.org/index.ph ... 562.0.html
or better : file a bug in the forge (where the DevTeam can track code issues).

Pierre M.
fredp
Forum Members
Forum Members
Posts: 218
Joined: Sun Jul 27, 2008 1:36 am
Location: USA

Re: function.cms_selflink.php implementation question

Post by fredp »

Thanks.  I filed a bug since it isn't fixed in 1.4.1.

Fred P.
Pierre M. wrote: if it is not fixed by 1.4.1... file a bug in the forge (where the DevTeam can track code issues).
Nearly all men can stand adversity, but if you want to test a man's character, give him power.
- Abraham Lincoln
alby

Re: function.cms_selflink.php implementation question

Post by alby »

fredp wrote: Thanks.  I filed a bug since it isn't fixed in 1.4.1.
Was fixed after 1.4.1 because the code was closed for released.
It's in SVN

Alby
Pierre M.

Re: [solved] function.cms_selflink.php implementation question

Post by Pierre M. »

What a responsive DevTeam : bugs are fixed before they are filed !-)
Post Reply

Return to “Developers Discussion”