Banners Module expiration date problem

[Glenn]

I have the banners module installed and it seems to work poperly except for one thing. When I managing banners in the "Manage Banenrs" admin area you can set an expiration date (month-date-year-hours-minutes-seconds). When I do that, either when creating a banner or updating one, the month-date-year never gets added/updated to the db. I set the date to June 10, 2007, 12:00:00 then check the cms_module_banners table with phphMyAdmin and see that the expires column just says 12:00:00 So it will serve the ad until noon today then stop. It will not run until June 10.

Help appreciated.

[RonnyK]

Glen,

I've the same issue on CMSMS 1.0.2 with Banners 2.1.0. When setting the expiration, the date isn't kept.

Ronny

[Dee]

Fixed in SVN.
The $db->DBTimeStamp() function returns a quoted string, which conflicted with the use of variable binding.
Apply the same changes, or download the latest versions of action.do_addbanner.php and action.do_editbanner.php to fix the issue.

Regards,
D

[Glenn]

Thanks Dee. I've downloaded both of these files and replaced the ones in the Modules/Banners directory, but still the same behavior. I'm using CMS Made Simple 1.0.4 "Lanai"

[Glenn]

When in doubt, reinstall. I reinstalled the entire module with this new code and it now works. Thanks!

[jtcreate]

I'm having the same issue on the latest version of CMSMS. I reinstalled, and now it shows the date, but doesn't 'expire'. I assumed it would trash the banner at that time... is that correct?

Thanks,
Jeff T.

[kilauea]

I'm running CMSMS version 1.2.3 and Banners 2.1.0
I downloaded the latest SVN versions of action.do_addbanner.php and action.do_editbanner.php which has allowed me to save an expiration date... cool
BUT...
Banners are continuing to display even after their expiration date,
Worse, updating those 2 files broke the banner editing -
After testing one banner to set it's expiration date, I tried to set it back to never expire and it produced a "database error", attempting to add a new banner produced a "Database error" as well
I've reinstalled the Banners module from the published xml file so I could regain basic control of adding/changing banners but now it's back to the problem of not being able to expire banners. I see it has date issue across the board - banner creation isn't recorded (shows all 0s) and banner click dates aren't recorded either.
Any ideas on how to proceed? Thank you,
Alane

[calguy1000]

I fixed the expiration date issue.

And btw, if you're mixing and matching various files from svn into the released version.... good luck with that.

[kilauea]

Oh a thousand thank yous Bruce. I see how I am supposed to do this - forgive, I am pretty shaky with SVNs and how to use them. I retrieved the entire SVN archive and uploaded the module files - presto! Saving the dates, nice as you please.

It still won't expire the banner though - it shows the expiration date but expired banners are still displaying on the site.  Is it an ongoing issue or should I try removing Banners and reinstalling from the SVN files?
Thanks,
Alane

[klode75]

Bonjour, hello,
I've done all u said, but what to do with the SVN ?