Page 1 of 1

[fixed] unused parameter

Posted: Sun Apr 19, 2015 6:10 pm
by bess
in file lib/classes/class.cms_module_smarty_plugin_manager.php

these functions

Code: Select all

public static function remove_by_name($name,$type)
public function _remove_by_name($name,$type)
should be

Code: Select all

public static function remove_by_name($name)
public function _remove_by_name($name)
as the parameter $type is unused.

the diff/fix can be found here : https://github.com/besstiolle/f2/commit ... 4bde895081

(luckily found this one)

these functions are only used in lib/classes/class.CMSModule.php line 301:

Code: Select all

cms_module_smarty_plugin_manager::remove_by_name($name);

Re: [Minor] unused parameter

Posted: Sun Apr 19, 2015 6:14 pm
by calguy1000
fixed, thanks.