Page 1 of 1
[fixed]Lock timeout (fixed in ContentManager) not in DeMa...
Posted: Wed May 28, 2014 10:36 am
by jce76350
(Rev SVN 9573)
In Settings - Global Settings - Advanced Setup
there is Lock timeout: xx
This option is used for locks to timeout in Content Manager
and in Settings - Design Manager
there is Lock Time out (minutes) : xx
this option is not used in Content Manager ?
Re: Lock timeout
Posted: Wed May 28, 2014 1:38 pm
by calguy1000
There are three settings:
a: in global settings
(this sets the 'default' lock timeout)
b: in content manager
(this sets the lock timeout for content pages, which overrides the default only for content pages).
c: in design manager
(this sets the lock timeout for templates, which overrides the default only for templates)
Re: Lock timeout
Posted: Wed May 28, 2014 1:51 pm
by jce76350
b: in content manager
(this sets the lock timeout for content pages, which overrides the default only for content pages).
Ok but
this option (in content manager) do not override the default in global settings
I test 10 in global settings and 5 in content manager
On content pages, lock a page and Expire = 10
Re: Lock timeout
Posted: Wed May 28, 2014 2:37 pm
by hoshy
The problem is also described
here
In the latest revision of the file /admin/ajax_lock.php (rev. 9443) the problem still exists:
Code: Select all
// see if we can get this lock... if we can, it's just a touch
$lock = null;
try {
$lock = CmsLock::load($type,$oid,$uid);
}
catch( CmsNoLockException $e ) {
// lock doesn't exist, gotta create one.
$lock = new CmsLock($type,$oid);
}
As you can see the locking timeout is neither passed to CmsLock::load() nor to CmsLock() itself. In fact it does not even catch the values that might be passed from the modules via POST-request. See top of the file:
Code: Select all
$opt = get_parameter_value($_REQUEST,'opt','setup');
$type = get_parameter_value($_REQUEST,'type');
$oid = get_parameter_value($_REQUEST,'oid');
$uid = get_parameter_value($_REQUEST,'uid');
$lock_id = get_parameter_value($_REQUEST,'lock_id');
Anyway the lock timeout is not passed by the lockManager javascript. See file "/lib/jquery/js/jquery.cmsms_lock.js". I don't know where exactly the issue is but i can clearly see in the network console of firebug that there is no timeout passed in the ajax post request.
Re: Lock timeout
Posted: Thu May 29, 2014 8:33 am
by jce76350
OK Solved for the locking into CMSContentManager (rev 9577)
But not Ok for the locking into DesignManager
Global Settings - Advanced Setup Lock timeout: 8
Settings - Design Manager Lock timeout: 5
so
in Design Manager lock a template Expires: 60
in Design Manager lock a Stylesheet Expires: 5
Re: Lock timeout (fixed in ContentManager) not in Design Man
Posted: Tue Jun 03, 2014 6:47 pm
by jce76350
In Design Manager / Stylesheets if a stylesheet is locked there is no icon warning.gif on the line locked
Re: Lock timeout (fixed in ContentManager) not in Design Man
Posted: Tue Jun 03, 2014 6:57 pm
by uniqu3
jce76350 wrote:In Design Manager / Stylesheets if a stylesheet is locked there is no icon warning.gif on the line locked
Fixed in SVN rev: 9611
Re: Lock timeout (fixed in ContentManager) not in Design Man
Posted: Tue Jun 03, 2014 7:05 pm
by jce76350
In Design Manager / Stylesheets if a stylesheet is locked there is no icon warning.gif on the line locked
Fixed in SVN rev: 9611
@ uniqu3 : Whaooo super quick fix
Now for calguy1000
http://forum.cmsmadesimple.org/viewtopi ... 28#p312528
But not Ok for the locking into DesignManager
Global Settings - Advanced Setup Lock timeout: 8
Settings - Design Manager Lock timeout: 5
so
in Design Manager lock a template Expires: 60
Re: Lock timeout (fixed in ContentManager) not in Design Man
Posted: Fri Jun 06, 2014 7:41 pm
by uniqu3
Fixed in SVN rev 9624
- Lock timeout on templates should work properly now.
- Edit actions are locked with exception error message on direct url access attempt
- If for whatever reason a edit action interface is accessed by direct url, submit and apply is disabled with disabled attribute (that should be enough for a regular user who doesn't want to do any harm)
- If a lock has expired but user has left the page open, that user should no longer be able to continue working, on apply or submit, exception error will be shown.
I didn't check CotnentManager though
Re: [fixed]Lock timeout (fixed in ContentManager) not in DeM
Posted: Sat Jun 07, 2014 7:43 am
by jce76350
everything : content and desing seems ok for me
