CMS Made Simple Forums

The product module (version 2.18.2) still doesn't allow you to specify the detailtemplate to use when opening viewing a product from the summary view.
I've been poking around the php code and made a comparison to the news module that has this feature implemended.
Basically what news does for now is to add a /d,mydetailtemplate to the end of the pretty url (wich is the cause of the initial problem).

Here is how i managed to implement this to products:

could this be ported as a 'fix' ?

removed "hacked" code ? Wow, that's not very "open source" minded... I don't feel like a haker neither

I'm trying to have a discussion about a modification (as suggested in this post from Calguy himself. http://forum.cmsmadesimple.org/viewtopic.php?f=7&t=2712.).

Is discussing about a possible solution forbidden then ? (or is is allowed only if we stay out of the source...?)

I understand that one has to take full responsibillity when modifying code (and it is a fact as we loose comatibility with future upgrades) and then not come back complaining about broken features or bugs.
If a fool comes on this very post and copy/paste the modified code without taking this into account and then comes back and complains, then stop him by blocking his posts.
It's not by censuring a discussion that you'll stop people complaining and whining uselessly on the forum.
In fact what you'll just archieve is crippling the open-source spirit of the community. It's just counter productive.

a) I told you that on IRC!

<Kube> ok. i'll do that and post my changes (small tweaks) on the forum.
<uniqu3_> Kube: do not post code changes in Forum, it is against Forum rules, if it's a bug of a module then post a Bug and comment with your changes
<uniqu3_> same for FR, or create a diff

b) If you have read Forum rules http://forum.cmsmadesimple.org/viewtopi ... 40&t=28132 then you would understand

c) Cool you changed code, made it available for public. Yes! What an effort! Great OpenSource spirit hurray!

Now what? There are people reading this forum some are skilled, know what they do and some simply copy/paste and hope for best.

Then some time later:

You are not here, you dont care about what you posted and where, but those "copy/paster" visitors blow up their site be it while copying, while upgrading whatever, they come here, scream "Oh NOOOOOOOO my Site is broken!"

Moderators, DEV Team try to help, but that "copy/paster" forgot to mention he copied some code somewhere without knowing what he is doing.

Few days latter finally someone hopefully finds it out!

d) If you do not like the rule, i cant help you, i didn't create any of rules, but i try to follow these as majority of users here.
Like it or not!

e) There is Bug Tracker and Feature Request possibility in Forge, use it!
Paste your changes there, a experienced User will find his way there.
I think thats very OpenSource spirit thingy you mentioned.

Oh, sorry didn't see your later reply on the IRC.
I did post the "fix" on the forge (FR) prior to my post in this forum. But i did thought this section was also made for discussing code (and maybe come back to the FR with a more optimised fix proposal), according to the post i saw earlyer. obviously it isn't.

I'll comply to the rules, even if you're not the one making them (but you're the one i've been reading a lot of good stuff on the blog, tx btw)