Page 1 of 1
AjaxMadeSimple Module is not properly cleaning input params
Posted: Sat Jan 21, 2012 9:54 am
by stetman
I am using cmsms 1.10 and just installed the polls module, everything seems to work fine.
Only thing is that my admin log has 100's of pages full with:
AjaxMadeSimple Module is not properly cleaning input params
Does anybody know what's happening ?
Marc
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Sat Jan 21, 2012 12:04 pm
by staartmees
This project is marked as stale. This means that it may work fine, but it has no file releases or repository commits in over a year. Use your own discretion when using this project.
It's obvious this module is no longer supported and it isn't compatible with cmsms 1.10.x
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Sun Apr 15, 2012 12:23 am
by oliver341
I have the same problem, with "Module is not properly cleaning input params" appearing in the admin log every time a page is loaded on the site, AjaxMadeSimple is being blamed (I use it for the Polls module).
Module was updated on 2012-02-13 so it seems it isn't stale.
CMSMS version: 1.10.3
AjaxMadeSimple version: 0.3.3
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Sun Apr 15, 2012 5:23 pm
by Jo Morg
AFAIK it is more of a warning than an error, although, IIRC, that may change in CMSMS 1.11 and became an error. I think it doesn't hurt to file a bug report, if there isn't one already, on the forge.
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Sun Apr 15, 2012 9:47 pm
by oliver341
There already seems to be an open bug about this on the forge.
http://dev.cmsmadesimple.org/bug/view/6699
It has been open for about 9 months.
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Sun Apr 15, 2012 11:03 pm
by Jo Morg
Yeah! It's not a problem as it does not interfere in the module normal functions, at least as far as CMSMS 1.10.X (at least as far as I recall). It may become a problem with CMSMS 1.11 if the module is not updated until then.
Unless someone more knowledgeable than me corrects me...
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Mon Apr 16, 2012 1:19 am
by oliver341
Jo Morg wrote:It's not a problem as it does not interfere in the module normal functions
It is a problem in that the Admin Log is flooded with messages to the point of becoming useless.
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Mon Apr 16, 2012 6:02 am
by vilkis
Really, it floods Admin log. It should be onetime message but not repetitive. It is issue of CMSMS and not the module. For the moment I hacked CMSMS core file to disable these messages.
vilkis
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Mon Apr 16, 2012 9:54 am
by oliver341
Yeah, a one-time message might be good, or something like "the last message was repeated 355 times" like syslog does, maybe.
But ultimately something inside the module needs fixing.
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Mon Apr 16, 2012 10:07 am
by vilkis
This problem is the same as in
http://dev.cmsmadesimple.org/bug/view/7016
The solution could be to make this message not repetitive in CMSMS core.
vilkis
Re: AjaxMadeSimple Module is not properly cleaning input pa
Posted: Mon Apr 16, 2012 10:15 am
by oliver341
If it's simple I'll just insert one or two lines of code into the code of AjaxMadeSimple. Does anyone know how you "clean input params"?