Page 1 of 1

[closed] Path separators in DisplayImage()

Posted: Tue Sep 20, 2011 8:08 am
by tomphantoo
There are quite a few instances of hardcoded path separator '/' in DisplayImage() (in file class.admintheme.inc.php).

It seems that this func deals with paths, not URL's, and in that case, should the separators be DIRECTORY_SEPARATOR ?

Same for 1.9.

Re: Path separators in DisplayImage()

Posted: Fri Sep 23, 2011 4:13 pm
by Rolf
tomphantoo wrote:There are quite a few instances of hardcoded path separator '/' in DisplayImage() (in file class.admintheme.inc.php).

It seems that this func deals with paths, not URL's, and in that case, should the separators be DIRECTORY_SEPARATOR ?

Same for 1.9.
We don't think hardcoded '/' would cause any problems, even now in Windoze ;)

Rolf