Page 1 of 1

Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Posted: Wed Sep 15, 2010 9:48 am
by atz6975
Hi,
I'm not sure how this should be done and sorry if I offend anybody.

This is an updated listhtmlblobs.php to fix http://dev.cmsmadesimple.org/bug/view/5058
Basicaly admin doesn't filter the total amount of content with the user rights.

here is the annoted code (I'm PHP noob so sorry for possible uglyness), look for //FIX 5058 and //FIX END



Please follow forum rules... there is a policy against posting code changes in this forum.  Also there have been guidelines posted as to how to properly submit your suggested changes, and bloating the forum with them is not it.

Re: Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Posted: Wed Sep 15, 2010 1:57 pm
by atz6975
I new I should have read more....rules!

Sorry again...
... and I included a little bug so I guess : point made !  ::)
I was about to fix the fix

Is it me or there is no 1) 2) 3) about contributing code/fixes?
I managed to get the svn but I'm no dev so I'm not sure how to commit...?

As for the fix of the fix : how do I send it ?

Thanks.

Re: Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Posted: Wed Sep 15, 2010 2:02 pm
by calguy1000
if you do a search for 'submit patches'.  it finds the guide (a little outdated, but not much) very quickly.

Re: Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Posted: Wed Sep 15, 2010 3:40 pm
by atz6975
Hi,
I found it indeed. Thank you.
EDIT : How do I forward a diff to you guys? Bug Tracker if I read well.
Please advise if otherwise.

Re: Fix in listhtmlblobs.php for cmsms 1.7.x to 1.8.2

Posted: Wed Sep 15, 2010 4:48 pm
by atz6975
I hope I didn't make something stupid....
So I cut and pasted the patch, inside the Bug Tracker comment.
Please forgive any noobness here as I'm not too familiar with this.
I followed (luckily) tags 6537 > version 1.8.2 as check-out point

I looked at your 2.0 code, same problem and fix could apply.
I wonder if not more elegant to have a filtered "htmlbloblist" before displaying it to avoid multiple checks...

Man, I hope I did it right this time...