Page 1 of 2
formbuilder unable to reorder form elements
Posted: Mon Aug 16, 2010 2:24 am
by uptoeleven
Hi,
I am having difficulty reordering form elements in formbuilder - it seems to be ignoring my request once I have hit the "Save" button.
To try to diagnose I have installed a fresh copy of CMSMS on my server with just a single module installed - formbuilder. Problem occurs when changing form element order (If I wanted name below email address instead of above, for example).
Now going to try on debug and checking apache blogs.
Simon
Re: formbuilder unable to reorder form elements
Posted: Mon Aug 16, 2010 1:54 pm
by kerryshamblin
I am experiencing the same thing, with a fresh install of 1.8.2 and Formbuilder 0.6.3. That is the only module I have installed. I'm working on a server I'm not familiar with (GoDaddy). Please let us know if you figure it out!
Thank you.
Re: formbuilder unable to reorder form elements
Posted: Fri Aug 20, 2010 9:58 pm
by mr.bacan
This seems to be a problem associated with CMSMS 1.8.2, because I'm having the same problem.
I have version 1.7.1 installed on the same server and the module is working just fine.
Could someone please post a way around this issue?
Thanks in advance.
Re: formbuilder unable to reorder form elements
Posted: Fri Aug 20, 2010 11:06 pm
by ITF
Yeah, I'm having the same problem. CMSMS V1.8.2
New install of FormBuilder. Doesn't save reorder of form elements.
Please let us know how/when you solve this. Thanks.
Re: formbuilder unable to reorder form elements
Posted: Sat Aug 21, 2010 1:24 am
by Jos
I guess Formbuilder got some code copied from Gallery, because with Gallery the same issue was reported. Here's how it is solved for Gallery:
http://dev.cmsmadesimple.org/bug/view/5309
Re: formbuilder unable to reorder form elements
Posted: Sat Aug 21, 2010 1:56 am
by ITF
I tried it but maybe I did something wrong. I edited modules/FormBuilder/classes/Form.class.php
Around line 1528
Code: Select all
$mod->smarty->assign('fb_hidden', $mod->CreateInputHidden($id,'fbrp_form_op',$mod->Lang('updated')).$mod->CreateInputHidden($id,'fbrp_sort', '', 'id="fbrp_sort"'));
Changed to
Code: Select all
$mod->smarty->assign('fb_hidden', $mod->CreateInputHidden($id, 'fbrp_form_op', '<div class="hidden" id="sort">' .$mod->Lang('updated')).$mod->CreateInputHidden($id, 'fbrp_sort','','') . '</div>');
Didn't work
Did I change the wrong file/line?
Thanks for chiming in, Jos!
Re: formbuilder unable to reorder form elements
Posted: Sat Aug 21, 2010 2:13 am
by Jos
It looks like the right line, but the change isn't that good ;)
better change it to
Code: Select all
$mod->smarty->assign('fb_hidden', $mod->CreateInputHidden($id,'fbrp_form_op',$mod->Lang('updated')).'<div class="hidden" id="fbrp_sort">'.$mod->CreateInputHidden($id,'fbrp_sort', '').'</div>');
But this is not the only line that should be changed.. there is also some javascript refering to
#fbrp_sort, that should now refer to
#fbrp_sort input
*edit*
I found the javascript in file includes/fb_jquery.js
*edit 2*
I noticed this is already fixed in SVN by Stikki in a slightly different way. He did not use a surrounding div but simply turned the id into a class.
Re: formbuilder unable to reorder form elements
Posted: Mon Aug 23, 2010 3:47 pm
by kerryshamblin
Thanks, Jos! I've implemented your solution and the problem is solved.
Re: formbuilder unable to reorder form elements
Posted: Mon Aug 23, 2010 4:47 pm
by ITF
Just got a chance to make the edit also.
Thanks for pointing out the proper change, Jos!
Re: formbuilder unable to reorder form elements
Posted: Wed Aug 25, 2010 4:46 am
by mr.bacan
Hello, I made the edits without any luck
I'm still having the same problem. Also the form doesn't send any data nor validates, it just sends you to the index when you hit the send button.
The website is
http://www.festejosybrindis.com/index.php (It's in Spanish)
I know I made the changes as mentioned, so I think I'll have to wait for the fixed version of this module.
Thanks for your time anyway
Re: formbuilder unable to reorder form elements
Posted: Fri Aug 27, 2010 9:56 pm
by nicmare
problem solved. browse the forge for the latest release of formbuilder.
Re: formbuilder unable to reorder form elements
Posted: Fri Aug 27, 2010 11:46 pm
by vedat
I thing problem is not solved
Cmsms 1.7.1 and formbuilder 0.6.4 reordering is not work
Re: formbuilder unable to reorder form elements
Posted: Sat Aug 28, 2010 2:43 am
by ITF
vedat wrote:
I thing problem is not solved
Cmsms 1.7.1 and formbuilder 0.6.4 reordering is not work
The two line changes should work. Let us know how you did it, maybe we can help since it worked for us?
Mine was a clean install of Toliara 1.8.2 and formbuilder 0.6.3. After code change, it worked fine.
Maybe the 0.6.3 works for 1.71
and 0.6.4 made the code changes to 1.8.2?
I'm not so sure, but any additional information could help us in helping you guys.
Re: formbuilder unable to reorder form elements
Posted: Tue Sep 14, 2010 3:25 pm
by Andiministrator
I still have this problem. I use CMS 1.8.2. I have the newest version (last checkout today) from SVN, but it doesn't works. I tried to use your modifications but it still doesn't works. Any other idea?
Re: formbuilder unable to reorder form elements
Posted: Mon Sep 20, 2010 4:49 am
by uptoeleven
which version of formbuilder? The problem is with formbuilder as far as I know...