CMS Made Simple Forums

Hello.

Maybe someone is interested in the fixes i've made to Teremba Bay release.
Here they are:

1. fix plugins/function.cms_selflink.php

434: $result .= '/>';

in order to have closing `/>' instead of "".

2. simple tagging plugin fix
(server complaints "Notice: Use of undefined constant content - assumed 'content' in [SKIPPED]")

328: 329: 335:
Just put [content] and [Tags] in '', so it turns to ['content'] and ['Tags'].

3. Minor fix to visitor stats

I can't remember the line, but there is one typo in the code..

4. Also i couldn't get Glossary work with pretty urls correctly.
Maybe it's possible for community to improve the module and represent it, since it's of great value for site owners.

Thank you.

P.s. sorry if i confused a category to post this stuff in..

This is invalid code

Thank you! You're right.
How could i mess href tag with those who must have ending `/>' %-\

I don't know should we bother about one space left between the title and closing `>'. Have got to take a look at the specification.

Well, after the changes to simpletagging module there is still one warning left
"Notice: Undefined index: Tags in /home/lg-consult/lg-consult.ru/docs/modules/simpletagging/simpletagging.module.php on line 329"

It happens after the changes to the content page is done which doesn't have a tag field, because this page wasn't intended to work with this feature anyway.

The following code solves the issue:

                                if (isset($params['content']->mProperties->mPropertyValues['Tags']))
                                {
                                  $tags = $params['content']->mProperties->mPropertyValues['Tags'];
                                }
                                else
                                {
                                  $tags = '';
                                }

However it doesn't seem to be a problem, since the value of Tags is automatically assigned to ''. It's just a matter of observing warning message each time a content is edited.

You do realize that if you change core module code or the code of any module you render yourself to being non-supported in the core or the module, if you know how to hack code you must know enuf to do your own support...