CMS Made Simple Forums

Since release 1.6 simple_navigation.tpl is troublesome.

I've mentioned this previously here; however, after more investigation there is definitely a functional issue with it. Previously the current page had its hyperlink replaced with an H3 to make it non-clickable. This still happens, unless the page has children.

This seems wrong to me, does anyone agree? The fact it sets the H3 (in my opinion correctly) on some active pages, suggests to me that it should do so for all active pages... irrespective of whether that page has children or not.

Here's some HTML code examples of what is happening...

Active page with children:
Page With Children

Active page with no children:
Page With No Children

Also, a smaller issue, the comments at the top of simple_navigation.tpl relate to the old CSS selectors pre 1.6.

So if you were using the simple left nav template you would want the menuactive menuparent to just be an h3...

All default templates are just examples, you can change whatever your heart desires, but the menu stays as is...

Well maybe a change in the wording at top ...

Of course I can change the template, that's not the point though.

I am trying to make a Theme for release to the community that, as much as possible, works with a vanilla install of CMSMS. Changing default Menu Manager templates between core versions -- thus breaking all Themes that relied upon the old CSS selectors -- is rather frustrating... and it's even worse when the new MM template is apparently bugged.

The pre-1.6 simple_navigation.tpl was absolutely fine and worked properly with active pages with children. I'm just seeking some agreement that there is a problem with the 1.6 Menu Manager template.

It's enough of a pain making a nicely packaged Theme -- given that you can't hook into GCB functionality or easily include module templates -- it would be very helpful if the fundamentals were more solid.

Sorry if that sounded cranky.

If you think what I'm saying sounds silly, take a look at the Themes website. I reckon most of the Themes that have comments are people with smarty errors saying the menus don't work for them. If the default MM templates could be relied upon, then they solve most menu situations out of the box and Theme builders wouldn't would have an easier job and users would be happier.

You must not have used the theme manager much, when you export a theme it takes the menu template with it no matter what you use, so if you use simple-nav menu template and export a theme it will take the menu template with it and import it into menu manager...

Theme named joe, export it w/o putting a name in the Export Theme As: field and it is theme.xml, import it into another site and it is theme : joe and the menu template becomes "joe : simple-nav" and the menu call reflects this...

Most of the menu errors in the theme site are from versions of cmsms/menu manager that had problems with exporting and importing menu templates...

So bottom line, it won't matter what you do about the menu it will go with the theme and not use any default menu templates of the site you install it in, which is as it should be...

Ah, right, that isn't so bad. Although I have used Menu Manager quite a lot, I've not used the Theme functionality very much and wasn't aware it also pulled the menu template with it. This makes my life a little bit easier, that's for sure -- cheers Mark!

I'd appreciate your feedback on my Theme before I upload it, can I PM you a link to it?