Page 1 of 2
[solved] [1.6.0.] Bug found
Posted: Mon Jun 22, 2009 7:26 pm
by hihachi
Hi there,
i am sorry to inform you that i found a bug.
Running CMS Made Simple 1.6
PHP Version 4.4.0
Apache 2.0.54
This Bug is not within the last Version of CMS Made Simple 1.5.4.
Bugreport:
Within the Admin-Backend-Area, please select Content->Pages
On the following Page, please select with the Checkbutton one or more pages. Then select within the select-field at the end of the table the function delete and press submit.
The following error occurs:
Code: Select all
Parse error: parse error, unexpected '=', expecting ')' in /srv/webroot/admin/multicontent.php on line 48
The Line within multicontent.php looks like this:
Code: Select all
function get_delete_list($sel_nodes,&$parent = NULL,&$final_result,$depth = 0)
Please keep in mind with Version 1.5.4. this works without a problem.
Greetings
Matze
Re: [1.6.0.] Bug found
Posted: Mon Jun 22, 2009 7:40 pm
by calguy1000
validate your upload... because I checked the code and it looks valid.
Re: [1.6.0.] Bug found
Posted: Mon Jun 22, 2009 7:52 pm
by hihachi
Hi calguy,
calguy1000 wrote:
validate your upload... because I checked the code and it looks valid.
downloaded the Source as tgz directly on the shell.
Uncompressed the stuff with mc and copied it right over the old version.
Started install/ugrade.php which run through just fine..
What else should i check?
Matze
Re: [1.6.0.] Bug found
Posted: Mon Jun 22, 2009 8:09 pm
by hihachi
Ok,
installed a brand new fresh version and checked with the file cmsmadesimple-1.6-full-checksum.dat.
Passed every test.
Installed it.
Still this error occured..
Greetings
Matze
Re: [1.6.0.] Bug found
Posted: Mon Jun 22, 2009 8:11 pm
by alby
hihachi wrote:
Still this error occured..
The problem is PHP4
Can you drop = NULL from function and report?
function get_delete_list($sel_nodes,&$parent = NULL,&$final_result,$depth = 0)
Alby
Re: [1.6.0.] Bug found
Posted: Mon Jun 22, 2009 8:54 pm
by hihachi
alby wrote:
The problem is PHP4
Can you drop = NULL from function and report?
function get_delete_list($sel_nodes,&$parent = NULL,&$final_result,$depth = 0)
Alby
What exactly do you mean?
Should i edit the code?
matze
Re: [1.6.0.] Bug found
Posted: Mon Jun 22, 2009 9:12 pm
by hihachi
Ok..
changed the source
into
Code: Select all
function get_delete_list($sel_nodes,&$parent,&$final_result,$depth = 0)
now it seems to work..
at least, there is this security-question and everything selected is deleted then.
Matze
Re: [1.6.0.] Bug found
Posted: Mon Jun 22, 2009 9:14 pm
by reneh
ok
A fix for this will probably come "later" (= next bug fix)
Re: [1.6.0.] Bug found
Posted: Tue Jun 23, 2009 2:24 am
by MyHacks
Err... sorry to ask. Where can I download version 1.6?
Re: [1.6.0.] Bug found
Posted: Tue Jun 23, 2009 2:31 am
by Ziggywigged
MyHacks wrote:
Err... sorry to ask. Where can I download version 1.6?
Downloads > File Releases:
http://dev.cmsmadesimple.org/project/files/6#package-1
Re: [1.6.0.] Bug found
Posted: Tue Jun 23, 2009 2:34 am
by viebig
MyHacks wrote:
Err... sorry to ask. Where can I download version 1.6?
There is a big button on the top of cmsms site name "Downloads", the rest is up to you!
Regards
G
Re: [1.6.0.] Bug found
Posted: Tue Jun 23, 2009 5:14 am
by MyHacks
Gosh!
Last time I checked there I only found version 1.5.4.
p.s: it was released yesterday and all the download counter is still '0'. lol.
Re: [1.6.0.] Bug found
Posted: Tue Jun 23, 2009 7:23 am
by RonnyK
Myhacks,
that is because the counter only updates every 24 hrs
Ronny
Re: [1.6.0.] Bug found
Posted: Tue Jun 23, 2009 8:18 am
by hihachi
Hi there,
ok..now this version seems to work.
My little Upgradeinstructions for Version 1.5.4. to 1.6.0 if you are using an old php-Version (tested php 4.4)
1. Download latest Version (currently 1.6)
2. Make backup of everything .)
3. Copy new Version over old Version
4. Call
http://yoursite.com/install/upgrade.php
5. After running through the script, go check Extensions->tinymce and set everything to default values
6. Edit file yourcmsroot/admin/multicontent.php
Line: 48
from:
Code: Select all
function get_delete_list($sel_nodes,&$parent = NULL,&$final_result,$depth = 0)
into
Code: Select all
function get_delete_list($sel_nodes,&$parent,&$final_result,$depth = 0)
Currently testing the upgraded version.Seems to work fine right now..
Matze
Re: [1.6.0.] Bug found
Posted: Tue Jun 23, 2009 4:25 pm
by Pierre M.
You are lucky the DevTeam was around in the forum to respond to your (nice) bug report. You can make the life of the DevTeam easier by filing your (next) bug reports in the forge rather than in the forum : it is easier for the DevTeam to track issues in the forge with an issue #id ; then when the fixpack is ready you can check "fixed #id" in the release notes (and the forge can notify you of the fix).
Have fun with CMSms
Pierre M.