Page 1 of 2

Problem after upgrading from 1.2.4 to 1.4 to 1.4.1 [SOLVED]

Posted: Thu Oct 02, 2008 4:26 pm
by davids355
I upgraded full file from 1.2.4 to 1.4 everything seemed ok but when I went to edit a page (in admin), I got this error (no matter what page I tryed to edit):

c1608e58b7a40647381b4667630bf061

Notice:  Undefined index:  p in /homepages/***/htdocs/sw/cmsmadesimple/lib/classes/contenttypes/old__Content.inc.php on line 118

82d58bfc8dc7a2fa985939b01d5b694f
69175bee376c12eba6ddbd1f632a7f10

Fatal error: Cannot instantiate non-existent class: old__content in /homepages/20/***/htdocs/sw/cmsmadesimple/admin/editcontent.php on line 438

I deleted old__content.inc.php and ext__content.inc.php and everything seems to work now. Just wondering what may have caused this and did I need these two files?

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Thu Oct 02, 2008 7:22 pm
by alby
davids355 wrote: I upgraded full file from 1.2.4 to 1.4 everything seemed ok but when I went to edit a page (in admin), I got this error (no matter what page I tryed to edit):
For me you are hacked
Goto in System Verification and run checksum of 1.4.1

Alby

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 8:46 am
by davids355
does anyone have checksum to hand, as the dev site is down??

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 10:21 am
by alby
davids355 wrote: does anyone have checksum to hand, as the dev site is down??
It's online now

Alby

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 11:05 am
by davids355
great! How exactly do I use the checksum though? I have downloaded 1.4.1-full checksum, uploaded it in my cms admin and it comes up with loads of files missing -

Some from install directory (Which obviously I have deleted)
Some from tmp directory?
And some from admin directory - however I have renamed this directory (As per security instructions from cmsmadesimple)

So where do I go from here, is there something that would flag up if Id been hacked, or am i doing it the wrong way?

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 11:34 am
by davids355
Ok worked it out...

few files missing from tmp directory, but importantly:

20 Files failed md5sum check:
./admin/addtemplateassoc.php
./admin/themes/NCleanGrey/docs/CHANGELOG.txt
./admin/themes/NCleanGrey/css/style-rtl.css
./admin/themes/NCleanGrey/css/ie6.css
./admin/themes/NCleanGrey/css/style.css
./admin/lang/ext/sv_SE/admin.inc.php
./admin/lang/ext/nl_NL/admin.inc.php
./admin/lang/ext/fr_FR/admin.inc.php
./admin/lang/ext/ru_RU/admin.inc.php
./admin/lang/ext/pt_PT/admin.inc.php
./admin/lang/ext/nb_NO/admin.inc.php
./admin/lang/ext/sl_SI/admin.inc.php
./admin/lang/ext/it_IT/admin.inc.php
./admin/lang/ext/de_DE/admin.inc.php
./admin/lang/en_US/admin.inc.php
./admin/templates/changeusergroup.tpl
./admin/templates/systeminfo.tpl
./admin/changegroupperm.php
./admin/editcontent.php
./admin/systeminfo.php

What to do??!!?

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 11:36 am
by davids355
And by the way I HAVE been hacked several times in the past and found malicious code in the head or certain of my pages. Have removed it since, but maybe there is still remnants of this.

Thats really why I upgraded to latest version in the hope of preventing it!

Any advice will be appreciated.

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 11:45 am
by Siamed
If you renamed the admin directory, wouldn't all of the files in "/admin" fail a checksum since they are not located there anymore?  Or does the checksum account for that?

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 1:08 pm
by davids355
No sorry, on this post I have put admin (its really called something else, but just for security I changed it here). It is finding correctly most of the files in the admin directory, but the few I have listed here it is saying a not corresponding with the checksum.

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 1:09 pm
by Nick Smart
Siamed wrote: If you renamed the admin directory, wouldn't all of the files in "/admin" fail a checksum since they are not located there anymore?  Or does the checksum account for that?
Just do a "search and replace" in the checksum file with your favourite editor before using it.

Nick

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 2:20 pm
by davids355
Yes I did do that, so I know its finding my admin directory ok, but it is reporting these files as having bad checksum. What should I do?

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 2:54 pm
by alby
davids355 wrote: Yes I did do that, so I know its finding my admin directory ok, but it is reporting these files as having bad checksum. What should I do?
Re-uploads these files and check if your FTP client overwrite

Alby

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 3:09 pm
by davids355
ok will try that, can they all be overwriten by the defaults then (no customisation in these files?).

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 3:50 pm
by davids355
Hmm strange, downloaded cmsmadesimple-1.4.1-full and then via ftp I uploaded for example admin/systeminfo.php (one of the ones that said checksum was bad) then rechecked in system verification and even with the original file uploaded to server, it still says the checksum is bad?? What now??

Re: Problem after upgrading from 1.2.4 to 1.4 to 1.4.1

Posted: Fri Oct 03, 2008 5:23 pm
by Pierre M.
davids355 wrote: And by the way I HAVE been hacked several times in the past and found malicious code in the head or certain of my pages....

Any advice will be appreciated.
http://forum.cmsmadesimple.org/index.ph ... 539.0.html
and read the security howto

Pierre M.