Page 1 of 1

[solved] function.cms_selflink.php implementation question

Posted: Sat Aug 09, 2008 10:06 am
by fredp
Hi,

Being new to CMSMS, I've been looking through the 1.4 code to get familiar with it. In plugins/function.cms_selflink.php I noticed that line 49 looked "suspicious". Shouldn't it be getting the value of $params['ext_info'] instead of $ext_info or am I missing something? 

Code: Select all

   $external_text = '(external link)';
   if ( isset($params['ext_info']) ) {
      $external_text ='( '.$ext_info.' )';
   }
Thanks,
Fred

Re: function.cms_selflink.php implementation question

Posted: Tue Aug 12, 2008 4:25 pm
by Pierre M.
Hello,

if it is not fixed by 1.4.1, please post there : http://forum.cmsmadesimple.org/index.ph ... 562.0.html
or better : file a bug in the forge (where the DevTeam can track code issues).

Pierre M.

Re: function.cms_selflink.php implementation question

Posted: Wed Aug 13, 2008 4:36 am
by fredp
Thanks.  I filed a bug since it isn't fixed in 1.4.1.

Fred P.
Pierre M. wrote: if it is not fixed by 1.4.1... file a bug in the forge (where the DevTeam can track code issues).

Re: function.cms_selflink.php implementation question

Posted: Wed Aug 13, 2008 1:11 pm
by alby
fredp wrote: Thanks.  I filed a bug since it isn't fixed in 1.4.1.
Was fixed after 1.4.1 because the code was closed for released.
It's in SVN

Alby

Re: [solved] function.cms_selflink.php implementation question

Posted: Wed Aug 13, 2008 6:08 pm
by Pierre M.
What a responsive DevTeam : bugs are fixed before they are filed !-)