CMS Made Simple Forums

There seems to be a bug in Manage Banners.

Once the URL has been set for an image, subsequently going back and changing the URL results in a Database Error upon save. Only way I could recover was to uninstall the module and reinstall.

@cnymike

You have posted to this forum lots of times, and know the rules. 

Please provide context information with your posts and as much information as possible so that we can have information to try to reproduce the problem with.  If you can't spend the time to post context information, why should we spend the time to research the problem.

You've posted a few posts in the last couple of days that should have been filtered. 

I will start moving them to the 'wasteland' if I have to.

CMSMS 1.3
Mac OS 10.5.3
PHP Version 5.2.6
mysql Client API version 5.0.41
Apache Version Apache/2.2.8
T-Shirt size XL


1. Login to Admin
2. Go to Manage Banners (If you don't have the module installed, install it first)
3. Add a Category
4. Add a banner to the category and be sure to add the URL
5. Submit (or as some of us like to say "Save")
6. Navigate to the banner you just saved and open it again
7. Change the URL to a different URL
8. Submit (Save)
9. Notice that you get  Error: Database

Okay, I just installed the Banners module (which I have checked out from SVN)

Then I created a banner category
I created a new banner specified a URL, and a label text, and alt text and all that
That worked
Then I edited that banner numerous times, and hit submit each time, and did not get any error.

I then checked the release date of the module
2.2   2008-04-21 13:09
    vs.  the svn log
So the code that is in the forge is the latest and greatest, and I am running the exact version that is in the forge.

I am running banner manager 2.2.

I just went in again and opened up a working banner. I went to the URL field and added a "/" to the end of the .com and hit submit. I immediately got an Error:Database in the banner manager window.

What I did notice is that the error will not occur if the "never" check box is not checked.

Calguy, try again and this time make sure that you also check the "never" box.

I did... spent another 10 minutes on it.... I had no problems... I could do a video, but...

I could send you the code... I did change 1 line to remove a warning, but it was unrelated to your issue.

Well I don't mind spending more time trying to figure out what is causing the error, but I don't have much to go on. Error: Database doesn't by itself provide much information.

Any ideas on how I can better troubleshoot this? I've alreday uninstalled and reinstalled the module. Should I try reinstalling the module, or try an entire new installation of CMSMS? I have not noticed any other errors or odd behaviors in any other aspects of using 1.3.

What I'm learning is that the error for me can be generated by simply selecting the "never" checkbox, if it is not selected for an existing banner, or deselecting the "never" checkbox for an existing banner, then clicking submit.

The problem does not seem to involve the changing of the URL as I initially thought and reported. Instead the Database Error is initiated when the checkbox for "never" is changed for an -existing- banner.

I have tried this on both Mac and PC's in a variety of different browsers with similar results.

1. I just added a new banner
2. I named it and only provided the path to the image and nothing else and clicked submit. The "never" checkbox was left unchecked. There was no database error upon submit.
3. I selected the just added banner and checked the "never" checkbox and clicked submit. There was no database error
4. I selected the same just modified banner and unchecked the "never" box and clicked submit. There was an Error: Database Error.

So to recap, I created a new banner and saved it. Opened the same banner and modified it by checking the "never" box and saved with no error. Not until I  tried to modify it a second time by deselecting the "never" box did the database error occur. Odd.

I have just checked this module in another installation of CMSMS 1.3 I have.. it's a different domain, but on the same server.

The same Database Error occurred doing the same thing with checking the never box and submit, and then unchecking  the "never" box and submit. IN this case the error occurred upon the first change to the banner.

calguy1000 wrote: So the code that is in the forge is the latest and greatest, and I am running the exact version that is in the forge.

i got a banners module version 2.2.1 out of svn last week; but version 2.2 is what is available for download on the forge and installable via modulemanager.

not counting Banners/lang/*, there's about a half-dozen changes between the two.

Kermit, good call! Forge has version 2.2 while SVN had version 2.2.1 available.

I went and got Banners 2.2.1 out of SVN and installed it. So far, the Database Error has not occurred. I'll mark this as solved since the problem seems to have been fixed in Banners 2.2.1

Could someone make version 2.2.1 available in the forge rather than 2.2 as I have the database error too.

Grudgeuk wrote: Could someone make version 2.2.1 available in the forge rather than 2.2 as I have the database error too.

until that happens, see my instructions on how to get it without messing around with svn:
http://forum.cmsmadesimple.org/index.ph ... #msg111575