Page 1 of 1

[Blog] Announcing CMS Made Simple 1.2.1

Posted: Sun Nov 25, 2007 6:05 pm
by From the blog
Announcing CMS Made Simple 1.2.1


It’s that time again. This is a maintenance release with no security fixes, so use your judgement for upgrading (just backup, please!).
Thanks go out to RonnyK, hExDj, reneh, and fransman for testing this one!

Version 1.2.1 "Bridgetown"
-----------------

- New versions of News, Search, Tiny, and FileManager modules
- see the documentation for each module to [...]


http://blog.cmsmadesimple.org/2007/11/2 ... imple-121/

Re: [Blog] Announcing CMS Made Simple 1.2.1

Posted: Mon Nov 26, 2007 12:56 am
by Nullig
It appears that this upgrade causes problems for anyone with UDTs.

Nullig

Re: [Blog] Announcing CMS Made Simple 1.2.1

Posted: Mon Nov 26, 2007 7:36 am
by kermit
it's also a very large DIFF file.. 1219 files; due to several new module versions. (compare to 1824 files in the full 1.2.0 archive). i was surprised to even see a diff considering the amount of "new" modules.


from the 1.2 announcement:
calguy1000 wrote:     * We intend this to be the last version of the 1.x series unless there are critical bugs or security issues that pop up
what happened to that? its nice to see some additional work being done on 1.2, as it will be the last php4 version (regardless of php's EOL of php4, many hosts and hosting customers WILL be slow to migrate to php5), but it was entirely unexpected -- was expecting fixes only -- there were only a couple of crucial fixes to get out, neither of them security related.. all these new modules and tricks, this is more like a 1.3, not 1.2.1

perhaps those daily snapshots need to start back up so interim releases like this can get some additional exposure... had there been one of 1.2.1, the issues people are having with it now (news, tags) probably would have been spotted before release.

Re: [Blog] Announcing CMS Made Simple 1.2.1

Posted: Mon Nov 26, 2007 9:09 am
by jce76350
hello,

I have problems with Tags

-- 2 User Defined Tags =  {user_agent} and  {marge_images}
Error message
string(122) "Smarty error: [in template:17 line 138]: syntax error: unrecognized tag 'user_agent' (Smarty_Compiler.class.php, line 590)"
string(123) "Smarty error: [in template:16 line 80]: syntax error: unrecognized tag 'marge_images' (Smarty_Compiler.class.php, line 590)"

-- 1 User Defined Tag custom_copyright into a Global Content Blocks
Error message
string(123) "Smarty error: [in globalcontent:footer line 1]: [plugin] unknown tag - 'custom_copyright' (core.load_plugins.php, line 124)"

Re: [Blog] Announcing CMS Made Simple 1.2.1

Posted: Mon Nov 26, 2007 9:52 am
by kermit
jce76350 wrote: hello,

I have problems with Tags

see the link 'issues' in my post, above:
http://forum.cmsmadesimple.org/index.ph ... 249.0.html

Re: [Blog] Announcing CMS Made Simple 1.2.1

Posted: Mon Nov 26, 2007 11:56 am
by MichaelK
Only my {count} code don't work anymore.

Can anyone fix this code for me please
global $gCms;

$db = &$gCms->db;

// Get number of comments
$q = "SELECT * FROM ".cms_db_prefix()."module_comments WHERE  page_id =".$params['theid'];
$dbresult = $db->Execute( $q );
if( !$dbresult )
{
    echo 'DB error: '. $db->ErrorMsg()."";
}
$num_rows = $dbresult->RecordCount();
echo $num_rows;

Re: [Blog] Announcing CMS Made Simple 1.2.1

Posted: Mon Nov 26, 2007 3:52 pm
by calguy1000
the cms_date_format modifier was the culprit (though I don't quite understand why yet).  Anyways, it seems to be fixed in svn and I'm just waiting on some testing.

Re: [Blog] Announcing CMS Made Simple 1.2.1

Posted: Tue Nov 27, 2007 7:59 am
by alby
calguy1000 wrote: the cms_date_format modifier was the culprit (though I don't quite understand why yet).  Anyways, it seems to be fixed in svn and I'm just waiting on some testing.
I have testing this solution:

Code: Select all

bash-2.04# diff -Nuar modifier.cms_date_format.php.orig modifier.cms_date_format.php
--- modifier.cms_date_format.php.orig   Sun Nov 25 17:18:24 2007
+++ modifier.cms_date_format.php        Tue Nov 27 07:54:11 2007
@@ -1,11 +1,8 @@
 <?php
-
-global $gCms;
-$smarty =& $gCms->GetSmarty();
-$config =& $gCms->GetConfig();
-$fn = cms_join_path($config['root_path'],'lib','smarty','plugins','modifier.date_format.php');
-if( !file_exists($fn) ) die();
-require_once( $fn );
+/**
+ * Include the {@link modifier.date_format.php} smarty plugin
+ */
+require_once $smarty->_get_plugin_filepath('modifier', 'date_format');

 function smarty_cms_modifier_cms_date_format($string, $format = '',
                                             $default_date = '')
Alby

Re: [Blog] Announcing CMS Made Simple 1.2.1

Posted: Tue Nov 27, 2007 8:12 am
by RonnyK
Alby,

in

http://forum.cmsmadesimple.org/index.ph ... 292.0.html

is the SVN fix posted.

Ronny