Page 1 of 1

Bug: Custom 404 Error Message not shown in Global Settings

Posted: Thu Sep 01, 2005 6:43 am
by martin42
Site Admin / Global Settings

The Custom 404 Error Message works (you can save a message, then it will appear if users type in bad links). But, after pressing SUBMIT, you can't see your custom error message text on the Global Settings page!  Reloading the Global Settings page doesn't help: you still can't see the text!

The Site Down message text also can't be seen when you've saved it, but I haven't tried taking the site down to test.

Maybe this is a PostgresQL problem?  I'm not seeing any error messages in PHP.LOG or PGSQL.LOG.

Thanks

Re: Bug: Custom 404 Error Message not shown in Global Settings

Posted: Thu Sep 01, 2005 9:38 am
by Ted
This has already been fixed in svn.  Thanks!

FIXED! Bug: Custom 404 Error Message not shown in Global Settings

Posted: Thu Sep 01, 2005 9:50 am
by martin42
Thanks for another swift response!  Sorry, should have DIFFed the source myself before posting!

Sure enough, the current SVN siteprefs.php fixes the problem...

Code: Select all

diff siteprefs-OLD.php siteprefs.php
19c19
< #$Id: siteprefs.php 1694 2005-05-18 01:27:16Z sjg $
---
> #$Id$
104c104
<       $sitedownmessagetemplate = get_site_preference('sitedownmessagetemplate');
---
>       #$sitedownmessagetemplate = get_site_preference('sitedownmessagetemplate');
148c148
<                       <p class="pageinput"><textarea class="pagetextarea" name="custom404" cols="" rows=""></textarea></p>
---
>                       <p class="pageinput"><textarea class="pagetextarea" name="custom404" cols="" rows=""><?php echo $custom404?></textarea></p>
174c174
<                       <p class="pageinput"><textarea class="pagetextarea" name="sitedownmessage" cols="" rows=""></textarea></p>
---
>                       <p class="pageinput"><textarea class="pagetextarea" name="sitedownmessage" cols="" rows=""><?php echo $sitedownmessage?></textarea></p>
175a176
>               <!--
193a195
>               -->
Thanks again :-)

Re: Bug: Custom 404 Error Message not shown in Global Settings

Posted: Thu Sep 01, 2005 9:54 am
by Ted
No problem.  If I'd ever get 0.11 out the door, we wouldn't have these issues.  ;)