Page 1 of 2
[Album] - Thumblink not working with 1.0.6?
Posted: Sat May 05, 2007 3:34 pm
by rtkd
hi,
i just installed the new 1.0.6 together with the newest version of album.
i installed on 2 diff. boxes to make sure, but somehow the thumblink in {*Album List*} doesn't seem to work.
unchecking "Check this box if..." didn't solve the problem, for it was already unchecked.
so is it just me or known?
greets, rootkid
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Sat May 05, 2007 4:55 pm
by Elijah Lofgren
Which version of Album did you install (0.9.x or 0.8.x)?
If 0.8.x, did you attach CSS stylesheet to your page template?
In what way does it not work? Do you have a URL I can see?
(I may be very slow in responding, as I am packing up my PC today to go home tomorrow)
- Elijah
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Sat May 05, 2007 6:44 pm
by rtkd
sry can't make the link public atm.
u got mail.
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Mon May 07, 2007 11:10 am
by rtkd
*bump*
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Mon May 07, 2007 4:39 pm
by Elijah Lofgren
Hmm... I think it might be a problem of calling album in a content block added via a template instead of calling album in the template directly.
I tested it and instead of calling album like this:
Code: Select all
{cms_module module="album" categories="1"}
it seems to work to create an Album content type page with an alias of "album-test-page" and call album like this:
Code: Select all
{cms_module module="album" categories="1" detailpage="album-test-page"}
That way, Album has a page to show the pictures on.
In addition it seems that you need to chmod 755 (make readable)
modules/Album/css/stylesheet.css so that the style sheet will work. Currently it gives a forbidden error.
Hope this helps,
Elijah
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Mon May 07, 2007 9:05 pm
by rtkd
Hmm... I think it might be a problem of calling album in a content block added via a template instead of calling album in the template directly.
could be now in 1.0.6. it did work in 1.0.4.
your solution was of some help but gets me into some other trouble.
if i use the detailpage-solution the text-block beneath the navigation
disappears on the detail page, and the album is displayed twice instead.
i think that happens because of the 2 content blocks i have in my template and i probably could
work a way around that but it would reduce usability and maintainability.
it would really be a lot easier if i could just add the album-tag in one content block
and keep the text above separated in the other block.
maybe you can point me into the direction of another solution
or maybe even have a solution to make it work the way it used to.
greetings and thx from rainy cologne, rtkd
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Tue May 08, 2007 2:50 am
by Elijah Lofgren
Strange. I wonder what changed in CMSMS 1.0.6 that made it stop working. Someday I'll have to look into it and try to fix it.
I've filed a bug to remind myself:
http://dev.cmsmadesimple.org/tracker/in ... 7&atid=725
Sorry about this problem and that I cannot offer a better solution at this point. Someday hopefully I will work on fixing this.
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Tue May 08, 2007 8:04 am
by rtkd
cool, thank you elijah!
can you make an approx. estimate of when that is going to be?
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Tue May 08, 2007 4:32 pm
by Elijah Lofgren
I've sent you an email.
I'll hopefully investigate and get this fixed before Monday.
Thanks,
Elijah
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Wed May 09, 2007 8:09 pm
by fuquam
Check all permissions on the files used by Album. I had a similar problem and went into each files and directory and had to manually fix permissions. It works fine now. Oh yeah and I'm using 1.0.6.
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Sat May 12, 2007 5:43 pm
by Elijah Lofgren
rtkd wrote:
Hmm... I think it might be a problem of calling album in a content block added via a template instead of calling album in the template directly.
could be now in 1.0.6. it did work in 1.0.4.
I'm finally working on fixing this. I got distracted with other CMSMS things and was sick for a little while.
From my tests, I can't get it to work in CMSMS 1.0.4, however, I will try to fix it anyways.
It seems that most of $params is missing when Album is called from a 2nd content block which makes Album not know that an Album has been clicked on.
Hopefully I will find the source of the problem and get this fixed today,
Elijah
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Sat May 12, 2007 6:00 pm
by Elijah Lofgren
It seems that making the following change to plugins/function.content.php fixes this problem:
Code: Select all
Index: plugins/function.content.php
===================================================================
--- plugins/function.content.php (revision 3963)
+++ plugins/function.content.php (working copy)
-43,11 +43,9 @@
else if (isset($_REQUEST['action'])) $action = $_REQUEST['action'];
//Only consider doing module processing if
- //a. There is no block parameter
- //b. then
- // 1. $id is cntnt01
- // 2. or inline is false
- if (!isset($params['block']) && ($id == 'cntnt01' || ($id != '' && $inline == false)))
+ // 1. $id is cntnt01
+ // 2. or inline is false
+ if (($id == 'cntnt01' || ($id != '' && $inline == false)))
{
$cmsmodules = &$gCms->modules;
I'm going to try and find out from Ted or calguy1000 why it was originally set up to not do module processing for blocks.
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Sat May 12, 2007 7:49 pm
by Elijah Lofgren
That change can't be done because:
14:02 elijahlofgren: the risk that taking
that out is that a module may be processed twice
The correct way to make Album work is to use inline links.
14:07 non inline forms replace {content},
inline forms replace the blocks they're coming from....
I've added a "Use Inline Links" option to the SVN of Album (I hope to do a release today) which, when enabled, should fix this problem.
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Sun May 13, 2007 3:00 am
by Elijah Lofgren
I've released Album 0.9.0 which should fix this problem once you check the box next to "Use Inline Links" in the Album options.
You can download Album 0.9.0 here:
http://dev.cmsmadesimple.org/frs/?group ... ase_id=851
Please let me know if you run into any problems with the new release.
Thanks for your patience in getting this issue fixed,
Elijah
Re: [Album] - Thumblink not working with 1.0.6?
Posted: Mon May 14, 2007 12:12 am
by ittsmee2
I am not getting any links to my album pics with the new version. When I click on an album link I just get sent back to my site root. It's not creating any links.