Page 1 of 1

Re: Code cleanup...

Posted: Mon May 07, 2007 10:38 am
by rtkd
agreed,

tho compared to code from projects like xt:commerce, cmsms is like heaven!

i know its always very difficult to agree on a common set of rules for formating code,
when ur working on it with more than say 3 ppl at the same time. but with every additional line of code
it gets more important.

Re: Code cleanup...

Posted: Mon May 07, 2007 1:15 pm
by calguy1000
It's very difficult, and hard to enforce on an open source project such as this.  If you want cooperation, we feel you can't be too strict with coding standards, (well at least code formatting standards).  Especially since what is easy to read for one developer is hard for another.  It's kinda like a religious war, therer's no real point to it.

I'd rather be more concerned that people weren't adding XSS vulnerabilities, huge memory requirements, or were doing things in a database portable, translatable, and at least readable manner. 

We can give guidelines for example, on how to use dates in tables, how to avoid XSS vulnerabilities, how to write your queries in a database independant way for adodb.... efficient use of smarty, how to make your module translatable, how to minimize the amount of weird bugs by using DEFINES where ever possible, etc, etc.  and these are much more laudable goals than making sure everybody has their browsers set to tabs of 4, or where they put their opening brackets.

Re: Code cleanup...

Posted: Wed May 09, 2007 10:48 am
by cyberman
There exists a thread in the past, but I can't see any real results (docs or other) :( ...

http://forum.cmsmadesimple.org/index.ph ... 866.0.html