Page 7 of 21
Re: A new gallery manager : Album
Posted: Mon May 22, 2006 9:52 pm
by Elijah Lofgren
Greg wrote:
Almost perfect now -- thanks Elijah.
When I first open an album it lists 1 more photo than there is in the album.
e.g. Click on an album to display and the links show >>
when there are actually only 3 photos in the album.
Clicking the >> link which has a tooltip of 'last' takes me back to my home page.
After clicking on any thumbnail the number changes to the correct number >>
and the >> link takes me to the last photo in the album.
This is with version 12 of album.
Thanks for your bug report. If you would like you can use the Album bug tracker for reporting bugs. It is available here:
http://dev.cmsmadesimple.org/tracker/?a ... unc=browse
I have fixed this bug in the SVN version of Album revision 14.
If you want you can just replace modules/Album/action.default.php with this file:
http://viewsvn.cmsmadesimple.org/viewsv ... root=album
Edit: fixed URL.
Re: A new gallery manager : Album
Posted: Mon May 22, 2006 10:22 pm
by Greg
Thanks again Elijah !!!
Re: A new gallery manager : Album
Posted: Tue May 23, 2006 3:02 pm
by Russ
Elijah, first off, good work on the Album

especially clean url's!
I've been converting the template so that it gives 'photo' like results like the ImageGallery plugin and uses div's rather than tables. That way you don't have to worry about rows or columns as it just fits.
Anyway I'll get that posted here as soon as I resolve a few issues...
I notice on the $returnlink:
Back
it returns
http://localhost/cms/index.php?page=album
which doesn't seem to be a clean url? I would expect a 'clean url' link to the originating page?
Secondly, and related I guess to clean url's, the album is always from the root and not from the page which originates it. For example...
http://localhost/cms/album/1/70/
Now if the calling page, (the page the {cms_module module="album"} is on,) was '
http://localhost/cms/callpage' then I would expect the url to be:
http://localhost/callpage/album/1/70/
or perhaps just
http://localhost/callpage/1/70/
What do you think? Any ideas.
Russ
Re: A new gallery manager : Album
Posted: Tue May 23, 2006 4:03 pm
by Elijah Lofgren
Russ wrote:
Elijah, first off, good work on the Album

especially clean url's!
Thank you!
Russ wrote:
I've been converting the template so that it gives 'photo' like results like the ImageGallery plugin and uses div's rather than tables. That way you don't have to worry about rows or columns as it just fits.
Anyway I'll get that posted here as soon as I resolve a few issues...
That'll be cool. Thanks.
I can only reproduce this if $config['internal_pretty_urls'] = false;
Make sure you have this in config.php:
Code: Select all
$config['internal_pretty_urls'] = true;
Then return URL will become "index.php/album/" until this patch makes it in:
http://dev.cmsmadesimple.org/tracker/in ... 6&atid=103
Once the patch makes it in it will be "/album/" as long as you have the following set in config.php:
Code: Select all
$config['assume_mod_rewrite'] = true;
That is a very good idea! I asked Ted and it sounds like it would be doable. I've filed a feature request for that (
http://dev.cmsmadesimple.org/tracker/in ... 7&atid=728) and added it to my kdissert computer todo list. I'll hopefully get around to trying that soon.
Re: A new gallery manager : Album
Posted: Tue May 23, 2006 4:31 pm
by Russ
Thanks Elijah, I look forward to the fix.
Ted, are you there? I think the same would apply to the news module! The clean url always starts from the root, not the orginating page, this should be fixed.
Will this affect
1. Search ?
2. Site Maps?
Russ
Re: A new gallery manager : Album
Posted: Tue May 23, 2006 4:45 pm
by Elijah Lofgren
Russ wrote:
Ted, are you there? I think the same would apply to the news module! The clean url always starts from the root, not the orginating page, this should be fixed.
I've wanted to make it so that the URL for my blog could be /blog/vars instead of /news/vars.
I'm guessing that if I figure out how to do this for Album it probably won't be too hard to do this for the news module. If so, I'll probably submit patches for the News modules as well as patching Album.

Re: A new gallery manager : Album
Posted: Fri May 26, 2006 5:54 am
by zsero
Is there a switch (or can you make one, please

which controls whether the album is started in "logo" mode like now, or in "gallery" mode, as when you click on the starting thumbnail now? I just want to make it one more click easier, to be the absolutely easiest album modul on Earth!
And can somebody help me with that SVN stuff, should I use a freeware app, or there is some web back-end to download the source? When somebody makes a release version, it is just the actual SVN folder zipped into a tgz with a version number for it?
Re: A new gallery manager : Album
Posted: Fri May 26, 2006 7:58 am
by alby
zsero wrote:
And can somebody help me with that SVN stuff, should I use a freeware app, or there is some web back-end to download the source? When somebody makes a release version, it is just the actual SVN folder zipped into a tgz with a version number for it?
In "Project" -> SVN there is a link for:
Download The Nightly SVN Tree Snapshot
Alby
Re: A new gallery manager : Album
Posted: Fri May 26, 2006 9:26 am
by Mesmer
zsero wrote:
Is there a switch (or can you make one, please

which controls whether the album is started in "logo" mode like now, or in "gallery" mode, as when you click on the starting thumbnail now? I just want to make it one more click easier, to be the absolutely easiest album modul on Earth!

Insert this tag on any page: {cms_module module="album" albums="1"}. Note the albums="1" (1 is your album id) part.
If you do that is shows in 'gallery mode'.
Re: A new gallery manager : Album
Posted: Fri May 26, 2006 9:58 pm
by prefab
Hi Elijah,
I have installed version 0.30 and noticed the "total pictures" bug. I have downloaded the action.default.php and replaced it on my site. The page with the album covers worked as before but when I clicked on a picture to see the album it would simply display the albums list again. I looked inside and noticed your comment to correct the "total pictures", so applied that to the 0.30 action.default.php. Everything is now working perfectly. Thank you for this module.
cheers
Re: A new gallery manager : Album
Posted: Fri May 26, 2006 10:36 pm
by zsero
alby wrote:
zsero wrote:
And can somebody help me with that SVN stuff, should I use a freeware app, or there is some web back-end to download the source? When somebody makes a release version, it is just the actual SVN folder zipped into a tgz with a version number for it?
In "Project" -> SVN there is a link for:
Download The Nightly SVN Tree Snapshot
Alby
It gives me 404 error ...
Re: A new gallery manager : Album
Posted: Fri May 26, 2006 10:42 pm
by Dr.CSS
well page not found... but
try this...
http://viewsvn.cmsmadesimple.org/viewsvn/?root=album
it has updated files listed that you can download
mark
Re: A new gallery manager : Album
Posted: Fri May 26, 2006 11:35 pm
by Elijah Lofgren
zsero wrote:
alby wrote:
zsero wrote:
And can somebody help me with that SVN stuff, should I use a freeware app, or there is some web back-end to download the source? When somebody makes a release version, it is just the actual SVN folder zipped into a tgz with a version number for it?
In "Project" -> SVN there is a link for:
Download The Nightly SVN Tree Snapshot
Alby
It gives me 404 error ...
I've decided to release a new Album version so you don't need to grab the SVN to get the latest updates.
List of new fixes and features is in the changelog here:
http://dev.cmsmadesimple.org/frs/showno ... ase_id=474
Download the latest 0.4.0 version of Album here:
http://dev.cmsmadesimple.org/frs/?group ... ase_id=474
Please report bugs here:
http://dev.cmsmadesimple.org/tracker/?a ... unc=browse
Enjoy,
Elijah
Re: A new gallery manager : Album
Posted: Sat May 27, 2006 6:26 am
by Russ
Nice one Elijah Lofgren, have you got any further with my previous e-mail?
1. Return lInk problems...
Back
...then return URL will become "index.php/album/" until this patch makes it in:
http://dev.cmsmadesimple.org/tracker/in ... 6&atid=103
Once the patch makes it in it will be "/album/" as long as you have the following set in config.php:
Code:
$config['assume_mod_rewrite'] = true;
Did the patch make it in yet - if so what file?
2. Related clean url's, the album is always from the root and not from the page which originates it. For example...
...
http://localhost/callpage/1/70/...
Did this get done yet? I was thinking also it might be better to give galleries / albums names. It would make more sense in a url? e.g. ...
http://localhost/callpage/holidayfrance/1/...
I have some cool templates awaiting at least the first fix...
Russ
Re: A new gallery manager : Album
Posted: Sat May 27, 2006 6:52 am
by Elijah Lofgren
Russ wrote:
Nice one Elijah Lofgren, have you got any further with my previous e-mail?
Email? You mean post / bug report right?
Russ wrote:
1. Return lInk problems...
Back
...then return URL will become "index.php/album/" until this patch makes it in:
http://dev.cmsmadesimple.org/tracker/in ... 6&atid=103
Once the patch makes it in it will be "/album/" as long as you have the following set in config.php:
Code:
$config['assume_mod_rewrite'] = true;
Did the patch make it in yet - if so what file?
Yes it made it in. It was in the /lib/classes/class.module.inc.php file. Here's the file after the patch got in:
http://viewsvn.cmsmadesimple.org/viewsv ... iew=markup
Easier would just be to open /lib/classes/class.module.inc.php
and apply this small change:
On line 2,415 replace:
with:
$text .= $content->GetURL($config['assume_mod_rewrite']);
No, I haven't gotten around to it yet.

I've been really busy. I'll hopefully get to it eventually though.
