Content management as it is meant to be
https://forum.cmsmadesimple.org/
It's possible, but sadly I don't have time at the moment (homework).baselve wrote: Elijah, thanks for your great work. I have still one question.. Is it also possible that the xml/rss feed is feeded with the search engine friendly urls? At the moment the rss feed shows the "old" urls. Hope there is a solution for this, would be great!!
Thank you very much! Adding these lines does the trick!Elijah Lofgren wrote:It's possible, but sadly I don't have time at the moment (homework).baselve wrote: Elijah, thanks for your great work. I have still one question.. Is it also possible that the xml/rss feed is feeded with the search engine friendly urls? At the moment the rss feed shows the "old" urls. Hope there is a solution for this, would be great!!
I think if you open modules/News/action.rss.php there should be a call to CreateLink() that would match what was changed in action.default.php
Later,
Elijah
Code: Select all
$titleSEO = preg_replace("/[^\w-]+/", "-", $row['news_title']);
$categorySEO = preg_replace("/[^\w-]+/", "-", $row['news_category_name']);
$onerow->link = $this->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, '', $sendtodetail,'', true, false,'',true, 'News/'.$categorySEO.'/'.($detailpage!=''?$detailpage:$titleSEO.'-'.$row['news_id']));Code: Select all
[ISAPI_Rewrite]
# 3600 = 1 hour
CacheClockRate 3600
RepeatLimit 32
# Block external access to the httpd.ini and httpd.parse.errors files
RewriteRule /httpd(?:\.ini|\.parse\.errors).* / [F,I,O]
# Block external access to the Helper ISAPI Extension
RewriteRule .*\.isrwhlp / [F,I,O]
# Defend your computer from some worm attacks
RewriteRule .*(?:global.asa|default\.ida|root\.exe|\.\.).* . [F,I,O]
#RewriteCond Host: (.*)
#RewriteRule ([^.?]+[^.?/]) http\://$1$2/ [I,R]
#RewriteRule ^(.+)$ index.php\?page=$1 [I,L]
RewriteRule /([^/]+)\.html /index.php\?page=$1 [I,L]I'm sorry, I don't know Windows hosting nor the isapi thing. I'm used to httpd.conf and .htaccess.hadion wrote: My customer ordered windows hosting, ... isapi rewrite. ... httpd.ini ...
Use the version 3 of isapi_rewrite. It is almost 99% compatible with the Apache mod_rewrite.hadion wrote: Yeah i know linux is better. But my customer allready ordered the hosting before I started with the website. Everything works now, except the news module... Anyone who can help me?
Code: Select all
$onerow->titlelink = $this->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $row['news_title'], $sendtodetail, '', false, false, '', true, $prettyurl);
$onerow->morelink = $this->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $moretext, $sendtodetail, '', false, false, '', true, $prettyurl);
Code: Select all
// SEO URL Hack
$titleSEO = preg_replace("/[^\w-]+/", "-", $row['news_title']);
$categorySEO = preg_replace("/[^\w-]+/", "-", $row['news_category_name']);
$onerow->link = $this->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, '', $sendtodetail,'', true, false,'',true, 'News/'.$categorySEO.'/'.($detailpage!=''?$detailpage:$titleSEO.'-'.$row['news_id']));
$onerow->titlelink = $this->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $row['news_title'], $sendtodetail,'',false,false,'',true,'News/'.$categorySEO.'/'.($detailpage!=''?$detailpage:$titleSEO.'-'.$row['news_id']));
$onerow->morelink = $this->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $moretext, $sendtodetail,'',false,false,'',true,'News/'.$categorySEO.'/'.($detailpage!=''?$detailpage:$titleSEO.'-'.$row['news_id']));
// SEO URL HACK
// $onerow->titlelink = $this->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $row['news_title'], $sendtodetail, '', false, false, '', true, $prettyurl);
// $onerow->morelink = $this->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, $moretext, $sendtodetail, '', false, false, '', true, $prettyurl);
Code: Select all
$onerow->title = $row['news_title'];
Code: Select all
$this->news_title = $row['news_title'];
Code: Select all
function SetParameters()
{
Code: Select all
// SEO URL hack
$this->RegisterRoute('/(?P<module>News)\/.*?\/.*\-(?P<articleid>[0-9]+)$/', array('returnid'=>'133'));
$this->RegisterRoute('/[nN]ews\/(?P<articleid>[0-9]+)\/(?P<returnid>[0-9]+)\/d,(?P<detailtemplate>.*?)$/');
$this->RegisterRoute('/[nN]ews\/(?P<articleid>[0-9]+)\/(?P<returnid>[0-9]+)\/d,(?P<detailtemplate>.*?)$/');
$this->RegisterRoute('/[nN]ews\/(?P<articleid>[0-9]+)\/(?P<returnid>[0-9]+)$/');
$this->RegisterRoute('/[nN]ews\/(?P<articleid>[0-9]+)$/');
$this->RegisterRoute('/[nN]ews\/(?P<action>rss)\/(?P<category>.*?)$/', array('showtemplate'=>'false'));
Code: Select all
while ($dbresult && $row = $dbresult->FetchRow())
{
$onerow = new stdClass();
$sendtodetail = array('articleid'=>$row['news_id']);
$onerow->link = $this->CreateLink($id, 'detail', $returnid, '', $sendtodetail,'',true,false,'',true,'news/'.$row['news_id']);
$onerow->id = $row['news_id'];
$onerow->title = $row['news_title'];
$onerow->content = $row['news_data'];
$onerow->summary = $row['summary'];
$onerow->strippedcontent = strip_tags($onerow->content);
$onerow->strippedsummary = strip_tags($onerow->summary);
$onerow->postdate = $row['news_date'];
$onerow->gmdate = gmdate('r', $db->UnixTimeStamp($row['news_date']));
$onerow->startdate = $row['start_time'];
$onerow->enddate = $row['end_time'];
$onerow->category = $row['news_category_name'];
$entryarray[]= $onerow;
}
Code: Select all
while ($dbresult && $row = $dbresult->FetchRow())
{
$onerow = new stdClass();
$sendtodetail = array('articleid'=>$row['news_id']);
$titleSEO = preg_replace("/[^\w-]+/", "-", $row['news_title']);
$categorySEO = preg_replace("/[^\w-]+/", "-", $row['news_category_name']);
$onerow->link = $this->CreateLink($id, 'detail', $detailpage!=''?$detailpage:$returnid, '', $sendtodetail,'', true, false,'',true, 'News/'.$categorySEO.'/'.($detailpage!=''?$detailpage:$titleSEO.'-'.$row['news_id']));
//$onerow->link = $this->CreateLink($id, 'detail', $returnid, '', $sendtodetail,'',true,false,'',true,'news/'.$row['news_id']);
$onerow->id = $row['news_id'];
$onerow->title = $row['news_title'];
$onerow->content = $row['news_data'];
$onerow->summary = $row['summary'];
//$onerow->strippedcontent = strip_tags($onerow->content);
//$onerow->strippedsummary = strip_tags($onerow->summary);
$onerow->strippedcontent = $row['news_data'];
$onerow->strippedsummary = $row['summary'];
$onerow->postdate = $row['news_date'];
$onerow->gmdate = gmdate('r', $db->UnixTimeStamp($row['news_date']));
$onerow->startdate = $row['start_time'];
$onerow->enddate = $row['end_time'];
$onerow->category = $row['news_category_name'];
$entryarray[]= $onerow;
}
Found a bug.. the Pretty URL's won't work if you have the directive {news detailpage="pagealias"} switched on, you need to just use {news} on the News page - other then that, custom templates appear to work (as long as you follow the normal coding)carasmo wrote: I did it too a while back, but I couldn't get the templates to work. So only the default, any other wouldn't work.
Please share what you did.
Courty,Courty wrote: I've played with the spacing and code layout so you will have to look / search the files by hand, don't use an automated tool.
You will need the standard Pretty URL's .htaccess file and Pretty URL's already working for articles etc.
The hack also fixes the RSS feed for the new URLs's.
Both Old style URL's still work so SEO is not affected.
These files are from CMSMS version 1.2.3 "Black Rock" (upgraded from 1.2.2), on Apache and Red Hat with MySQL 5 back end (not that it should make a difference..)
I have not added the hack to take out the article number so URL's look like http://mysite.com/News/General/my-story-[b]12[/b].shtml, I did look at the code but it didn't work + I ran out of time to fix it.
if you want to see it working, have a look at http://www.avicraft.co.uk
Remember to make a backup of the files BEFORE you edit them, I normally copy the file to the same folder and append the date so action.default.php becomes action.default.php.210107, then edit the original file...
Let me know if you have a problem..
Regards
Courty
