Page 3 of 3

Re: Photo Gallery module

Posted: Sat Jan 07, 2006 11:19 pm
by Greg
Hi Piratos,

The template pipicslide.tpl works perfectly in both IE and Firefox.

Update:
I have the pipic.tpl working,  line 64 of function.PiPictures.php has an extra c in $pipic

Debug is showing the following errors:
Notice: Undefined index: extension in D:\AAAWeb\cms\plugins\function.PiPictures.php on line 111

Notice: Undefined index: comment in D:\AAAWeb\cms\tmp\templates_c\%%BC^BC2^BC21A3CB%%pipic.tpl.php on line 58

Notice: Undefined index: comments in D:\AAAWeb\cms\tmp\templates_c\%%BC^BC2^BC21A3CB%%pipic.tpl.php on line 59

Re: Photo Gallery module

Posted: Sun Jan 08, 2006 10:02 am
by Piratos
Line 111  is $endung=strtolower($path_parts['extension']); // only jpg are available for this plugin

// is an allowed comment in php


in ine 58 and 59 of pipic.tpl are no comments.

The only comment is in line 55 {* Show the thumbnails *} and this is an allowed smarty comment.

my debuggers ( with Xdebug v2.0.0beta5-dev, Copyright (c) 2002, 2003, 2004, 2005, by Derick Rethans    with DBG v2.11.32, (C) 2000,2005, by Dmitri Dmitrienko) shows no errors.

That must be a debugger issue by your debuggers

Re: Photo Gallery module

Posted: Sun Jan 08, 2006 1:32 pm
by Greg
Hi Piratos.

The notice errors are a result of the variables $comment and $comments being undefined. Nothing to do with code comments. These are supposed to pick up the comments embeded in the photo's exif - correct?

The code from lines 63 to 79 does not seem to be functioning correctly as $comments, $comment and $date are undefined when I try to print them from pipic.tpl

Code: Select all

$exif=false;
  if (function_exists('exif_read_data')) $exif = exif_read_data("$rooturl$one/$pipic");
  if ($exif)
  {
    $comment=$exif['COMMENT'][0];
    $comments=$exif['Comments'];
    $date=$exif['DateTime'];
  }
  $dimensions_x = getimagesize("$rooturl$one/$pipic");
  $o_width_ = $dimensions_x[0];
  $o_height_ =$dimensions_x[1];


  // assign the comments of the first picture to smarty
  $smarty->assign('comments',$comments); // the comment of the big one
  $smarty->assign('comment',$comment); // the comment of the big one
  $smarty->assign('date',$date); // the date of the big one

Re: Photo Gallery module

Posted: Sun Jan 08, 2006 2:45 pm
by Piratos
The code from lines 63 to 79 does not seem to be functioning correctly as $comments, $comment and $date are undefined when I try to print them from pipic.tpl
I have no problems with this. 

To test i am using very old pictures from a a CD of 1997 - no problems.

My cheapest Camera (20$) makes exif data too.

But it seems your test pictures have nothing of the values there are nomal in the exif, but exif returns true by you.

Try some normal pictures from your camera.

PiPictures 1.1 availalbe

Posted: Sun Jan 08, 2006 2:46 pm
by Piratos
This version can work with Simpleviewer (viewer.swf).

Template with full function is in the package.

Re: Photo Gallery module

Posted: Sun Jan 08, 2006 3:02 pm
by Greg
Picture just taken with Olympus 750 UZ and another from Fuji 2650 - neither picture shows any comments. I added comments directly from Windows explorer - Right click - properties - summary - completed all fields - no change.

Windows XP Apache 2.0.55 PHP 4.4.1 MySQL 4.0.26

Just a note - version 1.1 still has the error in line 78

  $dimensions_x = getimagesize("$rooturl$one/$picpic");

should be

  $dimensions_x = getimagesize("$rooturl$one/$pipic");

Re: Photo Gallery module

Posted: Sun Jan 08, 2006 6:07 pm
by Piratos
Oh shit ! ???

Re: Photo Gallery module

Posted: Sun Jan 08, 2006 6:14 pm
by Ted
lol

I must say that I applaud the simplicity of that answer.  :)

Re: Photo Gallery module

Posted: Sun Jan 08, 2006 7:05 pm
by Piratos
1.1a is ready without this typing error

Re: Photo Gallery module

Posted: Sun Jan 08, 2006 7:24 pm
by Piratos
Not all modern Cameras writes Exif Data.
Maybe you can it enable or disable it.
Here i have found a photo without any exif informations, the camera itself was a latest model.
I have set some informations with Windows XP right click

If you change this part  (line 72)
if ($exif )
  {
    $comment=$exif['COMMENT'][0];
    $comments=$exif['Comments'];
    $date=$exif['DateTime'];
  }
 
to this
if ($exif )
  { print_r($exif);
    $comment=$exif['COMMENT'][0];
    $comments=$exif['Comments'];
    $date=$exif['DateTime'];
  }

and click after the first view on the selected thumbnail you get informations
like this:

Array ( [FileName] => DSCN00011.jpg [FileDateTime] => 1136747235 [FileSize] => 20762 [FileType] => 2 [MimeType] => image/jpeg [SectionsFound] => ANY_TAG, IFD0, WINXP [COMPUTED] => Array ( [html] => width="338" height="450" [Height] => 450 [Width] => 338 [IsColor] => 1 [ByteOrderMotorola] => 0 ) [Title] => Titel [Comments] => Kommentar [Author] => Autor [Keywords] => Stichwort [Subject] => Betreff )

COMMENT and Comments and DateTime are specified by Exif-Organisation.

With the Windows XP right click the other Informations as width ehight are set by Windows automatically,.

Re: Photo Gallery module

Posted: Tue Jan 10, 2006 3:50 pm
by Piratos
Here http://piratos.byethost33.com you can see all templates in action.

Re: Photo Gallery module

Posted: Fri Feb 03, 2006 3:13 pm
by sydneysunshine
Moved post to General Support forum :)