AdvancedContent

Have a question or a suggestion about a 3rd party addon module or plugin?
Let us know here.
Locked

What do you think: Use the image uploads dir or just the uploads dir for {content_image}?

image uploads dir
23
68%
uploads dir
8
24%
don't care
3
9%
 
Total votes: 34

User avatar
NikNak
Forum Members
Forum Members
Posts: 183
Joined: Fri Oct 02, 2009 2:28 pm

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by NikNak »

Yes - the description param does this nicely - that is a great help and improvement on trying to use the label param to instruct users..

Hope we are not pounding you with feature requests - but here is something that may be easy to implement. (or not?)

When I have a series of image filepickers in succession, if the original images are large, showing the full size selected image rather than a thumbnail is becoming problematic in the back-end, making it difficult to navigate a long long page.

I'm thinking that perhaps the original image could be simply scaled in css using:
div.pageoverflow.AdvancedContent_ContentBlock img {width: 200px;}

Just a thought :-)

Nik
NaN

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by NaN »

Using a thumbnail or a scaled image instead of the original one is already on my todo list (for a long time i guess).
I just focused more on bugfixes instead of improvements.
That's why it isn't in there.
Should be no prob to add.
User avatar
NikNak
Forum Members
Forum Members
Posts: 183
Joined: Fri Oct 02, 2009 2:28 pm

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by NikNak »

Hi NaN

Using AC v0.4 on cmsms1.8.1 I am no longer able to modify Extra Page Attributes in the options tab.
If I return to normal content, I can update them again.

This is a bit of a problem for me, as I use these fields extensively.
Is it something done on purpose or a glitch?

EDIT: On a different instalation this doesnt happen - hang on - am experimenting!

Kind regards

Nik
Last edited by NikNak on Wed Jul 28, 2010 2:25 pm, edited 1 time in total.
NaN

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by NaN »

NikNak wrote:
Is it something done on purpose
Definitely not.
I did not touch the extra fields.
Did not realize this since i didn't use them until now.
I will have a look and report here later.

Edit...

First report: Confirmed. Isn't stored in DB. There might be an issue with handling the content props.
Last edited by NaN on Wed Jul 28, 2010 2:26 pm, edited 1 time in total.
User avatar
NikNak
Forum Members
Forum Members
Posts: 183
Joined: Fri Oct 02, 2009 2:28 pm

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by NikNak »

Sorry NaN

Am trying to get to the bottom of it - as it is happening on one installation and not another. Am a bit confused - will keep you posted. :-)
Kind regards
Nik
NaN

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by NaN »

I realized that it sometimes is stored and sometimes not.
On the same install.
Strange.

I created a new page, switched to AdvancedContent, entered some values to the extra fields, saved and it worked.
But when editing the page it won't work anymore.
You cannot change the values anymore you once stored.
Seems like it keeps the old values somehow.
Must have something to do with the content object.
If you enter the edit area the old values will be loaded.
If you save the page the whole content object is submitted with all its (previously loaded) properties. Somehow the props are not replaced by the submited input values.
I believe it is just the order of filling the props.
I will do some tests and report again.

Edit:

5 min later ;)

It really just seemd to be the order. I first filled the basic props and then filled the content type related stuff.
But when comparing to the code of the default content type it is done the other way. So i just swapped two lines of code and it seems to work :)

In file modules/AdvancedContent/contentype.Content2.php just swap the lines 177 and 178 from:

Code: Select all


parent::FillParams($params);
require(cms_join_path(dirname(__FILE__), 'inc', 'function.fillParams.inc.php'));

to

Code: Select all


require(cms_join_path(dirname(__FILE__), 'inc', 'function.fillParams.inc.php'));
parent::FillParams($params);

this should be all.
Last edited by NaN on Wed Jul 28, 2010 3:19 pm, edited 1 time in total.
User avatar
NikNak
Forum Members
Forum Members
Posts: 183
Joined: Fri Oct 02, 2009 2:28 pm

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by NikNak »

Hi NaN

I have uploaded .4.1 and was having terrible difficulties, with pages not submitting at all. After testing all sorts of things on fresh installations and with lots of hair pulling, I have realised there is probably (possibly) a problem using this module with Safari (on Mac in this instance). Standard content items submit in seconds whereas AdvancedContent items can take minutes or more often wont submit at all.

Perplexing - I wonder if you can duplicate this NaN? Anyhow - now I know the issue - I'll avoid Safari (it was generally working much faster than Firefox and My G5 cannot run Chrome).

EDIT: This all seems daft that it could not work properly on one browser - could it?

Thanks

Nik
Last edited by NikNak on Mon Aug 02, 2010 5:28 pm, edited 1 time in total.
NaN

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by NaN »

How many content blocks do you use?
I noticed something similar when using too much blocks.
But i'm afraid the issue is something different here.
I know it is slower than the default content type but it shouldn't be that slow.
(Anyway the performance i'm talking about has nothing to with the used browser but with the server and db speed)

EDIT:
tested browsers ...
- Safari 4.1 (G4 Mac OS X 10.4.11)
- Firefox 3.6.8 (G4 Mac OS X 10.4.11)
- IE 6 / IE 7 (Win XP)

works on all 4 browsers

tested php versions:
- 5.2.0-8+etch11
- 5.2.13
- 5.3.2

tested CMS versions:
- 1.6.x
- 1.7.x
- 1.8.x
- MLE



Did you just copy the files?
You need to do an upgrade (Extensions->Modules ...)
Try also to download again (i did some tiny changes) reupload the files and clear the cache.
Turn on debug in config.php and look for errors.
Last edited by NaN on Mon Aug 02, 2010 6:36 pm, edited 1 time in total.
JeremyBASS

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by JeremyBASS »

Hey there just thought I'd let you know there are a few issues..
1.)on the mulity select list block_type the style param is applied to the legend as well as the element it's self.. so if I want to have the box at let’s say 300px tall, the legend also goes to 300px... not so good..

on this tag..
{AdvancedContent  block_type="image" block_tab="Images" block="Main-Image" urlonly=true label="Main Image (Leave blank for the random pick)" assign=img  dir="images" filter="exclude:thumb_" style='width:350px;font: 700 14px Arial, Helvetica, sans-serif;color: #333;'}

the filter is not working anymore.. I think that is it.. well I think that personally in the help since you say that the filter is a csv that you should put an example. ie:

is it
filter="exclude:thumb_,exclude:foo"

or
filter="exclude:thumb_,foo"

just a thought.. ;)  Glad to see it's getting a little more stable. today was the first time I could skip using the last set of changes on the file I posted here and use and work with the module.. kutos.. Cheers -Jeremy
NaN

Re: improve the content type "content" - Content2 -> XContent -> AdvancedContent

Post by NaN »

Thanks for your feedback.

You don't need to exclude thumbs since this is excluded by default.
But anyway the CMSms core function to create the file dropdown actually does not accept multiple fileprefixes. It also does not accept exclude and include at once.
So i need to create an own module function to create the filedropdown.
The filepicker also does only accept exclude OR include at the moment. Not both filters.
So the filter is used this way:

filter="exclude:thumb_,foo,..."

or

filter="include:thumb_,foo,..."

I see... there is still some work to do... :)
NaN

AdvancedContent

Post by NaN »

@NikNak:
There is a memory issue with 0.4.1 that causes a "memory exhausted" error. This mostly appears if you enable/disable the WYSIWYG editor in the options tab or if you just change the template.
Since CMSms puts the whole content object as serialized content in a hidden input field of the edit form it may also affect your browser.

In SVN this is already fixed and seems to work faster now.
If anyone don't know SVN use this version: LINK
Last edited by NaN on Wed Aug 11, 2010 6:06 pm, edited 1 time in total.
User avatar
NikNak
Forum Members
Forum Members
Posts: 183
Joined: Fri Oct 02, 2009 2:28 pm

Re: AdvancedContent

Post by NikNak »

Cheers NaN
I now get
Fatal error: Call to a member function GetThumbnail() on a non-object in /modules/AdvancedContent/inc/function.displayContentBlocks.inc.php on line 189

EDIT: Just changed back to the old module and now get:
Fatal error: Call to a member function GetModuleInstance() on a non-object in /modules/AdvancedContent/contenttype.Content2.php on line 481

Oh lordy - I cant edit anything now!  :-(

I have cleared the cache - any ideas?

EDIT 2:
In the page list where it should say 'advanced content' as the page type it says:
ModuleName() not defined properly

I cannot get the Advanced Content module page to open either.

Edit 3
I have restored an old database and I can now edit pages again - but am curious to know what went wrong here?

Regards

Nik
Last edited by NikNak on Thu Aug 12, 2010 2:58 pm, edited 1 time in total.
NaN

Re: AdvancedContent

Post by NaN »

Mee too  :o
Sounds very bad.
I cannot reproduce this.

Other users told me it works.

So what PHP version do you use?
And what CMS version?
Currently tested with 1.8.1 and PHP 5.2.13 and works fine.

All files uploaded without error?

Did you also clear the browser cache?

Since CMSms puts the whole content object as serialized content in a hidden input field of the edit form it may also affect your browser.
So maybe the old stuff was still in your browser cache.
Not sure about this.

One note to all users:
Because this is a content editing tool that can completeley mess up your site inofficial links provided here in the forum are only for testing purposes. Don't use them on a live site unless you can be sure it will run in your live site environment.
Last edited by NaN on Thu Aug 12, 2010 10:14 pm, edited 1 time in total.
User avatar
NikNak
Forum Members
Forum Members
Posts: 183
Joined: Fri Oct 02, 2009 2:28 pm

Re: AdvancedContent

Post by NikNak »

I tried in a couple of browsers but didn't clear the browser cache - only the cms cache.
Im using cms 1.8.1 and php  5.2.13

I'll test again soon when I'm fully prepared for a rollback (which I wasn't entirely before).

Thanks

Nik
NaN

Re: AdvancedContent

Post by NaN »

Pre 0.5 TEST release can be downloaded here.

Please read the changelogs and (english) documentation for detailed infos.
Other languages might be not up to date.
Locked

Return to “Modules/Add-Ons”