CMS Made Simple Forums

tonyg wrote: I think I see the problem. In action.default.php on Line 29, Elijah uses

Code: Select all

preg_replace('/\{cms_module module=.*?\}/'

to parse the cms module tag, which is fine. But he does not look for or parse any other CMS tags in the page. So if a page with a CMS album tag also has a CMS selflink tag, that tag is not parsed and is then printed to the page as text by Album. It would be a bit limiting if we cannot use other CMS tags on album pages.

tonyg wrote: Actually, I believe you are trying too hard in some ways, Elijah. I don't know about other people, but I don't really need image paging or integrated photo display. I am happy just to display thumbnails and have a self-configuring stripped popup window display the full photo.

tonyg wrote: Also, I suspect the crazy URLs I am seeing are caused by Line 14 where Elijah uses

Code: Select all

$page_alias = substr(substr($_SERVER['REQUEST_URI'], 1), 0, strlen($_SERVER['REQUEST_URI']) - 2);

I think it's picking up too much of the string (i.e, it is replicating "/cms/index.php" when it doesn't need to.

tonyg wrote: Would that also be cause other CMS links to be displayed in the page? All of a sudden, my internal page links are also being printed instead of converted to links, so I suspect there is more to this than your code change. But it's only happened since I went to Album 0.51.

You can see what I mean at www.brisbanebikers.com/cms/ near the album thumbs at the bottom of the page.

Elijah Lofgren wrote:

tonyg wrote: Also, any idea what is causing the strange URLs (e.g. /cms/index.php/cms/index.php/photo_gallery/three_dams_ride_200/album-5/22/34)?

Should be fixed in the latest SVN version of Album: http://viewsvn.cmsmadesimple.org/viewsv ... m&view=rev

I removed all that "hackish" code that was getting the page_alias out of the URL and replaced it with a database query to get the 'hierarchy_path' of the page calling Album

Please test and see if the URLs are fixed by downloading "action.default.php" from here http://viewsvn.cmsmadesimple.org/viewsv ... iew=markup

Thanks,

Elijah

tonyg wrote: Installed the SVN version of action.default and it has fixed the URL problem. Thanks.

The {CMS_selflink} is still an issue, of course. Any idea how to deal with that? Is there standard parsing code somewhere else that could be copied across and added into action.default?

Tony

Elijah Lofgren wrote:

tonyg wrote: Would that also be cause other CMS links to be displayed in the page? All of a sudden, my internal page links are also being printed instead of converted to links, so I suspect there is more to this than your code change. But it's only happened since I went to Album 0.51.

You can see what I mean at www.brisbanebikers.com/cms/ near the album thumbs at the bottom of the page.

Fixed in latest SVN: http://viewsvn.cmsmadesimple.org/viewsv ... m&view=rev

Thanks to calguy100 I found out about the ProcessTemplateFromData() function. Running the page content through that converts the {cms_selflink page='33' text='More ride photos'} tags into links correctly. Any other smarty tag (except the stripped {cms_module} ones) should be correctly converted also. 

Just download this file http://viewsvn.cmsmadesimple.org/viewsv ... iew=markup and replace your current modules/Album/action.default.php file with it.

If you don't want the page content shown above the pictures, update all Album files to latest SVN and then go to the "Options" tab of Album and uncheck the box next to "Check to show the content of the page which Album is called above all pictures. You'll want to turn this off if you have other smarty tags on the page where you put the Album smarty tag.:"

I think these changes should fix the problems you have reported.

Thanks for reporting these bugs, let me know if you find any other problems.

Later,

Elijah

Elijah Lofgren wrote: Hi Tony,

It's been fixed. Check my last post (quoted at the bottom of this post.
If it doesn't work for some reason (my test shows it does work now), please let me know and I'll try to fix it tomorrow.
Make sure you use the latest version of action.default.php available from here: http://viewsvn.cmsmadesimple.org/viewsv ... iew=markup

Good night,

Elijah

slloyd wrote: Can we see it in action? I'd like to see how people are using the Album module.

slloyd wrote: How difficult is it to get it uploaded and working? Are there specific instructions somewhere about how to install it and get it working?

{cms_module module="album"}

mark wrote: it's supposed to make it's own imageData.xml....
i haven't got it to work like that...: but :..>
http://www.multiintech.com/index.php?page=bob_seger_vid
under the Bob Seger video