CMS Made Simple Forums

I'll get calguy to explain it properly, but the warnings about parameters are intentional.  They're a little nudge for the module developers to get on board with the changes we've made.

Two other things I notice in "Content -> Pages".

- "re-order pages" isn't aligned besides "Add new content", but a line lower and to the right.
- In earlier releases I couldn't delete a parent, if I didn't delete the childs first (no trash-bin was shown). Now there still is no trashbin visible at a parent with childs, but the delete works through all levels down. I would expect a trashbin at the parent-level.

Also an error in the backend of the installed guestbook, which was installed after installation of CMS1.1. The error occurred after having entered a test-entry, through the frontend.

Warning: vsprintf() [function.vsprintf]: Too few arguments in /******/lib/translation.functions.php on line 62

I also checked the default package and TinyMCE is not included in the zip-file.

Ronny

Okay..... for informations sake....

Modules like Banners, PiSearch, FeedBackForm, FormBuilder, .... are not part of the core, and messages produced by them are not things we should be concerned about in the core.  They're third party modules.

As a follow up to that, the reason they are generating these messages are twofold:
  i) There is new functionality in the module API to attempt to prevent against any potential XSS exploits, and these
      modules aren't exercising this functionality.  If the module exercises these functionalities (like News and
      MenuManager do), then no warnings are generated.
      New versions of all modules will have to be released that uses this new functionality,
  ii) There is a toggle in the site preferences where you can shut these warnings off, and you haven't done that yet.
      (this toggle will probably be reversed when the final release comes out so that we aren't swamped by people reporting these 'false' errors.).

Ok... sounds good.

One suggestion, and you may have already done this with your explanation to some degree, but can we put a sticky, prominently placed note somewhere with some general instructions for module makers concerning how they can most easily and/or properly update modules to be inline with the new release?

Also... quick edit... but will the basic fixes to modules necessary for 1.1 be basically the same for 2.x? I think module makers would be more apt to release new versions if they were confident that they would work for 2.x as well.

I'm considering starting a new forum or a thread (haven't decided yet) that will be about module development tricks and tips, and will be heavily moderated.  In that, I would insert the stuff about the new functionss that should be called, and how, and why.

Secondly, it is the intention (but no guarantees) that all modules compatible with the 1.x series should work with the 2.0 series.  though maybe they aren't as efficient as they could be.  So, lets all keep our fingers crossed.

When backward compatibility is broken, what usualy happens is that the core developers make a decision that they think is important to the over all safety and/or the continuation of the product.  Sometimes this means that all modules have to be tweaked in a minor way, or occasionally some modules have to be overhaulled.  But, this is usuallly good for the product as a whole.  We try to avoid it, but sometimes for the purposes of the continuation of the product, or for site security, ugly decisions have to be made that can break backward compatibility,

I do believe security is more important then compatibility, all "most-used" modules are pretty well updated so its only a mather of time before most widely used modules are compatible with the 1.1 (and maybe the 2.0).

But the core module Search is also giving the Param error though, but that will probably be fixed before releasing the final 1.1

HI,

I am in French language, and have the same problems reported in bug  1508

Thanks

I still got this problem:

Warning: WARNING: Search is not properly cleaning input params. in /home/michael/domains/rapdiss.nl/public_html/lib/classes/class.module.inc.php on line 1500


I have Rc2 but I keep this warning!

Did you uncheck the last box in the global settings, which makes sure that no messages are shown.

Ronny

RonnyK wrote: Did you uncheck the last box in the global settings, which makes sure that no messages are shown.

Ronny

Now it's gone 
But the warning still excist, but only not showing anymore? 

Correct,

as I understood from the reply from Calguy a little earlier in this topic, the adjustments made to the core need to be reflected in the different modules. As the modules aren't changed for the 1.1 release yet, the message is still there, but surpressed. When the modules are "upgraded" to work with 1.1 they should function without warning.

Ronny

I'll be fixing the search thing later today, it'll be out in the final release.

Okay, we haven't heard much about the release candidate in the last few days.  That either means that this release is perfect and has no other new bugs (unlikely), or that nobody is testing the release candidate (very likely).

Please keep in mind, that it is our intention to focus all of our efforts after the 1.1 release into 2.0.  As well, we'll probably be hesitant to jump to answer posts about 'a new bug found in 1.1' when we've put alot of effort (both in development and testing) into the 1.1 release, asked for assistance, and not gotten much for responses.  (My apologies to the people who have reported issues in the release candidate already).

We plan on releasing 1.1 later this week.... and hope that as many people as possible will test on their development or staging sites (NOT their production sites).  At this point in time, it is largely the communities responsibility to ensure that the 1.1 release is stable, and largely error free.

To instill confidence in the development team, and the rest of the community, if you don't find a problem please report that too.

Aside from the stuff already mentioned and explained, the release candidate seems to work fine for me.

Well, I honestly cant find any bugs in the core either, everything works, I like the way template editing and saving works now, the scrollbar stays in place, really cool feature!

1. One thing I noticed is a Dutch translation mistake, in the dropdown selecting news categories, in content -> news
Where should be listed "Alle categorieën"  the "ë"  shows up as html code.

2. RSS error:

Only thing i got errors with is the NewsFeed when trying to get the feed this error is in the xml file, which makes my rssreader dont wanna have it:

#

# Warning:  Parameter showtemplate is not known... dropped in /home/mysite/public_html/beta/lib/misc.functions.php on line 1228



Thats all I could find