Ellnav -- Firefox--fine IE--errors?

[roastedmnm]

(Don't you just hate first posts that are just problems Sorry.)
After installing Ellnav and getting all the formatting correct, I asked a friend to look at my design. When they took a look they used IE (whereas I use firefox). The problem is that IE seems to break the formatting for example

Firefox
# Menu level 1a

    * Menu level 2a
    * Menu level 2b
          o Menu level 3a
          o Menu level 3b

# Menu level 1b
# Menu level 1c

IE
    # Menu level 1a

* Menu level 2a
* Menu level 2b
    o Menu level 3a
    o Menu level 3b

    # Menu level 1b
    # Menu level 1c

I know that I could differentiate between the levels with some font formating of some kind but I really don't think that I need to. I see that others have this working properly so I figure that it has something to do with my configuration.

Edit: Forgot the HTML generated

Code: Select all

<ul class="menu_vert" id="leftmenu">
     <li class="active"><a class="active" href="http://...">Menu level 1a</a>
        <ul>
            <li><a href="http://...">Menu level 2a</a>  
            <li class="active"><a class="active" href="http://...">Menu level 2b</a>
                <ul>
                    <li class="current"><a class="current" href="http://...">Menu level 3a</a>
                    <li><a href="http://...">Menu level 3b</a>   
                </ul>
        </ul>
     <li><a href="http://...">Menu level 1b</a> 
     <li><a href="http://...">Menu level 1c</a>
</ul>

Any suggestions?

roasted

[Ted]

Where are all the ?  Is this what ellnav is generating?

sjg: this is all you, buddy. 

[roastedmnm]

I kind of wondered where the 's were but I figured that it was some sort of short hand that I didn't know.

Edit: I just checked the original generated results because I cleaned up the the code as it is a mess (not complaining ) but I accidentally deleted an when I was aligning the results so it was legible to me. There was only one missing though:


    Menu level 1a
       
            Menu level 2a
            Menu level 2b
               
                    Menu level 3a
                    Menu level 3b 
               
       
    Menu level 1b
    Menu level 1c



roasted

[sjg]

Damn.

My code sucks.

Time for me to rewrite EllNav. I'll fix the HTML, and I'll optimize the database portion.

I'll post an update when I have something new posted on the Wiki.

Sorry!
___Samuel___

[roastedmnm]

...
My code sucks.
...
Sorry!
___Samuel___

I beg to differ. It is just perfection challenged.

... Oh and who cares about IE anyway .

Really though, if you just modify it to add the line ending tags it would work fine.

roasted

[sjg]

Well, the easy fix is to find the section that looks like:

Code: Select all

if ($skipping)
    {
   $retStr .= "</li>\n";
   }

and just remove the if statement and the braces so it reads

Code: Select all

 $retStr .= "</li>\n";

and I think that'll fix that problem

But I'm also rewriting how it accesses the database. The current approach requires three queries plus one query per page in the hierarchy of the currently selected section of the site. The new approach will require only a single query, although it'll use up more memory. I think it'll be much faster...

Take it easy,
___Samuel___

[sjg]

OK. So there's a new version on the Wiki at http://wiki.cmsmadesimple.org/tiki-inde ... ed+Modules

It fixes the IE problem, and adds database optimizations.

Please let me know if you run into any problems with it.

Thanks,
___Samuel___

[Ted]

Wow.  That was fast.  At least someone around here is being productive. 

I wish I could say the same for myself....

[roastedmnm]

My, how I hate to say this. It looks all pretty with the but it appears that IE still breaks the formatting. This is the straight sample.

FF


IE


On the other hand you achieved a speed increase (I think, I will have to check the "generated" line before and after upgrade).

roasted

[fadum]

hi, ive just upgraded to your new 0.5 ellnav and the left menu doesnt appear any more just the horiz menu shows? shame ive had to go back to 0.3 and all the queries

other than this its an excellent mod! i love it, thanks for your hard work

Cheers

[roastedmnm]

After looking at .5 more I have discovered that it does not show any sub-links for any top level link but the first (i.e. "Home Page").

roasted

[sjg]

Drat. I thought I'd tested everything. I was testing under 0.10, so maybe I need to test under 0.9x as well, although I can't see how that would make a difference. HTML Tidy seems to think it's correct html.

Tomorrow, I have to deal with a dead car and a failed hard drive, and then I'll track down the new bugs. I think this Friday the 13th luck has stretched out over the whole weekend.

In any case, I'll try to have something by late Monday.

___Samuel___

[sjg]

Hm. earlier I posted that I wasn't actually going to get to this tonight, but I skipped out on other responsibilities, and made some fixes.

Version 0.5.1 is now posted in the Wiki. It should fix some of the bugs reported earlier.

I haven't tested under IE, except for IE 5.2/Mac OS 10.4. I'll test tomorrow under IE 6/Win2k. The HTML it generates does validate (at least under XHTML 1.0 Transitional) with Tidy; I also removed some newlines that I have heard interfere with IE's stylesheet code.

Please post here if you encounter any bugs in the new version, and I'll do what I can to take care of 'em.

I'm particularly interested in whether or not the URL encoding with special characters in page names works.

Thanks,
___Samuel___

[fadum]

Just upgraded and the first thing i noticed, im using the modrewrite address option and ive lost the .shtml in the links:

htp://www.example.com/page.shtml

now

htp://www.example.com/page

i added $config["page_extension"] to the config file which sorted it, may be as im using 0.9

Cheers

[roastedmnm]

Ah Ha!

I discovered the source of the IE bug. In the sample CSS file you provide, you have the following line:

Code: Select all

.menu_vert { display: inline; text-decoration: none; }

This is causing IE to display the top level menu options in the vertical menu in the odd position. The fix is to simply remove the display: inline command.

Thus, this works properly

Code: Select all

.menu_vert { text-decoration: none; }

roasted