Banners Module

[Remmy]

Hey,
First of all, nice module!

But... Some strange problem appears at my pc, in IE everything works fine after editing line 1639 of Banners.module.php to:

Code: Select all

	$image = '<img src="./uploads';

The problem with the database error appeared to be caused by it also
Perhaps some more sophisticated error notifications could help when this happens to other users...

Anyway, the problem seems solved in IE, but strangely not entirely in Firefox. Only the alt text is shown, when i manually add an image, it is displayed correctly. The problem seems to be caused by the link URL, when inserting the link manually (copying it from the generated source code) it also only shows the alt text. Is this a FF bug, or is the link URL not generated entirely correct and is IE smarter than FF in interpreting it?

[tsw]

IE will allow lousy code to be rendered corretly so I would bet that the source isnt generated correctly. got url?

[calguy1000]

The banners module needs some serious work......  it doesn't work as nicely as I would want, but haven't had a problem with the urls.  this is wird.

[Remmy]

I don't get it correctly either, but the generated code is:

Code: Select all

<!-- Begin Banner Output -->
<a href="http://localhost/cms/index.php?mact=Banners,cntnt01,link,0&cntnt01banner_id=1&cntnt01category_id=1&cntnt01returnid=15">
<img src="./uploads/images/kde_adv.gif" width=288" height="90" alt="Banner"/></a>
<!-- End Banner Output -->

Some manual testing shows that FF isn't able to cope well with the piece of the URL starting with the first ampersand. Isn't it possible to generate some link comparable to the News module ie

Code: Select all

http://localhost/cms/index.php/news/1/29

[djkirstyjay]

Hi, I am wondering how you get the banners to open in a new window... I tried sticking the target="_blank" in the URL field by putting the following... http://www.thedomainname.com" target="_blank assuming that the program would put in the around it as suggested earlier in this thread, but I just get a 404 error when I click the banner...

Any suggestions?

I'm using version 2.0.7 and it says earlier in the thread that this would be included in 2.0.2. Is there something I'm missing?

Thanks.

[badhoy]

You would place

target="_blank"

in the Link Text input line for each individual banner.

It took me some playing around to get this right because the documentation isn't real clear.

[djkirstyjay]

You would place

target="_blank"

in the Link Text input line for each individual banner.

It took me some playing around to get this right because the documentation isn't real clear.

Hmmm. That doesn't work either.   I've current tried adding the following :

" target="_blank
target="_blank"
" target="blank"

None work. It works when I don't stick it in, by the way, so it's not the URL that's wrong!!!

Can't it be hardcoded in the banner module? If so, does anyone have an idea where?

[rancov]

I am curious, I installed the Banners module in my testbed , but I do not see any options on the configuraqtion page for "rotation" of "#clickthrus" etc.  only for "categories", "banners" and "preferences".  Does this sound right?  I have seen thsi functionality in other  CMS and it seems there is more functionality to make this completely useful.

[calguy1000]

Banners module now (in SVN) does add rotation, instead of just randomly selecting a valid module.  But it does it only on each page request.

what did you mean by #clickthrough,  Banners tracks each click,  and allows you to specify the url to click through to....

[okulyth]

Sorry, but back to this

Error!
Error: Database Error!

issue. this is also occuring on my new project www.somersetwest.net/dev (see banner block on the right)

I am using CMSMS 0.13 and Banners 2.0.7, I set up a categorie 'general' and added two banners that I uploaded via file manager to /upload/banners/filename.gif

on the page I postet {cms_module module='Banners' category='general'} in the content block 'Rechte Spalte'.

gave a name
gave a description
gave a path 'banners/filename.gif' (tried also '/banners/filename.gif', but didn't helped)
gave a url 'http://www.someurl.com'
no linktext
gave Alt Image Text
Max Impression '0'
Expires 'never'

What am I doing wrong? Like some other fellas here, I desperately would like to use this module!!! Any suggestions? Thanks for helping!

[calguy1000]

well, I just checked the code.... and there are only two ways that the "Database Error" message gets generated.

a) it couldn't find the category when looking by it's name, so that means a possible error in your tag on your page/template

b) there are no valid objects to display.... either they've reached their maximum impressions, or they have expired.

The next version will display a more informative message.

[okulyth]

Got the clue: Dummy pixelpusher was not able to paste the tag in the textfield in a proper way, should have used the 'source' view for that instead of just pasting in the wysiwyg text field ...

Thanks for helping me anyway. No there is only that & thing to solve ...

[Lord Stanley]

Hi,

I'm getting a little problem using Banners Module : this one has been (I guess) correctly configured, but instead of displaying a banner on my pages, there is the following error message :

"Error!

ERROR: Could not find category (no rows) Error: Database Error!"

In the banners administration, I set up a "banners" category and upload a banner in /uploads/banners path.

My server runs Apache 2.0 ans mysql 4.1.10.

I have several modules installed :
- Banners 2.1.0,
- Calendar 0.7.8,
- CMSMailer 1.73.10,
- Comments 1.8.0,
- CustomContent 1.4.6,
- FCKeditorX 1.0.5,
- FrontEndUsers 1.2.0,
- Guestbook 1.1.9,
- MenuManager 1.3,
- ModuleManager 1.1.4,
- News 2.2,
- nuSOAP 1.0.1,
- Search 1.2,
- ThemeManager 1.0.8.

All these modules were installed by default or using the Module Manager.

Many thansk for the help 

[niedermayer]

Don't know if this is the best way to place a bug and the fix.

I've had a problem with banners not expiring when they should. According to this post http://forum.cmsmadesimple.org/index.php/topic,11371.0.html the dbTimestamp() returns a quoted string, which puts a extra quote on that clause. The solution to the problem si to remove the \" that surrounds this function (line 79) in the file action.default.php. The banners will then expired when the current time has passed the expiry date.

cmsms version 1.0.6
banners 2.1.0

[rhysdavies]

Hi,

I'm getting a little problem using Banners Module : this one has been (I guess) correctly configured, but instead of displaying a banner on my pages, there is the following error message :

"Error!

ERROR: Could not find category (no rows) Error: Database Error!"

In the banners administration, I set up a "banners" category and upload a banner in /uploads/banners path.

My server runs Apache 2.0 ans mysql 4.1.10.

I have several modules installed :
- Banners 2.1.0,
- Calendar 0.7.8,
- CMSMailer 1.73.10,
- Comments 1.8.0,
- CustomContent 1.4.6,
- FCKeditorX 1.0.5,
- FrontEndUsers 1.2.0,
- Guestbook 1.1.9,
- MenuManager 1.3,
- ModuleManager 1.1.4,
- News 2.2,
- nuSOAP 1.0.1,
- Search 1.2,
- ThemeManager 1.0.8.

All these modules were installed by default or using the Module Manager.

Many thansk for the help 

Same problem here, any ideas?