[closed]Installer:single quote will break JavaScript in Fr
Forum rules
Only administrators can post or move items here.
Only administrators can post or move items here.
[closed]Installer:single quote will break JavaScript in Fr
Hi,
if a lang string have single quote
(ex : ... au panneau d\'administration ...
the message is not displayed
if the lang string is : au panneau administration
the message is displayed
so the lang string are used into the files :
in app/wizard/class.wizard_step9.php
- all the string $lang['finished_
in app\wizard/class.wizard_step7.php
- $lang['install_extractfiles'] --> OK in SVN 116
in app/templates/index.tpl
- $lang['confirm_freshen']
- $lang['confirm_upgrade']
if a lang string have single quote
(ex : ... au panneau d\'administration ...
the message is not displayed
if the lang string is : au panneau administration
the message is displayed
so the lang string are used into the files :
in app/wizard/class.wizard_step9.php
- all the string $lang['finished_
in app\wizard/class.wizard_step7.php
- $lang['install_extractfiles'] --> OK in SVN 116
in app/templates/index.tpl
- $lang['confirm_freshen']
- $lang['confirm_upgrade']
Jean-Claude Etiemble
Re: [open]Installer:single quote will break JavaScript in Fr
In last SVN 114
same problem with "send_admin_email" OK in SVN 116
line 96 \app\wizard\class.wizard_step9.php
If the lang file is
$lang['send_admin_email'] = 'Envoyer les informations d\'identification par email pour la connexion d\'administration';
the message is not displayed on step9
If the string is
$lang['send_admin_email'] = 'Envoyer les identifiants par email pour la connexion Admin';
the message is displayed on step9
same problem with "send_admin_email" OK in SVN 116
line 96 \app\wizard\class.wizard_step9.php
If the lang file is
$lang['send_admin_email'] = 'Envoyer les informations d\'identification par email pour la connexion d\'administration';
the message is not displayed on step9
If the string is
$lang['send_admin_email'] = 'Envoyer les identifiants par email pour la connexion Admin';
the message is displayed on step9
Jean-Claude Etiemble
-
- Support Guru
- Posts: 8169
- Joined: Tue Oct 19, 2004 6:44 pm
- Location: Fernie British Columbia, Canada
Re: [open]Installer:single quote will break JavaScript in Fr
should be fixed now.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
Re: [open]Installer:single quote will break JavaScript in Fr
Rev 116 Not OK forshould be fixed now.
in app/templates/index.tpl
- $lang['confirm_freshen']
- $lang['confirm_upgrade']
EDIT
Not OK for
in app/wizard/class.wizard_step9.php
- all the string $lang['finished_
OK for
in app\wizard/class.wizard_step7.php
- $lang['install_extractfiles']
Jean-Claude Etiemble
Re: [open]Installer:single quote will break JavaScript in Fr
Rev 116 OK for this string
line 96 \app\wizard\class.wizard_step9.php
$lang['send_admin_email'] = 'Envoyer les informations d\'identification par email pour la connexion d\'administration';
line 96 \app\wizard\class.wizard_step9.php
$lang['send_admin_email'] = 'Envoyer les informations d\'identification par email pour la connexion d\'administration';
Jean-Claude Etiemble
Re: [open]Installer:single quote will break JavaScript in Fr
to temporarily correct the problem
- $lang['confirm_freshen']
- $lang['confirm_upgrade']
and all the string $lang['finished_
are translated into French by replacing the ' (apostrophe) with the ' (right single quote)
- $lang['confirm_freshen']
- $lang['confirm_upgrade']
and all the string $lang['finished_
are translated into French by replacing the ' (apostrophe) with the ' (right single quote)
Jean-Claude Etiemble
-
- Support Guru
- Posts: 8169
- Joined: Tue Oct 19, 2004 6:44 pm
- Location: Fernie British Columbia, Canada
Re: [open]Installer:single quote will break JavaScript in Fr
With the latest snapshot built phar-installer I could not reproduce this problem.
I used the .phar file in 'freshen' mode, in French, on an existing 2.0-beta2 install, and watching the javascript console for errors. The confirmation messages appeared just fine and no javascript errors were encountered.
I used the .phar file in 'freshen' mode, in French, on an existing 2.0-beta2 install, and watching the javascript console for errors. The confirmation messages appeared just fine and no javascript errors were encountered.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
Re: [open]Installer:single quote will break JavaScript in Fr
as you see on the post aboveWith the latest snapshot built phar-installer I could not reproduce this problem.
Code: Select all
to temporarily correct the problem
- $lang['confirm_freshen']
- $lang['confirm_upgrade']
and all the string $lang['finished_
are translated into French by replacing the ' (apostrophe) with the ' (right single quote)
and you won't have any messages
- $lang['confirm_freshen']
- $lang['finished_
Jean-Claude Etiemble
-
- Support Guru
- Posts: 8169
- Joined: Tue Oct 19, 2004 6:44 pm
- Location: Fernie British Columbia, Canada
Re: [open]Installer:single quote will break JavaScript in Fr
fixed in svn, thanks.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
Re: [open]Installer:single quote will break JavaScript in Fr
sorry not, the French language is not easy
test with Rev 122
with $lang['confirm_freshen']='Êtes-vous sûr(e) de vouloir rafraîchir l\'installation existante de CMSMS ?'; // ' (apostrophe)
freshen : '{'confirm_freshen'|tr|escape}' shows
Êtes-vous sûr(e) de vouloir rafraîchir l'installation existante de CMSMS ?
so not correct it would be
Êtes-vous sûr(e) de vouloir rafraîchir l'installation
and the $lang['finished_ are not displayed besause the problem is on the set_block_html('bottom_nav'
test with Rev 122
with $lang['confirm_freshen']='Êtes-vous sûr(e) de vouloir rafraîchir l\'installation existante de CMSMS ?'; // ' (apostrophe)
freshen : '{'confirm_freshen'|tr|escape}' shows
Êtes-vous sûr(e) de vouloir rafraîchir l'installation existante de CMSMS ?
so not correct it would be
Êtes-vous sûr(e) de vouloir rafraîchir l'installation
and the $lang['finished_ are not displayed besause the problem is on the set_block_html('bottom_nav'
Jean-Claude Etiemble
-
- Support Guru
- Posts: 8169
- Joined: Tue Oct 19, 2004 6:44 pm
- Location: Fernie British Columbia, Canada
Re: [open]Installer:single quote will break JavaScript in Fr
should now be fixed... I call addslashes instead of escape.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
Re: [open]Installer:single quote will break JavaScript in Fr
1/2 solved in rev 125
Ok the the $lang['confirm_freshen']
tha'ts fine
But not for the set_block_html
the $lang['finished_ are not displayed
so the the JavaScript break the output.
The ' (right single quote) into our translation works and
I suggests to leave out this problem at the moment.
Try later afert the beta2.
Ok the the $lang['confirm_freshen']
tha'ts fine
But not for the set_block_html
the $lang['finished_ are not displayed
so the the JavaScript break the output.
The ' (right single quote) into our translation works and
I suggests to leave out this problem at the moment.
Try later afert the beta2.
Jean-Claude Etiemble
Re: [open]Installer:single quote will break JavaScript in Fr
is this fixed in 2.0, JC?
- + - + - + - + - + - + -
LATEST TUTORIAL AT CMS CAN BE SIMPLE:
Migrating Company Directory module to LISE
Migrating Company Directory module to LISE
- + - + - + - + - + - + -
Re: [open]Installer:single quote will break JavaScript in Fr
not at this moment, the $lang['finished_.. are not displayed is we use ' (apostrophe)is this fixed in 2.0, JC?
ON TC now the strings are translated with with the ' (right single quote)
if no translator has problem with these strings, it is possible to consider the problem solved for now temporarily
Jean-Claude Etiemble
Re: [open]Installer:single quote will break JavaScript in Fr
Could you please re-test this issue in the Beta 3 release?
Thanks, Rolf
Thanks, Rolf
- + - + - + - + - + - + -
LATEST TUTORIAL AT CMS CAN BE SIMPLE:
Migrating Company Directory module to LISE
Migrating Company Directory module to LISE
- + - + - + - + - + - + -