[solved] [1.6.0.] Bug found

[hihachi]

Hi there,

i am sorry to inform you that i found a bug.

Running CMS Made Simple 1.6
PHP Version 4.4.0
Apache 2.0.54

This Bug is not within the last Version of CMS Made Simple 1.5.4.

Bugreport:

Within the Admin-Backend-Area, please select Content->Pages

On the following Page, please select with the Checkbutton one or more pages. Then select within the select-field at the end of the table the function delete and press submit.

The following error occurs:

Code: Select all

Parse error: parse error, unexpected '=', expecting ')' in /srv/webroot/admin/multicontent.php on line 48

The Line within multicontent.php looks like this:

Code: Select all

function get_delete_list($sel_nodes,&$parent = NULL,&$final_result,$depth = 0)

Please keep in mind with Version 1.5.4. this works without a problem.


Greetings

Matze

[calguy1000]

validate your upload... because I checked the code and it looks valid.

[hihachi]

Hi calguy,

validate your upload... because I checked the code and it looks valid.

downloaded the Source as tgz directly on the shell.
Uncompressed the stuff with mc and copied it right over the old version.
Started install/ugrade.php which run through just fine..

What else should i check?

Matze

[hihachi]

Ok,

installed a brand new fresh version and checked with the file cmsmadesimple-1.6-full-checksum.dat.

Passed every test.

Installed it.

Still this error occured..

Greetings

Matze

[alby]

Still this error occured..

The problem is PHP4
Can you drop  = NULL  from function and report?

function get_delete_list($sel_nodes,&$parent = NULL,&$final_result,$depth = 0)

Alby

[hihachi]

The problem is PHP4
Can you drop  = NULL  from function and report?

function get_delete_list($sel_nodes,&$parent = NULL,&$final_result,$depth = 0)

Alby

What exactly do you mean?

Should i edit the code?

matze

[hihachi]

Ok..

changed the source

into

Code: Select all

function get_delete_list($sel_nodes,&$parent,&$final_result,$depth = 0)

now it seems to work..

at least, there is this security-question and everything selected is deleted then.

Matze

[reneh]

ok
A fix for this will probably come "later" (= next bug fix)

[MyHacks]

Err... sorry to ask. Where can I download version 1.6?

[Ziggywigged]

Err... sorry to ask. Where can I download version 1.6?

Downloads > File Releases:
http://dev.cmsmadesimple.org/project/files/6#package-1

[viebig]

Err... sorry to ask. Where can I download version 1.6?

There is a big button on the top of cmsms site name "Downloads", the rest is up to you! 

Regards

G

[MyHacks]

Gosh!

Last time I checked there I only found version 1.5.4.  

p.s: it was released yesterday and all the download counter is still '0'. lol.

[RonnyK]

Myhacks,

that is because the counter only updates every 24 hrs

Ronny

[hihachi]

Hi there,

ok..now this version seems to work.

My little Upgradeinstructions for Version 1.5.4. to 1.6.0 if you are using an old php-Version (tested php 4.4)

1. Download latest Version (currently 1.6)
2. Make backup of everything .)
3. Copy new Version over old Version
4. Call http://yoursite.com/install/upgrade.php
5. After running through the script, go check Extensions->tinymce and set everything to default values
6. Edit file yourcmsroot/admin/multicontent.php
Line: 48
from:

Code: Select all

function get_delete_list($sel_nodes,&$parent = NULL,&$final_result,$depth = 0)

into

Code: Select all

function get_delete_list($sel_nodes,&$parent,&$final_result,$depth = 0)

Currently testing the upgraded version.Seems to work fine right now..

Matze

[Pierre M.]

You are lucky the DevTeam was around in the forum to respond to your (nice) bug report. You can make the life of the DevTeam easier by filing your (next) bug reports in the forge rather than in the forum : it is easier for the DevTeam to track issues in the forge with an issue #id ; then when the fixpack is ready you can check "fixed #id" in the release notes (and the forge can notify you of the fix).

Have fun with CMSms

Pierre M.