[closed]Installer:single quote will break JavaScript in Fr

Forum rules
Only administrators can post or move items here.
jce76350
Beta Tester
Beta Tester
Posts: 1950
Joined: Mon May 29, 2006 1:20 pm
Location: Rouen

[closed]Installer:single quote will break JavaScript in Fr

Post by jce76350 »

Hi,

if a lang string have single quote
(ex : ... au panneau d\'administration ...
the message is not displayed
if the lang string is : au panneau administration
the message is displayed

so the lang string are used into the files :
in app/wizard/class.wizard_step9.php
- all the string $lang['finished_

in app\wizard/class.wizard_step7.php
- $lang['install_extractfiles'] --> OK in SVN 116

in app/templates/index.tpl
- $lang['confirm_freshen']
- $lang['confirm_upgrade']
Jean-Claude Etiemble
jce76350
Beta Tester
Beta Tester
Posts: 1950
Joined: Mon May 29, 2006 1:20 pm
Location: Rouen

Re: [open]Installer:single quote will break JavaScript in Fr

Post by jce76350 »

In last SVN 114
same problem with "send_admin_email" OK in SVN 116
line 96 \app\wizard\class.wizard_step9.php

If the lang file is
$lang['send_admin_email'] = 'Envoyer les informations d\'identification par email pour la connexion d\'administration';
the message is not displayed on step9

If the string is
$lang['send_admin_email'] = 'Envoyer les identifiants par email pour la connexion Admin';
the message is displayed on step9
Jean-Claude Etiemble
calguy1000
Support Guru
Support Guru
Posts: 8169
Joined: Tue Oct 19, 2004 6:44 pm
Location: Fernie British Columbia, Canada

Re: [open]Installer:single quote will break JavaScript in Fr

Post by calguy1000 »

should be fixed now.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
jce76350
Beta Tester
Beta Tester
Posts: 1950
Joined: Mon May 29, 2006 1:20 pm
Location: Rouen

Re: [open]Installer:single quote will break JavaScript in Fr

Post by jce76350 »

should be fixed now.
Rev 116 Not OK for
in app/templates/index.tpl
- $lang['confirm_freshen']
- $lang['confirm_upgrade']

EDIT
Not OK for
in app/wizard/class.wizard_step9.php
- all the string $lang['finished_

OK for
in app\wizard/class.wizard_step7.php
- $lang['install_extractfiles']
Jean-Claude Etiemble
jce76350
Beta Tester
Beta Tester
Posts: 1950
Joined: Mon May 29, 2006 1:20 pm
Location: Rouen

Re: [open]Installer:single quote will break JavaScript in Fr

Post by jce76350 »

Rev 116 OK for this string
line 96 \app\wizard\class.wizard_step9.php
$lang['send_admin_email'] = 'Envoyer les informations d\'identification par email pour la connexion d\'administration';
Jean-Claude Etiemble
jce76350
Beta Tester
Beta Tester
Posts: 1950
Joined: Mon May 29, 2006 1:20 pm
Location: Rouen

Re: [open]Installer:single quote will break JavaScript in Fr

Post by jce76350 »

to temporarily correct the problem

- $lang['confirm_freshen']
- $lang['confirm_upgrade']
and all the string $lang['finished_

are translated into French by replacing the ' (apostrophe) with the ' (right single quote)
Jean-Claude Etiemble
calguy1000
Support Guru
Support Guru
Posts: 8169
Joined: Tue Oct 19, 2004 6:44 pm
Location: Fernie British Columbia, Canada

Re: [open]Installer:single quote will break JavaScript in Fr

Post by calguy1000 »

With the latest snapshot built phar-installer I could not reproduce this problem.

I used the .phar file in 'freshen' mode, in French, on an existing 2.0-beta2 install, and watching the javascript console for errors. The confirmation messages appeared just fine and no javascript errors were encountered.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
jce76350
Beta Tester
Beta Tester
Posts: 1950
Joined: Mon May 29, 2006 1:20 pm
Location: Rouen

Re: [open]Installer:single quote will break JavaScript in Fr

Post by jce76350 »

With the latest snapshot built phar-installer I could not reproduce this problem.
as you see on the post above

Code: Select all

to temporarily correct the problem
- $lang['confirm_freshen']
- $lang['confirm_upgrade']
and all the string $lang['finished_
are translated into French by replacing the ' (apostrophe) with the ' (right single quote)
so to test You need to replace the ' (right single quote) by ' (apostrophe)
and you won't have any messages
- $lang['confirm_freshen']
- $lang['finished_
Jean-Claude Etiemble
calguy1000
Support Guru
Support Guru
Posts: 8169
Joined: Tue Oct 19, 2004 6:44 pm
Location: Fernie British Columbia, Canada

Re: [open]Installer:single quote will break JavaScript in Fr

Post by calguy1000 »

fixed in svn, thanks.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
jce76350
Beta Tester
Beta Tester
Posts: 1950
Joined: Mon May 29, 2006 1:20 pm
Location: Rouen

Re: [open]Installer:single quote will break JavaScript in Fr

Post by jce76350 »

sorry not, the French language is not easy ;)

test with Rev 122
with $lang['confirm_freshen']='Êtes-vous sûr(e) de vouloir rafraîchir l\'installation existante de CMSMS ?'; // ' (apostrophe)
freshen : '{'confirm_freshen'|tr|escape}' shows
Êtes-vous sûr(e) de vouloir rafraîchir l'installation existante de CMSMS ?
so not correct it would be
Êtes-vous sûr(e) de vouloir rafraîchir l'installation

and the $lang['finished_ are not displayed besause the problem is on the set_block_html('bottom_nav'
Jean-Claude Etiemble
calguy1000
Support Guru
Support Guru
Posts: 8169
Joined: Tue Oct 19, 2004 6:44 pm
Location: Fernie British Columbia, Canada

Re: [open]Installer:single quote will break JavaScript in Fr

Post by calguy1000 »

should now be fixed... I call addslashes instead of escape.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
jce76350
Beta Tester
Beta Tester
Posts: 1950
Joined: Mon May 29, 2006 1:20 pm
Location: Rouen

Re: [open]Installer:single quote will break JavaScript in Fr

Post by jce76350 »

1/2 solved in rev 125

Ok the the $lang['confirm_freshen']
tha'ts fine

But not for the set_block_html
the $lang['finished_ are not displayed
so the the JavaScript break the output.

The ' (right single quote) into our translation works and
I suggests to leave out this problem at the moment.
Try later afert the beta2.
Jean-Claude Etiemble
User avatar
Rolf
Dev Team Member
Dev Team Member
Posts: 7739
Joined: Wed Apr 23, 2008 7:53 am
Location: The Netherlands

Re: [open]Installer:single quote will break JavaScript in Fr

Post by Rolf »

is this fixed in 2.0, JC?
Image
- + - + - + - + - + -
Latest CMSMS tutorial: FormBuilder WatchGuard
- + - + - + - + - + -
Did my post help you solving a problem at your (customers) website and it saved you many hours of work?
Great!! Buy me a cup of coffee in return as a small token of appreciation!
jce76350
Beta Tester
Beta Tester
Posts: 1950
Joined: Mon May 29, 2006 1:20 pm
Location: Rouen

Re: [open]Installer:single quote will break JavaScript in Fr

Post by jce76350 »

is this fixed in 2.0, JC?
not at this moment, the $lang['finished_.. are not displayed is we use ' (apostrophe)
ON TC now the strings are translated with with the ' (right single quote)
if no translator has problem with these strings, it is possible to consider the problem solved for now temporarily
Jean-Claude Etiemble
User avatar
Rolf
Dev Team Member
Dev Team Member
Posts: 7739
Joined: Wed Apr 23, 2008 7:53 am
Location: The Netherlands

Re: [open]Installer:single quote will break JavaScript in Fr

Post by Rolf »

Could you please re-test this issue in the Beta 3 release?

Thanks, Rolf
Image
- + - + - + - + - + -
Latest CMSMS tutorial: FormBuilder WatchGuard
- + - + - + - + - + -
Did my post help you solving a problem at your (customers) website and it saved you many hours of work?
Great!! Buy me a cup of coffee in return as a small token of appreciation!
Post Reply

Return to “Closed Issues”