[closed] Admin menu items

Forum rules
Only administrators can post or move items here.
Post Reply
kristoftorfs
Forum Members
Forum Members
Posts: 11
Joined: Tue Jul 08, 2014 1:15 pm
Location: Belgium

[closed] Admin menu items

Post by kristoftorfs »

Hi,

I'm having an issue with the admin menu items. I have a couple of menu items in my module which all redirect to the same module action, but with a different parameter.

Let's take the following menu items as an example:
  1. action=myaction,myparam=firstparam
  2. action=myaction,myparam=secondparam
  3. action=myaction,myparam=thirdparam
  4. action=myaction,myparam=fourthparam
Now when I open for example the third menu item, the first one is highlighted as active, as this is the first one for this action and thus marked as active.

When finding the active menu item, the admin theme should also check the parameters, not only the action.
calguy1000
Support Guru
Support Guru
Posts: 8169
Joined: Tue Oct 19, 2004 6:44 pm
Location: Fernie British Columbia, Canada

Re: Admin menu items

Post by calguy1000 »

yeah we probably won't be fixing this. Multiple admin menu items for the same module must go to different actions.
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.
kristoftorfs
Forum Members
Forum Members
Posts: 11
Joined: Tue Jul 08, 2014 1:15 pm
Location: Belgium

Re: Admin menu items

Post by kristoftorfs »

Can i fix this myself, and pass the changes on to you for revision? If I have to make changes to the CMS itself, I would prefer they would end up in the official release.
User avatar
Rolf
Dev Team Member
Dev Team Member
Posts: 7772
Joined: Wed Apr 23, 2008 7:53 am
Location: The Netherlands
Contact:

Re: Admin menu items

Post by Rolf »

Thanks for testing, kristoftorfs

Please email me your suggested code changes and we will see if we can implement this. I can't promise it will be in the 2.0 release, might be in a later release... It depends on the impact on the existing code (possibility to break some other functions).

Grtz. Rolf
Image
- + - + - + - + - + -
Latest CMSMS tutorial: FormBuilder WatchGuard
- + - + - + - + - + -
Did my post help you solving a problem at your (customers) website and it saved you many hours of work?
Great!! Buy me a cup of coffee in return as a small token of appreciation!
kristoftorfs
Forum Members
Forum Members
Posts: 11
Joined: Tue Jul 08, 2014 1:15 pm
Location: Belgium

Re: Admin menu items

Post by kristoftorfs »

Okay, I'll get started on it tomorrow. Might take me a few days as these are pretty pretty busy times for me.

At first glance the changes shouldn't be too evasive as I simply plan to simply expand the functionality of the CmsAdminMenuItem class.

Should I notify you in this post when I'm done, or some other way?
User avatar
Rolf
Dev Team Member
Dev Team Member
Posts: 7772
Joined: Wed Apr 23, 2008 7:53 am
Location: The Netherlands
Contact:

Re: Admin menu items

Post by Rolf »

You can reach me at rolf@the-domain-name-above-in-your-browser ^ ;)
Image
- + - + - + - + - + -
Latest CMSMS tutorial: FormBuilder WatchGuard
- + - + - + - + - + -
Did my post help you solving a problem at your (customers) website and it saved you many hours of work?
Great!! Buy me a cup of coffee in return as a small token of appreciation!
kristoftorfs
Forum Members
Forum Members
Posts: 11
Joined: Tue Jul 08, 2014 1:15 pm
Location: Belgium

Re: [open] Admin menu items

Post by kristoftorfs »

I've been looking into this, but it seems that the way the admin menu system currently works, it is nearly impossible to get this working without altering too much of the existing code.

Guess I'll just have to rewrite my module to use different actions somehow.
Post Reply

Return to “Closed Issues”