• twitter image
  • facebook image
  • youtube image
  • linkedin image
Language: CMS Made Simple Czech CMS Made Simple France CMS Made Simple Spain CMS Made Simple Hungary CMS Made Simple Russia CMS Made Simple Netherlands

All times are UTC


Forum rules


Only administrators can post or move items here.



Post new topic Reply to topic  [ 7 posts ] 
Author Message
 Post subject: [closed] Admin menu items
PostPosted: Thu Sep 04, 2014 1:36 pm 
Offline
Forum Members
Forum Members

Joined: Tue Jul 08, 2014 1:15 pm
Posts: 11
Location: Belgium
Hi,

I'm having an issue with the admin menu items. I have a couple of menu items in my module which all redirect to the same module action, but with a different parameter.

Let's take the following menu items as an example:
  1. action=myaction,myparam=firstparam
  2. action=myaction,myparam=secondparam
  3. action=myaction,myparam=thirdparam
  4. action=myaction,myparam=fourthparam

Now when I open for example the third menu item, the first one is highlighted as active, as this is the first one for this action and thus marked as active.

When finding the active menu item, the admin theme should also check the parameters, not only the action.


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: Admin menu items
PostPosted: Thu Sep 04, 2014 3:07 pm 
Offline
Dev Team Member
Dev Team Member
User avatar

Joined: Tue Oct 19, 2004 6:44 pm
Posts: 8167
Location: Fernie British Columbia, Canada
yeah we probably won't be fixing this. Multiple admin menu items for the same module must go to different actions.

_________________
Follow me on twitter
Please post system information from "Extensions >> System Information" (there is a bbcode option) on all posts asking for assistance.
--------------------
If you can't bother explaining your problem well, you shouldn't expect much in the way of assistance.


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: Admin menu items
PostPosted: Thu Sep 04, 2014 3:09 pm 
Offline
Forum Members
Forum Members

Joined: Tue Jul 08, 2014 1:15 pm
Posts: 11
Location: Belgium
Can i fix this myself, and pass the changes on to you for revision? If I have to make changes to the CMS itself, I would prefer they would end up in the official release.


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: Admin menu items
PostPosted: Thu Sep 04, 2014 5:37 pm 
Offline
Dev Team Member
Dev Team Member
User avatar

Joined: Wed Apr 23, 2008 7:53 am
Posts: 7710
Location: The Netherlands
Thanks for testing, kristoftorfs

Please email me your suggested code changes and we will see if we can implement this. I can't promise it will be in the 2.0 release, might be in a later release... It depends on the impact on the existing code (possibility to break some other functions).

Grtz. Rolf

_________________
$1

Did my post help you solving a problem at your (customers) website and it saved you many hours of work? Great!! Consider buying me a cup of coffee in return!



Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: Admin menu items
PostPosted: Thu Sep 04, 2014 5:56 pm 
Offline
Forum Members
Forum Members

Joined: Tue Jul 08, 2014 1:15 pm
Posts: 11
Location: Belgium
Okay, I'll get started on it tomorrow. Might take me a few days as these are pretty pretty busy times for me.

At first glance the changes shouldn't be too evasive as I simply plan to simply expand the functionality of the CmsAdminMenuItem class.

Should I notify you in this post when I'm done, or some other way?


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: Admin menu items
PostPosted: Thu Sep 04, 2014 6:00 pm 
Offline
Dev Team Member
Dev Team Member
User avatar

Joined: Wed Apr 23, 2008 7:53 am
Posts: 7710
Location: The Netherlands
You can reach me at rolf@the-domain-name-above-in-your-browser ^ ;)

_________________
$1

Did my post help you solving a problem at your (customers) website and it saved you many hours of work? Great!! Consider buying me a cup of coffee in return!



Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
 Post subject: Re: [open] Admin menu items
PostPosted: Mon Sep 22, 2014 6:01 am 
Offline
Forum Members
Forum Members

Joined: Tue Jul 08, 2014 1:15 pm
Posts: 11
Location: Belgium
I've been looking into this, but it seems that the way the admin menu system currently works, it is nearly impossible to get this working without altering too much of the existing code.

Guess I'll just have to rewrite my module to use different actions somehow.


Top
  Profile  
 
Share On:
Share on Facebook Share on Twitter Share on Google+
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 7 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Hosting Nation - Managed CMSMS Hosting