Problem after upgrading from 2.1.2 to 2.2.15

[urbini]

Hi,
after a long time finally I've upgraded CMSMS from the old 2.1.2 to 2.2.15 version, but I have a problem.
In the page https://www.torrisi-procopio.com/projec ... -2021.html I get a fatal error:

ERROR at line 3 of file /var/www/vhosts/torrisi-procopio.com/httpdocs/lib/smarty/sysplugins/smarty_internal_templatecompilerbase.php

ERROR MESSAGE:
Syntax error in template "eval:

The page uses an image gallery made with the Gallery module, before upgrading it worked fine.
In the Firefox console I see two 404 errors too.

I can't find the cause of this issue, can you help me?
Below the system information.
Thanks
Andrea


----------------------------------------------

Cms Version: 2.2.15

Installed Modules:

AdminSearch: 1.0.5
CMSContentManager: 1.1.9
CmsJobManager: 0.1.3
DesignManager: 1.1.9
FileManager: 1.6.12
FilePicker: 1.0.5
Gallery: 2.4.2
MenuManager: 1.50.3
MicroTiny: 2.2.5
ModuleManager: 2.1.8
Navigator: 1.0.9
News: 2.51.11
Search: 1.52


Config Information:

php_memory_limit:
max_upload_size: 128000000
url_rewriting: mod_rewrite
page_extension: .html
query_var: page
auto_alias_content: true
locale:
set_names: true
timezone: Europe/Rome
permissive_smarty: false


Php Information:

phpversion: 7.4.26
md5_function: On (True)
json_function: On (True)
gd_version: 2
tempnam_function: On (True)
magic_quotes_runtime: Off (False)
E_ALL: 22519
E_STRICT: 0
E_DEPRECATED: 0
test_file_timedifference: No time difference found
test_db_timedifference: No time difference found
create_dir_and_file: 1
memory_limit: 512M
max_execution_time: 299
register_globals: Off (False)
output_buffering: 4096
disable_functions: popen, exec, ini_alter, passthru, pcntl_exec, show_source, shell_exec, symlink, system, curl_multi_exec, posix_getpwuid, opcache_get_status
open_basedir: /var/www/vhosts/torrisi-procopio.com/httpdocs/:/tmp/:/opt/plesk/php/5.2/share/pear/:/opt/plesk/php/5.3/share/pear/:/opt/plesk/php/5.4/share/pear/:/opt/plesk/php/5.5/share/pear/:/opt/plesk/php/5.6/share/pear/:/opt/plesk/php/7.0/share/pear/:/opt/plesk/php/7.1/share/pear/:/opt/plesk/php/7.2/share/pear/:/opt/plesk/php/7.3/share/pear/:/opt/plesk/php/7.4/share/pear/
test_remote_url: Success
file_uploads: On (True)
post_max_size: 128M
upload_max_filesize: 128M
session_save_path: No check because open basedir active
session_use_cookies: On (True)
xml_function: On (True)
xmlreader_class: On (True)
check_ini_set: On (True)
curl: On


Performance Information:

allow_browser_cache: Off (False)
browser_cache_expiry: 60
php_opcache: On (True)
smarty_cache: Off (False)
smarty_compilecheck: Off (False)
auto_clear_cache_age: On (True)

Server Information:

Server Software: Apache
Server Api: cgi-fcgi
Server Os: Linux 3.10.0-962.3.2.lve1.5.62.el7.x86_64 On x86_64
Server Db Type: MySQL (mysqli)
Server Db Version: 5.7.36
Server Db Grants: Found a "GRANT ALL" statement that appears to be suitable


Permission Information:

tmp: /var/www/vhosts/torrisi-procopio.com/httpdocs/tmp (0755)
tmp_cache: /var/www/vhosts/torrisi-procopio.com/httpdocs/tmp/cache (0755)
templates_c: /var/www/vhosts/torrisi-procopio.com/httpdocs/tmp/templates_c (0755)
modules: /var/www/vhosts/torrisi-procopio.com/httpdocs/modules (0755)
uploads: /var/www/vhosts/torrisi-procopio.com/httpdocs/uploads (0755)
File Creation Mask (umask): /var/www/vhosts/torrisi-procopio.com/httpdocs/tmp/cache (0755)
config_file: 0444

----------------------------------------------

[DIGI3]

Have you also updated the Gallery module? If so, try setting your gallery to a default template temporarily to see if the problem goes away. If it does, you'll need to go through your template to see what's causing it - commenting out parts until it works is one way of doing that.

Check your admin log too, there may be more clues, as it looks like the php error log didn't include a lot (unless that was the forum cutting off the message)

[urbini]

Hi DIGI3, first of all thanks for your reply.

I've already upgraded the Gallery module.

I didn't take a look at the admin log, now I've done it. I find smarty errors related to two different gallery templates, field "Template JavaScript", but I can't understand what's wrong. Here are the two errors:

Syntax error in template "eval:<!-- <__script__ type="text/javascript" src=..." on line 5
On line 5 there is:

Code: Select all

$(document).ready(function(){$("a[rel^='prettyPhoto']").prettyPhoto({animation_speed:'fast',slideshow:5000,autoplay_slideshow:false,show_title:true,allow_resize:true,counter_separator_label:'/',theme:'pp_default',hideflash:false,overlay_gallery:true,keyboard_shortcuts:true,deeplinking:true});});

Syntax error in template "eval:<__script__ src="/modules/Gallery/templates/..." on line 3
On line 3 there is:

Code: Select all

$(function(){$(".rslides").responsiveSlides({auto:true,speed:1000,timeout:4000,pager:true,nav:false,random:false,pause:false,pauseControls:true,prevText:"Previous",nextText:"Next",maxwidth:"900",navContainer:"",manualControls:"",namespace:"rslides",before:function(){},after:function(){}});});

I think the cause is the same.
Thanks
Andrea

[Jo Morg]

The fix is simple and I wonder the issue only came up after the upgrade:
- when using javascript on a template the { characters must have an empty space right after; It won't make a difference in terms of javascript syntax, but will prevent Smarty from assuming that the whatever starts with { is a smarty tag hence breaking with an error.
HTH

[urbini]

Hi Jo Morg, it works! As you told, the fix was very simple!!
Thank you very much to everyone
Best regards
Andrea