[closed] Path separators in DisplayImage()

The members of the Dev team will place issues here that they consider to be solved.
Post Reply
tomphantoo
Forum Members
Forum Members
Posts: 13
Joined: Mon Apr 11, 2011 7:33 am

[closed] Path separators in DisplayImage()

Post by tomphantoo »

There are quite a few instances of hardcoded path separator '/' in DisplayImage() (in file class.admintheme.inc.php).

It seems that this func deals with paths, not URL's, and in that case, should the separators be DIRECTORY_SEPARATOR ?

Same for 1.9.
User avatar
Rolf
Dev Team Member
Dev Team Member
Posts: 7754
Joined: Wed Apr 23, 2008 7:53 am
Location: The Netherlands
Contact:

Re: Path separators in DisplayImage()

Post by Rolf »

tomphantoo wrote:There are quite a few instances of hardcoded path separator '/' in DisplayImage() (in file class.admintheme.inc.php).

It seems that this func deals with paths, not URL's, and in that case, should the separators be DIRECTORY_SEPARATOR ?

Same for 1.9.
We don't think hardcoded '/' would cause any problems, even now in Windoze ;)

Rolf
Image
- + - + - + - + - + -
Latest CMSMS tutorial: FormBuilder WatchGuard
- + - + - + - + - + -
Did my post help you solving a problem at your (customers) website and it saved you many hours of work?
Great!! Buy me a cup of coffee in return as a small token of appreciation!
Post Reply

Return to “Closed Issues”